Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: test session logical names #2904

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR implements a new CI Visibility feature called Test session logical names. In this feature a new DD_TEST_SESSION_NAME environment variable is introduced for customer to set their custom test session name. This name is sent to the backend inside the metadata object in the CI Visibility protocol.

Motivation

New feature: https://docs.google.com/document/d/1XPBDDIMUxzfkko66vXIEjoi4xbCamTz-Bv6ChSR8jys/edit

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo self-assigned this Oct 2, 2024
@tonyredondo tonyredondo marked this pull request as ready for review October 2, 2024 14:25
@tonyredondo tonyredondo requested review from a team as code owners October 2, 2024 14:25
@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024

Benchmarks

Benchmark execution time: 2024-10-02 14:41:32

Comparing candidate commit db7ab5a in PR branch tony/civisibility-test-session-logical-names with baseline commit 0f6ba13 in branch main.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

scenario:BenchmarkOTelApiWithCustomTags/datadog_otel_api-24

  • 🟩 execution_time [-175.987ns; -142.813ns] or [-3.632%; -2.948%]

scenario:BenchmarkOTelApiWithCustomTags/otel_api-24

  • 🟩 execution_time [-199.912ns; -147.088ns] or [-2.762%; -2.032%]

scenario:BenchmarkSetTagStringPtr-24

  • 🟩 execution_time [-8.466ns; -3.694ns] or [-4.842%; -2.113%]

scenario:BenchmarkSingleSpanRetention/with-rules/match-all-24

  • 🟥 execution_time [+5.595µs; +6.240µs] or [+2.375%; +2.649%]

@tonyredondo tonyredondo force-pushed the tony/civisibility-test-session-logical-names branch from db7ab5a to d332b0d Compare October 3, 2024 16:09
@tonyredondo tonyredondo merged commit 3b1e8a9 into main Oct 3, 2024
144 of 145 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-test-session-logical-names branch October 3, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants