-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/civisibility: automatic test retries #2892
Conversation
c3142af
to
50e8be3
Compare
BenchmarksBenchmark execution time: 2024-10-03 22:12:07 Comparing candidate commit 3e279cb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
39d8c89
to
f3ac8b9
Compare
f176609
to
868acf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some very minor nits
…ings and early flake detection data at CI Visibility initialization.
…es as a test func wrapper (for EFD and Flaky Retries) # Conflicts: # internal/civisibility/constants/env.go
…r all the test metadata handling.
…add some comments.
…. Improved code comments. Fix an issue with the suite and module event closing when running retries.
de7d8da
to
3e279cb
Compare
What does this PR do?
This PR adds the automatic test retries ci visibility feature as described in the RFC: https://docs.google.com/document/d/1Cy6n-CHu0QPV1_Jn9yLCa3aBvgm1JjviFDEq6oUzyuQ/edit#heading=h.rnd972k0hiye
The PR also works as a foundation to implement Early Flake Detection feature in a subsequence PR.
Motivation
This is a new feature we are implementing across all CI Visibility libraries.
Reviewer's Checklist
Unsure? Have a question? Request a review!