Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: automatic test retries #2892

Merged
merged 18 commits into from
Oct 3, 2024

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Sep 26, 2024

What does this PR do?

This PR adds the automatic test retries ci visibility feature as described in the RFC: https://docs.google.com/document/d/1Cy6n-CHu0QPV1_Jn9yLCa3aBvgm1JjviFDEq6oUzyuQ/edit#heading=h.rnd972k0hiye

The PR also works as a foundation to implement Early Flake Detection feature in a subsequence PR.

Motivation

This is a new feature we are implementing across all CI Visibility libraries.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo force-pushed the tony/civisibility-initialization-requests branch from c3142af to 50e8be3 Compare September 26, 2024 21:00
@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024

Benchmarks

Benchmark execution time: 2024-10-03 22:12:07

Comparing candidate commit 3e279cb in PR branch tony/civisibility-initialization-requests with baseline commit e90c07d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@tonyredondo tonyredondo force-pushed the tony/civisibility-initialization-requests branch from 39d8c89 to f3ac8b9 Compare October 1, 2024 15:30
@tonyredondo tonyredondo changed the title internal/civisibility: Requesting backend at initialization (settings and efd tests) internal/civisibility: automatic test retries Oct 1, 2024
@tonyredondo tonyredondo force-pushed the tony/civisibility-initialization-requests branch from f176609 to 868acf4 Compare October 2, 2024 11:09
@tonyredondo tonyredondo marked this pull request as ready for review October 2, 2024 11:36
@tonyredondo tonyredondo requested a review from a team as a code owner October 2, 2024 11:36
@tonyredondo tonyredondo requested a review from liashenko October 2, 2024 11:36
Copy link
Contributor

@ManuelPalenzuelaDD ManuelPalenzuelaDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some very minor nits

…ings and early flake detection data at CI Visibility initialization.
…es as a test func wrapper (for EFD and Flaky Retries)

# Conflicts:
#	internal/civisibility/constants/env.go
…. Improved code comments. Fix an issue with the suite and module event closing when running retries.
@tonyredondo tonyredondo force-pushed the tony/civisibility-initialization-requests branch from de7d8da to 3e279cb Compare October 3, 2024 21:28
@tonyredondo tonyredondo merged commit d3f686e into main Oct 3, 2024
145 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-initialization-requests branch October 3, 2024 22:56
MNThomson pushed a commit to agilebits/dd-trace-go that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants