Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/civisibility/integrations/gotesting: improve the isCiVisibilityEnabled and enable reporting Code Coverage percentage. #2866

Merged
merged 1 commit into from
Sep 13, 2024
Merged

internal/civisibility/integrations/gotesting: improve the isCiVisibilityEnabled and enable reporting Code Coverage percentage. #2866

merged 1 commit into from
Sep 13, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR fixes and issue with the atomic.Int32 used in the isCiVisibilityEnabled func, also enables reporting of the code coverage data in a test session.

Motivation

Iterating with orchestrion and finding issues and possible improvements.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo
internal/civisibility/integrations/gotesting: improve the isCiVisibil…
d4ae4a7 
…ityEnabled func code, and enable reporting Code Coverage percentage.
@tonyredondo tonyredondo self-assigned this Sep 13, 2024
@tonyredondo tonyredondo requested a review from a team as a code owner September 13, 2024 14:46
ManuelPalenzuelaDD
ManuelPalenzuelaDD approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ManuelPalenzuelaDD ManuelPalenzuelaDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyredondo tonyredondo merged commit 63f207d into main Sep 13, 2024
134 of 135 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-fixes-and-codecoverage branch September 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelPalenzuelaDD ManuelPalenzuelaDD ManuelPalenzuelaDD approved these changes

@romainkomorndatadog romainkomorndatadog romainkomorndatadog approved these changes

@juan-fernandez juan-fernandez juan-fernandez approved these changes

Assignees

@tonyredondo tonyredondo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyredondo @juan-fernandez @romainkomorndatadog @ManuelPalenzuelaDD