Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/stacktrace: upgrade msgp and add stacktrace.GetSpanValue #2864

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

eliottness
Copy link
Contributor

What does this PR do?

This PR runs go get github.com/tinylib/[email protected] and complete a TODO task left because of it

This PR also adds the GetSpanValue function currently blocking #2862

Motivation

Reduce technical debt and prevent future one in #2862 👁️ 👁️

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness force-pushed the eliott.bouhana/msgp-upgrade branch from 94c856f to faca07c Compare September 13, 2024 14:03
@eliottness eliottness marked this pull request as ready for review September 13, 2024 14:24
@eliottness eliottness requested a review from a team as a code owner September 13, 2024 14:24
@eliottness eliottness force-pushed the eliott.bouhana/msgp-upgrade branch from faca07c to eba7c9c Compare September 13, 2024 14:24
@eliottness eliottness enabled auto-merge (squash) September 13, 2024 14:25
@eliottness eliottness merged commit 660a6a2 into main Sep 13, 2024
155 of 156 checks passed
@eliottness eliottness deleted the eliott.bouhana/msgp-upgrade branch September 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants