appsec: missing SQLi and LFI RC capabilities #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-09-09 16:30:45 Comparing candidate commit 4eae623 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
darccio
approved these changes
Sep 10, 2024
Julio-Guerra
requested changes
Sep 10, 2024
| @@ -409,7 +410,14 @@ func (a *appsec) enableRASP() { | |||
| if err := remoteconfig.RegisterCapability(remoteconfig.ASMRASPSSRF); err != nil { | |||
| log.Debug("appsec: Remote config: couldn't register RASP SSRF: %v", err) | |||
| } | |||
| // TODO: register other RASP capabilities when supported | |||
| if err := remoteconfig.RegisterCapability(remoteconfig.ASMRASPSQLI); err != nil { | |||
There was a problem hiding this comment.
WDYT of moving the calls to RegisterCapability into the WAF listener's instantiations, like setting the SQLi capability when the SQL listener is being setup?
Julio-Guerra
approved these changes
Sep 10, 2024
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliott.bouhana/more-rc-capabilities
branch
from
4eae623 to
b252a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reviewer's Checklist
Unsure? Have a question? Request a review!