contrib/aws/aws-sdk-go-v2/aws: Fix streamName nil pointer panic #2846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the AWS Kinesis API Docs:
Currently, if requests use only the
StreamARN
parameter (as recommended by AWS), thestreamName
function will panic with a nil pointer.I've updated the function to return the name first (if provided) to keep backwards compatibility. If that is nil, then it uses the resource part of the ARN. If that is nil, it returns empty string instead of panicking.
I added a second method
coalesceNameOrArnResource
(if you have a better name, let me know) to prevent having the code be copy/pasted for each switch member.What does this PR do?
Motivation
Reviewer's Checklist