Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Visibility] Refactor gotesting integration to be used by orchestrion #2843

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR is a refactor of the existing code so the new methods can be used by the orchestrion instrumentation. It doesn't introduce any new functionality and the existing tests are enough for testing the refactored code.

Motivation

Playing with orchestrion I realised that the current internal apis are really hard to call from an orchestrion integration, the refactor creates a new set of methods that can be easily called from methods prepend code kind of integrations.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024

Benchmarks

Benchmark execution time: 2024-09-06 11:02:11

Comparing candidate commit 6a4ca88 in PR branch tony/civisibility-refactor-for-orchestrion with baseline commit 50f9384 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics.

scenario:BenchmarkPartialFlushing/Disabled-24

  • 🟩 avgHeapInUse(Mb) [-7.612MB; -1.402MB] or [-11.127%; -2.049%]

Copy link
Contributor

@ManuelPalenzuelaDD ManuelPalenzuelaDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor nit

internal/civisibility/integrations/gotesting/testingB.go Outdated Show resolved Hide resolved
@eliottness
Copy link
Contributor

Merging on behalf of @tonyredondo

@eliottness eliottness merged commit af1c48b into main Sep 6, 2024
165 checks passed
@eliottness eliottness deleted the tony/civisibility-refactor-for-orchestrion branch September 6, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants