ddtrace/tracer: noDebugStack config reports to telemetry under distinct key debug_stack_enabled #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtoffl01
changed the title
mtoffl01
changed the title
BenchmarksBenchmark execution time: 2024-07-29 17:47:37 Comparing candidate commit 40a189a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics. |
darccio
approved these changes
Jul 26, 2024
ddtrace/tracer/telemetry_test.go
Outdated
Comment on lines
46
to
47
| telemetry.Check(t, telemetryClient.Configuration, "trace_debug_enabled", true) | ||
| telemetry.Check(t, telemetryClient.Configuration, "trace_debug_enabled", true) |
There was a problem hiding this comment.
@mtoffl01 Do we need to duplicate this check?
|
Moving to draft as discussions are still ongoing about how to name the telem field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
noDebugStacktracer configuration now reports telemetry under the keydebug_stack_enabled.Note: New
debug_stack_enabledfield added to telemetry backend here: https://github.com/DataDog/dd-go/pull/143865Motivation
Prior to this change, the
noDebugStackconfig was incorrectly reporting telemetry under the keytrace_debug_enabled.Reviewer's Checklist
Unsure? Have a question? Request a review!