-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: update the expected telemetry tags for OTel env-var mapping #2797
Conversation
91a7e8c
to
e41aa1c
Compare
BenchmarksBenchmark execution time: 2024-07-25 12:38:07 Comparing candidate commit f09a5fb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics. |
…with the latest RFC config.datadog -> config_datadog config.opentelemetry -> config_opentelemetry The expected tag values should also be lower-case.
e41aa1c
to
f09a5fb
Compare
@mcculls Can we safely assume that the telemetry backend will handle both formats, right? |
The metric definitions were only recently added to telemetry intake allow list in https://github.com/DataDog/dd-go/pull/142947 (using the latest format from the RFC - the reason for the change was that the dotted names are not valid tag names for telemetry) |
What does this PR do?
The expected telemetry tags when reporting OTel env-var mapping issues now use snake-case:
The expected tag values should also be lower-case.
Motivation
The RFC has been revised since #2715
Reviewer's Checklist
Unsure? Have a question? Request a review!