-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mtoff/span events #2780
Merged
Merged
Mtoff/span events #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtoffl01
commented
Jul 9, 2024
mtoffl01
commented
Jul 9, 2024
mtoffl01
commented
Jul 9, 2024
…etting underlying attribute.Value value
darccio
requested changes
Jul 10, 2024
darccio
reviewed
Jul 11, 2024
ddtrace/opentelemetry/span.go
Outdated
@@ -45,6 +48,35 @@ func (s *span) SetName(name string) { | |||
s.attributes[ext.SpanName] = strings.ToLower(name) | |||
} | |||
|
|||
// SpanEvent holds information about span events | |||
type SpanEvent struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
type SpanEvent struct { | |
type spanEvent struct { |
Do we need to export this? Could it be an internal type?
darccio
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as it's good to go, with only the minor edit of spanEvent
pending to apply.
7 tasks
darccio
approved these changes
Jul 15, 2024
to reflect latest commit
revert changes that point CI to run specific commit hash of the system tests
1 task
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for span events using the Opentelemetry AddEvent API in dd-trace-go.
Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!