Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mtoff/span events #2780

Merged
merged 23 commits into from
Jul 15, 2024
Merged

Mtoff/span events #2780

merged 23 commits into from
Jul 15, 2024

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Jul 9, 2024

What does this PR do?

Adds support for span events using the Opentelemetry AddEvent API in dd-trace-go.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

go.mod Outdated Show resolved Hide resolved
@mtoffl01 mtoffl01 marked this pull request as ready for review July 9, 2024 20:20
@mtoffl01 mtoffl01 requested a review from a team as a code owner July 9, 2024 20:20
ddtrace/opentelemetry/span.go Outdated Show resolved Hide resolved
ddtrace/opentelemetry/span.go Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2024

Benchmarks

Benchmark execution time: 2024-07-15 19:01:19

Comparing candidate commit 6c7ab6c in PR branch mtoff/span-events with baseline commit 974aea6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics.

go.mod Outdated Show resolved Hide resolved
@mtoffl01 mtoffl01 requested a review from darccio July 11, 2024 14:27
@@ -45,6 +48,35 @@ func (s *span) SetName(name string) {
s.attributes[ext.SpanName] = strings.ToLower(name)
}

// SpanEvent holds information about span events
type SpanEvent struct {
Copy link
Member

@darccio darccio Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type SpanEvent struct {
type spanEvent struct {

Do we need to export this? Could it be an internal type?

Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it's good to go, with only the minor edit of spanEvent pending to apply.

@mtoffl01 mtoffl01 requested a review from a team as a code owner July 12, 2024 18:06
@mtoffl01 mtoffl01 merged commit 5438748 into main Jul 15, 2024
162 of 164 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/span-events branch July 15, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants