Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Visibility] CI Test Visibility integration (#2736) #2774

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

liashenko
Copy link
Contributor

What does this PR do?

This PR contains merged changes from the stacked PRs (they've been approved):

  1. [CI Visibility] Initial internal consts and utilities #2736
  2. [CI Visibility] Add support for CI Visibility mode in ddtrace #2739
  3. [CI Visibility] Manual Api and Go/Testing integration #2742

All current API are private inside the internal folder. We are planning to use them later by using the orchestrion project to do automatic instrumentation.

Motivation

After this PR we can instrument tests with CI Visibility product.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Co-authored-by: Manuel Palenzuela Merino <[email protected]>
Co-authored-by: liashenko <[email protected]>
@liashenko liashenko requested review from a team as code owners July 8, 2024 10:05
@pr-commenter
Copy link

pr-commenter bot commented Jul 8, 2024

Benchmarks

Benchmark execution time: 2024-07-08 13:17:39

Comparing candidate commit 90b5124 in PR branch tony/civisibility-ddtrace with baseline commit 891aad4 in branch main.

Found 3 performance improvements and 2 performance regressions! Performance is the same for 42 metrics, 0 unstable metrics.

scenario:BenchmarkHttpServeTrace-24

  • 🟥 execution_time [+392.852ns; +453.548ns] or [+2.372%; +2.738%]

scenario:BenchmarkOTelApiWithCustomTags/datadog_otel_api-24

  • 🟥 execution_time [+106.694ns; +141.106ns] or [+2.245%; +2.969%]

scenario:BenchmarkSingleSpanRetention/no-rules-24

  • 🟩 execution_time [-8.425µs; -7.984µs] or [-3.382%; -3.206%]

scenario:BenchmarkSingleSpanRetention/with-rules/match-half-24

  • 🟩 execution_time [-6.103µs; -4.988µs] or [-2.456%; -2.008%]

scenario:BenchmarkStartSpanConcurrent-24

  • 🟩 execution_time [-281.140ns; -130.060ns] or [-4.397%; -2.034%]

@liashenko liashenko changed the title [CI Visibility] Initial internal consts and utilities (#2736) [CI Visibility] CI Visibility integration (#2736) Jul 8, 2024
@liashenko liashenko changed the title [CI Visibility] CI Visibility integration (#2736) [CI Visibility] CI Test Visibility integration (#2736) Jul 8, 2024
@darccio darccio merged commit dc5c6a9 into main Jul 8, 2024
163 of 164 checks passed
@darccio darccio deleted the tony/civisibility-ddtrace branch July 8, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants