Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade macrobenchmarks setup, add CPU / RSS utilization overhead measurements #2763

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

ddyurchenko
Copy link
Collaborator

@ddyurchenko ddyurchenko commented Jun 27, 2024

What does this PR do?

Updates env variables for Go macrobenchmarks, so they match the new setup from BP PR 74.

Motivation

The changes in this PR and linked BP PR 74 together do next:

  1. Enabled RSS and CPU utilization overhead measurements.
  2. Simplified LOAD_TESTS variable.
  3. Separated benchmark runs into normal_operation and high_load phases more cleanly, allowing e.g. to track Linux load averages, system RSS / CPU usage, etc. during normal load and stress load separately.

Also, Go benchmarking dashboard was updated, so new measurements are visible.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@ddyurchenko ddyurchenko requested a review from a team as a code owner June 27, 2024 12:10
@ddyurchenko ddyurchenko changed the title Upgrade macrobenchmarks setup Upgrade macrobenchmarks setup, add CPU / RSS utilization overhead measurements Jun 27, 2024
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2024

Benchmarks

Benchmark execution time: 2024-06-27 12:27:35

Comparing candidate commit fdd8c9e in PR branch ddyurchenko/update-macrobenchmarks with baseline commit 5fcda9f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 0 unstable metrics.

@ddyurchenko ddyurchenko merged commit 27d60de into main Jun 27, 2024
133 checks passed
@ddyurchenko ddyurchenko deleted the ddyurchenko/update-macrobenchmarks branch June 27, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants