Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/hashicorp/go-retryablehttp from 0.7.4 to 0.7.7 #2757

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 24, 2024

Bumps github.com/hashicorp/go-retryablehttp from 0.7.4 to 0.7.7.

Changelog

Sourced from github.com/hashicorp/go-retryablehttp's changelog.

0.7.7 (May 30, 2024)

BUG FIXES:

  • client: avoid potentially leaking URL-embedded basic authentication credentials in logs (#158)

0.7.6 (May 9, 2024)

ENHANCEMENTS:

  • client: support a RetryPrepare function for modifying the request before retrying (#216)
  • client: support HTTP-date values for Retry-After header value (#138)
  • client: avoid reading entire body when the body is a *bytes.Reader (#197)

BUG FIXES:

  • client: fix a broken check for invalid server certificate in go 1.20+ (#210)

0.7.5 (Nov 8, 2023)

BUG FIXES:

  • client: fixes an issue where the request body is not preserved on temporary redirects or re-established HTTP/2 connections (#207)
Commits
  • 1542b31 v0.7.7
  • defb9f4 v0.7.7
  • a99f07b Merge pull request #158 from dany74q/danny/redacted-url-in-logs
  • 8a28c57 Merge branch 'main' into danny/redacted-url-in-logs
  • 86e852d Merge pull request #227 from hashicorp/dependabot/github_actions/actions/chec...
  • 47fe99e Bump actions/checkout from 4.1.5 to 4.1.6
  • 490fc06 Merge pull request #226 from testwill/ioutil
  • f3e9417 chore: remove refs to deprecated io/ioutil
  • d969eaa Merge pull request #225 from hashicorp/manicminer-patch-2
  • 2ad8ed4 v0.7.6
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 24, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 24, 2024

Benchmarks

Benchmark execution time: 2024-07-03 10:59:00

Comparing candidate commit c52aa75 in PR branch dependabot/go_modules/github.com/hashicorp/go-retryablehttp-0.7.7 with baseline commit a7e2f3c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics.

Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.4 to 0.7.7.
- [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md)
- [Commits](hashicorp/go-retryablehttp@v0.7.4...v0.7.7)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-retryablehttp
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/hashicorp/go-retryablehttp-0.7.7 branch from c85a7d0 to 14ae408 Compare June 26, 2024 15:17
@nsrip-dd
Copy link
Contributor

nsrip-dd commented Jul 3, 2024

For the record: I've looked into this and I don't think our library is affected by this. We get this dependency through our hashicorp/vault integration. Our integration only provides a traced HTTP client for use by the Vault client and doesn't call into any of the Vault client APIs that would reach the vulnerable code (see the fix). A user would only possibly be vulnerable if they were already using the Vault client--that is, our library doesn't introduce any new paths to the vulnerable code.

It doesn't seem harmful to do this upgrade, so I'm not opposed to merging this, but FWIW I don't think it's strictly necessary.

@nsrip-dd nsrip-dd enabled auto-merge (squash) July 3, 2024 12:42
@nsrip-dd nsrip-dd merged commit 3a1e562 into main Jul 3, 2024
192 of 196 checks passed
@nsrip-dd nsrip-dd deleted the dependabot/go_modules/github.com/hashicorp/go-retryablehttp-0.7.7 branch July 3, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants