Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: enable APPSEC_RASP system-tests scenario #2754

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Jun 20, 2024

What does this PR do?

This PR enables the APPSEC_RASP system-tests scenario.

Motivation

Better test coverage following #2707

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness changed the title workflows: enable APPSEC_RASP system-testy scenario workflows: enable APPSEC_RASP system-tests scenario Jun 20, 2024
@eliottness eliottness marked this pull request as ready for review June 20, 2024 12:52
@eliottness eliottness requested a review from a team as a code owner June 20, 2024 12:52
@eliottness eliottness enabled auto-merge (squash) June 20, 2024 13:00
@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2024

Benchmarks

Benchmark execution time: 2024-06-20 13:00:47

Comparing candidate commit 43600f7 in PR branch eliott.bouhana/rasp-scenario with baseline commit 618b9bf in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 0 unstable metrics.

@eliottness eliottness force-pushed the eliott.bouhana/rasp-scenario branch from 43600f7 to 78ab42c Compare June 20, 2024 13:31
@eliottness eliottness merged commit 0905a11 into main Jun 20, 2024
162 of 163 checks passed
@eliottness eliottness deleted the eliott.bouhana/rasp-scenario branch June 20, 2024 13:38
eliottness added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants