Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: update sample rate configuration parsing to avoid logging a warning when empty #2751

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

zacharycmontoya
Copy link
Contributor

@zacharycmontoya zacharycmontoya commented Jun 18, 2024

What does this PR do?

This PR adds a small rewrite to the parsing of the DD / OTEL Sample Rate configuration so that we do not log a warning when the sample rate is empty. This also adds a regression test for the scenario.

Motivation

Fixes #2749

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@zacharycmontoya zacharycmontoya requested a review from a team as a code owner June 18, 2024 17:30
@pr-commenter
Copy link

pr-commenter bot commented Jun 18, 2024

Benchmarks

Benchmark execution time: 2024-06-18 17:51:46

Comparing candidate commit d4ff6c5 in PR branch zach.montoya/log-dd-trace-sample-rate with baseline commit 8679af2 in branch main.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in candidate:

  • BenchmarkInjectW3C-24

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

@eliottness eliottness merged commit 618b9bf into main Jun 19, 2024
158 checks passed
@eliottness eliottness deleted the zach.montoya/log-dd-trace-sample-rate branch June 19, 2024 14:45
eliottness pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove warn logs from tracer/option newConfig
3 participants