internal/telemetry: don't send app-dependencies-loaded in the absence of Go deps #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of Go dependencies
BenchmarksBenchmark execution time: 2024-06-12 12:08:16 Comparing candidate commit 07b19ed in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 0 unstable metrics. scenario:BenchmarkHttpServeTrace-24
|
…e of Go dependencies
darccio
reviewed
Jun 12, 2024
| @@ -151,7 +151,6 @@ func TestRegisterAppConfig(t *testing.T) { | |||
| require.Equal(t, RequestTypeAppStarted, req.RequestType) | |||
| appStarted := req.Payload.(*AppStarted) | |||
| cfg := appStarted.Configuration | |||
| require.Len(t, cfg, 2) | |||
There was a problem hiding this comment.
@Julio-Guerra Is this change required?
There was a problem hiding this comment.
yes, because I changed the global config with dependencies_available and DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED reported by default all the times, so I removed the enforcement to 2 and let the following assertions fail anyway if the expected config values are missing.
darccio
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid sending the telemetry request
app-dependencies-loadedwhen there is no Go build info available in the running Go program.Motivation
Datadog's Software Composition Analysis (SCA) relies on program deps, sent over
app-dependencies-loaded, which must not be sent when they are missing.This issue appeared with Bazel which doesn't seem to include Go build info (bazel-contrib/rules_go#3090).
Reviewer's Checklist
Unsure? Have a question? Request a review!