Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/opentelemetry: Fix http remapping to account for int values #2737

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Jun 11, 2024

What does this PR do?

Changes code due to the unforeseen circumstance that otel values for http.response.status_code are int values while Datadog uses http.status_code as a string value

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@zarirhamza zarirhamza marked this pull request as ready for review June 11, 2024 15:23
@zarirhamza zarirhamza requested a review from a team as a code owner June 11, 2024 15:23
@zarirhamza zarirhamza enabled auto-merge (squash) June 11, 2024 15:29
@zarirhamza zarirhamza merged commit 09bdc86 into main Jun 11, 2024
157 of 158 checks passed
@zarirhamza zarirhamza deleted the zarir/http-remapper-fix branch June 11, 2024 15:33
@dianashevchenko dianashevchenko changed the title Fix http remapping to account for int values ddtrace/opentelemetry: Fix http remapping to account for int values Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants