Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/opentelemetry: adds http status code remapping for otel trace metrics #2728

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

zarirhamza
Copy link
Contributor

In order for Otel spans to be compliant with the DD backend, http.response.status_code needs to be remapped to http.status_code for trace metrics compliance.

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Jun 4, 2024

Benchmarks

Benchmark execution time: 2024-06-06 15:38:40

Comparing candidate commit ff415f2 in PR branch zarir/otel-http-remapper-for-trace-metrics with baseline commit 2fb4ed0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

@zarirhamza zarirhamza marked this pull request as ready for review June 6, 2024 15:16
@zarirhamza zarirhamza requested a review from a team as a code owner June 6, 2024 15:16
@zarirhamza zarirhamza merged commit 8d7ce8b into main Jun 6, 2024
158 checks passed
@zarirhamza zarirhamza deleted the zarir/otel-http-remapper-for-trace-metrics branch June 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants