[DSMS-19] Fix SNS topic format issue

[juliannzhou]

What does this PR do?

This PR fixes the SNS topic format issue raised in the support ticket where SNS topics aren't detected as data streams. The customer traced the issue to the nodeHash function where it checks for correctly formatted tags and returned them.

However, in the isWellFormedEdgeTag check, it will return false for any cases where the tag is a topic that is a full arn (such as topic:arn:aws:sns:eu-west-1:474060719897:sre-spec-api-ops-dev-slo-consumers in the customer's case) because the condition check (j == i) will return true only if there is one colon in the edge tag.

The fix will check that 1) there is a colon, 2) the tag is a topic, and that 3) the tag string contains "arn", then return true for this case so that full arn topic tags are not excluded as well-formed tags.

Motivation

See support ticket

Reviewer's Checklist

• Changed code has unit tests for its functionality at or near 100% coverage.
• System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
• There is a benchmark for any new code, or changes to existing code.
• If this interacts with the agent in a new way, a system test has been added.
• Add an appropriate team label so this PR gets put in the right place for the release notes.
• Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-06-04 14:37:50

Comparing candidate commit 1a078aa in PR branch juliann.zhou/fix-sns-topic-format with baseline commit eeaff7c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics.

[roisinlh]

It might be a good idea to check that it is a valid arn (to the extent possible; if there isn't a convenient "is this an arn" function available you could get close by verifying that it matches one of the three general formats):

arn:partition:service:region:account-id:resource-id
arn:partition:service:region:account-id:resource-type/resource-id
arn:partition:service:region:account-id:resource-type:resource-id

All of them begin with "arn:" and contain at least five colons, so checking for those two qualities should avoid most false positives like "carnival" or "arnold".

[juliannzhou]

/merge

[dd-devflow]

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #devflow with those details!

[juliannzhou]

/merge

[dd-devflow]

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #devflow with those details!

[darccio]

@juliannzhou I'll take care of this merge.

[darccio]

@roisinlh Can you review the PR again? Thanks!