Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastreams: Update mapping #2703

Merged
merged 1 commit into from
May 20, 2024
Merged

datastreams: Update mapping #2703

merged 1 commit into from
May 20, 2024

Conversation

piochelepiotr
Copy link
Collaborator

What does this PR do?

Update mapping parameters for ddsketches to match the ones used by the Datadog backend.
This is going to avoid a conversion, which leads to precision loss & is pretty costly.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@piochelepiotr piochelepiotr requested a review from a team as a code owner May 20, 2024 16:25
@pr-commenter
Copy link

pr-commenter bot commented May 20, 2024

Benchmarks

Benchmark execution time: 2024-05-20 16:46:15

Comparing candidate commit acef50c in PR branch piotr-wolski/update-mapping with baseline commit dfa02a3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

@nsrip-dd nsrip-dd merged commit a84d97a into main May 20, 2024
158 checks passed
@nsrip-dd nsrip-dd deleted the piotr-wolski/update-mapping branch May 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants