contrib/jackc/pgx.v5: publish pgxpool stats to statsd client #2692
+163
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtoffl01
requested changes
May 14, 2024
contrib/jackc/pgx.v5/pgxpool.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if tracer.cfg.poolStats { |
There was a problem hiding this comment.
Suggested change
| if tracer.cfg.poolStats { | |
| if tracer.cfg.poolStats && tracer.cfg.statsdClient != nil { |
If we failed to generate a statsd client, we don't want to attempt to submit metrics on it.
See this PR for more context/motivation: #2682
contrib/jackc/pgx.v5/metrics.go
Outdated
| if pool == nil { | ||
| log.Debug("No traced pool connection found; cannot pull pool stats.") | ||
| return | ||
| } |
There was a problem hiding this comment.
We can remove lines 38 - 41 as they essentially duplicate the err != nil check done by the caller, NewPoolWithConfig (Note: We also removed a similar check in the database/sql DB Stats feature in more recent versions , PR)
Co-authored-by: Mikayla Toffler <[email protected]>
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
mtoffl01
approved these changes
Jul 9, 2024
darccio
approved these changes
Jul 10, 2024
|
@rarguelloF @zarirhamza This looks good. Can you review it, please? |
rarguelloF
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2680
What does this PR do?
Adds a new option to contrib/jackc/pgx.v5 to enable polling and submission of pgxpool stats as metrics to Datadog
Ref: https://pkg.go.dev/github.com/jackc/pgx/v5/pgxpool#Stat
Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!