Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: support for SSRF Exploit Prevention #2622

Closed
wants to merge 3 commits into from

Conversation

eliottness
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@eliottness eliottness changed the title wip: support for SSRF Exploit Prevention appsec: support for SSRF Exploit Prevention Mar 18, 2024
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 18, 2024
@eliottness eliottness force-pushed the eliott.bouhana/APPSEC-52185 branch 2 times, most recently from acfc44a to 938ff42 Compare March 25, 2024 10:49
@eliottness eliottness force-pushed the eliott.bouhana/APPSEC-52185 branch from 938ff42 to f36ec4a Compare March 25, 2024 12:33
@pr-commenter
Copy link

pr-commenter bot commented Mar 25, 2024

Benchmarks

Benchmark execution time: 2024-03-25 12:53:14

Comparing candidate commit f36ec4a in PR branch eliott.bouhana/APPSEC-52185 with baseline commit 7bde009 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics.

Copy link
Contributor

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stuck for more than 1 month label Apr 30, 2024
@eliottness eliottness removed the stale Stuck for more than 1 month label Apr 30, 2024
Copy link
Contributor

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stuck for more than 1 month label May 21, 2024
@eliottness eliottness removed the stale Stuck for more than 1 month label May 21, 2024
@eliottness
Copy link
Contributor Author

Superseded by #2707

@eliottness eliottness closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs appsec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant