Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: rotate go 1.19 from supported versions #2617

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Mar 14, 2024

What does this PR do?

As per the go supported version policy. We are rotating go 1.19 from the supported versions in favor of go 1.22.

  • Replace go 1.19 with go 1.20 for job running the oldest supported version
  • Rotate go 1.19 in favor of go 1.22 for jobs running all supported versions via a matrix
  • Modify the README to declare that go 1.19 is now legacy
  • Upgrade go mod version
  • Upgrade benchmarking platform to 1.20 (https://github.com/DataDog/benchmarking-platform/pull/45) and use the new image built by the CI

Fixes #2595

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@eliottness eliottness force-pushed the eliott.bouhana/deprecate-go-119 branch from df14925 to 33c8240 Compare March 14, 2024 11:51
@pr-commenter
Copy link

pr-commenter bot commented Mar 14, 2024

Benchmarks

Benchmark execution time: 2024-03-14 12:21:06

Comparing candidate commit 1f1be38 in PR branch eliott.bouhana/deprecate-go-119 with baseline commit a69e46c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics.

@eliottness eliottness marked this pull request as ready for review March 14, 2024 12:23
@eliottness eliottness requested review from a team as code owners March 14, 2024 12:23
@eliottness eliottness changed the title rotate go 1.19 from supported versions go.mod: rotate go 1.19 from supported versions Mar 14, 2024
@eliottness eliottness force-pushed the eliott.bouhana/deprecate-go-119 branch from 1f1be38 to 0a5d40c Compare March 14, 2024 12:27
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 🙇

@eliottness eliottness merged commit 7bde009 into main Mar 14, 2024
198 of 199 checks passed
@eliottness eliottness deleted the eliott.bouhana/deprecate-go-119 branch March 14, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod: add support for Go v1.22.0
2 participants