Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitlab/macrobenchmarks.yml: fix CI configuration, substitute master for main on execution policy #2301

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

igoragoli
Copy link
Contributor

What does this PR do?

This PR fixes the macrobenchmark CI configuration, enabling macrobenchmarks to be run on commits merged to the main branch, instead of the master branch, as was mistakenly set before.

Related PR: #2285

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@igoragoli igoragoli requested a review from a team as a code owner October 27, 2023 09:29
@pr-commenter
Copy link

pr-commenter bot commented Oct 27, 2023

Benchmarks

Benchmark execution time: 2023-10-31 12:12:45

Comparing candidate commit c4f3a93 in PR branch igoragoli/update-go-macrobenchmark with baseline commit 7f31c76 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics.

@darccio darccio merged commit b3f6536 into main Oct 31, 2023
50 checks passed
@darccio darccio deleted the igoragoli/update-go-macrobenchmark branch October 31, 2023 15:07
@darccio darccio restored the igoragoli/update-go-macrobenchmark branch November 16, 2023 14:28
@darccio darccio deleted the igoragoli/update-go-macrobenchmark branch November 16, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants