tracer: Fix TestMalformedTID so it passes on its own #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test appears to be depending on previous tests because it does
not pass when run on its own:
$ go test ./ddtrace/tracer -run=TestMalformedTID
--- FAIL: TestMalformedTID (0.01s)
textmap_test.go:2079:
Error Trace: /Users/evan.jones/dd/dd-trace-go/ddtrace/tracer/textmap_test.go:2079
Error: Not equal:
expected: "640cfd8d00000000"
actual : ""
Fix the test:
* Call internal.SetGlobalTracer(tracer) which is required for the
test to pass.
* Create assert objects in the sub tests so the correct tests fail.
* Do not set the headerPropagationStyleExtract environment variable.
It does not seem to be required.
Additionally, while fixing this test I noticed similar problems in
TestTracerStartSpanOptions128:
* Create the assert object in each subtest so the correct test fails
* defer internal.SetGlobalTracer(&internal.NoopTracer{}) to ensure
this test does not accidentally affect other tests.
BenchmarksBenchmark execution time: 2023-10-11 17:56:02 Comparing candidate commit 658fdad in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
ajgajg1134
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This test appears to be depending on previous tests because it does not pass when run on its own:
Fix the test:
tto assert functions instead of using a top-level assert object so the sub-tests fail correctly.Additionally, while fixing this test I noticed similar problems in TestTracerStartSpanOptions128:
Motivation
I'm actually tracking down a race detector bug and noticed this test failing while setting up a new test.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!