all: downgrade google.golang.org/protobuf and golang.org/x/exp dependencies #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies A recent change to golang.org/x/exp/slices introduced an incompatibility which affects some of our downstream users. Additionally, upgrading the google.golang.org/protobuf dependency introduces lots of churn from differences in generated protobuf code. Neither dependency upgrade was needed by this library to address issues or use new features. Downgrade these dependencies to what they were prior to #2171.
BenchmarksBenchmark execution time: 2023-09-07 19:55:32 Comparing candidate commit d2af2fa in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
darccio
approved these changes
Sep 8, 2023
Merged
5 tasks
nsrip-dd
added a commit
that referenced
this pull request
Sep 8, 2023
…encies (#2212) A recent change to golang.org/x/exp/slices introduced an incompatibility which affects some of our downstream users. Additionally, upgrading the google.golang.org/protobuf dependency introduces lots of churn from differences in generated protobuf code. Neither dependency upgrade was needed by this library to address issues or use new features. Downgrade these dependencies to what they were prior to #2171.
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Downgrades the golang.org/x/exp and google.golang.org/protobuf dependencies to
what they were prior to #2171.
Motivation
A recent change to golang.org/x/exp/slices introduced an incompatibility which
affects some of our downstream users. Additionally, upgrading the
google.golang.org/protobuf dependency introduces lots of churn from differences
in generated protobuf code. Neither dependency upgrade was needed by this
library to address issues or use new features.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!