go.mod: upgrade datadog-agent/pkg/obfuscate

[felixge]

Fixes #1153

What does this PR do?

go get github.com/DataDog/datadog-agent/pkg/[email protected]
go get github.com/outcaste-io/[email protected]
go mod tidy

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

• If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• Changed code has unit tests for its functionality.
• If this interacts with the agent in a new way, a system test has been added.

[pr-commenter]

Benchmarks

Comparing candidate commit 52f768f in PR branch felix.geisendoerfer/gh-1153 with baseline commit 10e9cce in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

[nsrip-dd]

I know this is marked as a draft, but FWIW I don't think this gets rid of glog. The following program, built against this branch, still gets the glog flags:

package main

import (
	"flag"
	_ "gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
)

func main() {
	flag.PrintDefaults()
}

Output:

$ go run main.go
  -alsologtostderr
    	log to standard error as well as files
  -log_backtrace_at value
    	when logging hits line file:N, emit a stack trace
  -log_dir string
    	If non-empty, write log files in this directory
  -logtostderr
    	log to standard error instead of files
  -stderrthreshold value
    	logs at or above this threshold go to stderr
  -v value
    	log level for V logs
  -vmodule value
    	comma-separated list of pattern=N settings for file-filtered logging

Looks like the obfuscate v0.43.0 module got the wrong version of the ristretto dependency (see this issue). But we can upgrade like so to get the right one:

go get github.com/outcaste-io/[email protected]

If I do that against this branch, the glog flags go away.

[felixge]

I know this is marked as a draft, but FWIW I don't think this gets rid of glog.

Yeah, I hadn't even checked for that yet 😅 . I got distracted by the performance regression that was reported.

But we can upgrade like so to get the right one:

go get github.com/outcaste-io/[email protected]

If I do that against this branch, the glog flags go away.

Thanks. I applied this and updated the patch. It seems to work and also makes the perf regression go away and is now reporting an improvement 🤷‍♂️😄 .

This is ready for review.

[felixge]

Thanks for review Nick.

I'm going to wait for #1798 before landing this because I want to see the profile for the performance improvement reported on this PR.