contrib/{aws/*,net/http}: fix encoding of http.url #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
changed the title
knusbaum
force-pushed
the
knusbaum/url-fix
branch
from
32b5d48 to
b301cef
Compare
This PR ensures auth strings are not present in URLs before attaching them to spans in the `http.url` tag
knusbaum
force-pushed
the
knusbaum/url-fix
branch
from
b301cef to
84c9df9
Compare
knusbaum
changed the title
katiehockman
previously approved these changes
Jan 17, 2023
knusbaum
dismissed stale reviews from katiehockman and ajgajg1134
via
5fe9fd8
katiehockman
approved these changes
Jan 17, 2023
knusbaum
added a commit
that referenced
this pull request
Jan 17, 2023
This PR ensures auth strings are not present in URLs before attaching them to spans in the `http.url` tag
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures auth strings are not present in URLs before attaching them to spans in the
http.urltagDescribe how to test/QA your changes
Create a traced http client and send a request in the form of
http://abc:[email protected]/whateverand ensure that the userinfo part (abc:def) does not appear in thehttp.urltag in the UI.This is likely not possible to test with the AWS integration, however the case has been covered by unit/regression tests.
Reviewer's Checklist
Triagemilestone is set.