Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/appsec/config.go: fix waf timeout configuration #1129

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

Julio-Guerra
Copy link
Contributor

Along with exhaustive config testing to avoid such problems.

@Julio-Guerra Julio-Guerra added this to the 1.36.0 milestone Jan 17, 2022
@Julio-Guerra Julio-Guerra requested a review from Hellzy January 17, 2022 21:53
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner January 17, 2022 21:53
timeout, err := time.ParseDuration(wafTimeout)
if err != nil {
if err == nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason why configuring the waf timeout was broken: this condition was wrong ^^'

internal/appsec/config_test.go Outdated Show resolved Hide resolved
Hellzy
Hellzy previously approved these changes Jan 18, 2022
@Julio-Guerra Julio-Guerra merged commit d6a489c into v1 Jan 18, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/fix-waf-timeout branch January 18, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants