Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update DataDog/datadog-go/v5 to v5.0.2 #1073

Merged
merged 4 commits into from
Dec 16, 2021

Conversation

programmer04
Copy link
Contributor

Version 5.0.2 contains important fix for Windows

@Julio-Guerra Julio-Guerra added this to the 1.35.0 milestone Nov 30, 2021
@knusbaum
Copy link
Contributor

I'll try to get the CI building here...

@knusbaum knusbaum closed this Nov 30, 2021
@knusbaum knusbaum reopened this Nov 30, 2021
@programmer04 programmer04 changed the title go.mod: update DataDog/datadog-go/v5 v5.0.2 go.mod: update DataDog/datadog-go/v5 to v5.0.2 Dec 1, 2021
@Julio-Guerra
Copy link
Contributor

@knusbaum, before merging, should we enforce go mod tidy to remove old go.sum entries?

Julio-Guerra
Julio-Guerra previously approved these changes Dec 2, 2021
@gbbr
Copy link
Contributor

gbbr commented Dec 2, 2021

should we enforce go mod tidy to remove old go.sum entries?

I think that this is already enforced inside the milestone check, unless I'm mistaking.

@programmer04
Copy link
Contributor Author

programmer04 commented Dec 7, 2021

I removed redundant entries in go.sum for this library

@Julio-Guerra Julio-Guerra reopened this Dec 13, 2021
@felixge felixge modified the milestones: 1.35.0, 1.36.0 Dec 14, 2021
@Julio-Guerra
Copy link
Contributor

CI is failing and we are fixing it at the moment :-/
I'll merge this as soon as we're done.

@Julio-Guerra Julio-Guerra modified the milestones: 1.36.0, 1.35.0 Dec 14, 2021
@Julio-Guerra Julio-Guerra merged commit 17f31ae into DataDog:v1 Dec 16, 2021
@programmer04 programmer04 deleted the bump-datadog-go branch December 16, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants