Merge branch 'main' into mtoff/health-metrics-3

DataDog · Dec 23, 2024 · 735a883 · 735a883
2 parents 286ed77 + 3961f7f
commit 735a883
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/ddtrace/tracer/metrics.go b/ddtrace/tracer/metrics.go
@@ -85,7 +85,9 @@ func (t *tracer) reportRuntimeMetrics(interval time.Duration) {
 	}
 }
 
-func (t *tracer) reportHealthMetrics(interval time.Duration) {
+// reportHealthMetricsAtInterval reports noisy health metrics at the specified interval.
+// The periodic reporting ensures metrics are delivered without overwhelming the system or logs.
+func (t *tracer) reportHealthMetricsAtInterval(interval time.Duration) {
 	ticker := time.NewTicker(interval)
 	defer ticker.Stop()
 	for {

diff --git a/ddtrace/tracer/metrics_test.go b/ddtrace/tracer/metrics_test.go
@@ -43,7 +43,7 @@ func TestReportRuntimeMetrics(t *testing.T) {
 	assert.Contains(calls, "runtime.go.gc_stats.pause_quantiles.75p")
 }
 
-func TestReportHealthMetrics(t *testing.T) {
+func TestReportHealthMetricsAtInterval(t *testing.T) {
 	assert := assert.New(t)
 	var tg statsdtest.TestStatsdClient
 

diff --git a/ddtrace/tracer/tracer.go b/ddtrace/tracer/tracer.go
@@ -376,7 +376,7 @@ func newTracer(opts ...StartOption) *tracer {
 	t.wg.Add(1)
 	go func() {
 		defer t.wg.Done()
-		t.reportHealthMetrics(statsInterval)
+		t.reportHealthMetricsAtInterval(statsInterval)
 	}()
 	t.stats.Start()
 	return t