[CI Visibility] Adding nullability checks

[tonyredondo]

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

[datadog-ddstaging]

Datadog Report

Branch report: tony/fix-civisibility-nullables
Commit report: ac7ae72
Test service: dd-trace-dotnet

✅ 0 Failed, 445864 Passed, 2707 Skipped, 18h 20m 44.55s Total Time

[andrewlock]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (6374)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (70ms)  : 67, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (987ms)  : 955, 1019
     .   : milestone, 987,
    master - mean (1,001ms)  : 933, 1069
     .   : milestone, 1001,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (681ms)  : 665, 696
     .   : milestone, 681,
    master - mean (727ms)  : 638, 816
     .   : milestone, 727,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (105ms)  : 97, 113
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (626ms)  : 606, 646
     .   : milestone, 626,
    master - mean (696ms)  : 646, 745
     .   : milestone, 696,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (191ms)  : 185, 197
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (1,099ms)  : 1070, 1128
     .   : milestone, 1099,
    master - mean (1,092ms)  : 1062, 1122
     .   : milestone, 1092,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (868ms)  : 843, 893
     .   : milestone, 868,
    master - mean (869ms)  : 843, 896
     .   : milestone, 869,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (265ms)  : 262, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (848ms)  : 812, 885
     .   : milestone, 848,
    master - mean (850ms)  : 816, 884
     .   : milestone, 850,

Loading

[andrewlock]

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

• This PR (6374)
• master
• benchmarks/2.9.0

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6374) (11.142M)   : 0, 11141957
    master (10.960M)   : 0, 10960167
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6374) (7.286M)   : 0, 7286225
    master (7.146M)   : 0, 7146340
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.574M)   : 0, 7573828

    section Manual
    master (11.107M)   : 0, 11106676

    section Manual + Automatic
    This PR (6374) (6.728M)   : 0, 6728462
    master (6.741M)   : 0, 6741226

    section DD_TRACE_ENABLED=0
    master (10.165M)   : 0, 10165491

Loading

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6374) (9.496M)   : 0, 9495901
    master (9.560M)   : 0, 9560330
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6374) (6.412M)   : 0, 6411769
    master (6.454M)   : 0, 6453524

    section Trace stats
    master (6.474M)   : 0, 6474457

    section Manual
    master (9.639M)   : 0, 9638568

    section Manual + Automatic
    This PR (6374) (5.935M)   : 0, 5935259
    master (5.823M)   : 0, 5823392

    section DD_TRACE_ENABLED=0
    master (9.062M)   : 0, 9062234

Loading

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6374) (9.764M)   : 0, 9763904
    master (10.205M)   : 0, 10204663
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6374) (6.053M)   : crit ,0, 6052589
    master (6.742M)   : 0, 6741874
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.283M)   : 0, 7283350

    section Manual
    master (10.217M)   : 0, 10216800

    section Manual + Automatic
    This PR (6374) (5.879M)   : crit ,0, 5879024
    master (6.205M)   : 0, 6205289

    section DD_TRACE_ENABLED=0
    master (9.655M)   : 0, 9654806

Loading