Update `dotnet test` tests to take memory dump on hang #6343

andrewlock · 2024-11-25T11:30:17Z

Summary of changes

Updates StartDotnetTestSample to use the existing WaitForProcessResult that takes a memory dump

Reason for change

We've seen some of the CI Vis tests failing recently with hangs. Hopefully this well help diagnose the issue

Implementation details

Use the existing WaitForProcessResult - it's mostly the same code anyway and takes a memory dump if the process hasn't exited, and kills it, instead of waiting forever.

Test coverage

If the tests pass, that's good enough for now

datadog-ddstaging · 2024-11-25T11:58:58Z

Datadog Report

Branch report: andre/ci/take-memory-dump-dotnet-test
Commit report: f8e3b67
Test service: dd-trace-dotnet

✅ 0 Failed, 451199 Passed, 2725 Skipped, 20h 0m 57.89s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyResolveMscorlibResourcesInfiniteRecursionCrashSmokeTest - Last Failure

Expand for error

 Expected no errors in smoke test: [createdump] open(/proc/4073/mem) FAILED 2 (No such file or directory)
 [createdump] Target process terminated
 
 Expected: True
 Actual:   False

SeparatesLogsIntoBatches - Datadog.Trace.Tests.Telemetry.Collectors.RedactedErrorLogCollectorTests - Last Failure
Expand for error
```
 Expected logs.Sum(x => x.Count) to be 556, but found 548 (difference of -8).
```

andrewlock · 2024-11-25T12:03:41Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6343) - mean (70ms)  : 66, 73
     .   : milestone, 70,
    master - mean (69ms)  : 65, 74
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6343) - mean (983ms)  : 959, 1007
     .   : milestone, 983,
    master - mean (976ms)  : 953, 999
     .   : milestone, 976,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6343) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6343) - mean (682ms)  : 666, 698
     .   : milestone, 682,
    master - mean (678ms)  : 659, 697
     .   : milestone, 678,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6343) - mean (92ms)  : 91, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6343) - mean (629ms)  : 616, 641
     .   : milestone, 629,
    master - mean (633ms)  : 614, 651
     .   : milestone, 633,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6343) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6343) - mean (1,090ms)  : 1062, 1117
     .   : milestone, 1090,
    master - mean (1,092ms)  : 1068, 1116
     .   : milestone, 1092,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6343) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6343) - mean (871ms)  : 837, 905
     .   : milestone, 871,
    master - mean (870ms)  : 835, 905
     .   : milestone, 870,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6343) - mean (266ms)  : 263, 269
     .   : milestone, 266,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6343) - mean (848ms)  : 820, 877
     .   : milestone, 848,
    master - mean (850ms)  : 811, 888
     .   : milestone, 850,

andrewlock · 2024-11-25T14:21:48Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6343) (11.180M)   : 0, 11179976
    master (10.997M)   : 0, 10996550
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6343) (7.325M)   : 0, 7325085
    master (7.185M)   : 0, 7184511
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.538M)   : 0, 7538247

    section Manual
    master (11.069M)   : 0, 11069430

    section Manual + Automatic
    This PR (6343) (6.781M)   : 0, 6781346
    master (6.738M)   : 0, 6737616

    section DD_TRACE_ENABLED=0
    master (10.302M)   : 0, 10301778

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6343) (9.433M)   : 0, 9432934
    master (9.415M)   : 0, 9414535
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6343) (6.377M)   : 0, 6377106
    master (6.358M)   : 0, 6358468

    section Trace stats
    master (6.815M)   : 0, 6815014

    section Manual
    master (9.493M)   : 0, 9493123

    section Manual + Automatic
    This PR (6343) (5.930M)   : 0, 5929820
    master (5.926M)   : 0, 5926110

    section DD_TRACE_ENABLED=0
    master (8.735M)   : 0, 8735109

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6343) (10.089M)   : 0, 10088878
    master (10.430M)   : 0, 10430317
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6343) (6.772M)   : 0, 6771947
    master (6.844M)   : 0, 6843537
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.470M)   : 0, 7470195

    section Manual
    master (10.484M)   : 0, 10483521

    section Manual + Automatic
    This PR (6343) (6.234M)   : 0, 6234264
    master (6.451M)   : 0, 6451333

    section DD_TRACE_ENABLED=0
    master (9.895M)   : 0, 9894875

tracer/test/Datadog.Trace.TestHelpers.AutoInstrumentation/TestHelper.cs

…Helper.cs

andrewlock · 2024-11-25T19:13:15Z

Benchmarks Report for tracer 🐌

Benchmarks for #6343 compared to master:

3 benchmarks are slower, with geometric mean 1.128
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.12μs	45.7ns	320ns	0.017	0.00848	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	56.3ns	338ns	0.0206	0.0103	0	5.8 KB
master	`StartStopWithChild`	net472	16.5μs	72.6ns	281ns	1.04	0.306	0.0909	6.21 KB
#6343	`StartStopWithChild`	net6.0	8.02μs	45.5ns	305ns	0.0161	0.00804	0	5.61 KB
#6343	`StartStopWithChild`	netcoreapp3.1	9.78μs	53.3ns	306ns	0.0253	0.0101	0	5.8 KB
#6343	`StartStopWithChild`	net472	16.5μs	37.8ns	146ns	1.03	0.285	0.0977	6.22 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	508μs	183ns	708ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	433ns	1.68μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	858μs	422ns	1.58μs	0.428	3.3 KB
#6343	`WriteAndFlushEnrichedTraces`	net6.0	486μs	286ns	1.03μs	0	2.7 KB
#6343	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	640μs	384ns	1.44μs	0	2.7 KB
#6343	`WriteAndFlushEnrichedTraces`	net472	837μs	799ns	3.1μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	151μs	816ns	7.11μs	0.141	14.47 KB
master	`SendRequest`	netcoreapp3.1	162μs	912ns	6.38μs	0.159	17.27 KB
master	`SendRequest`	net472	0.00151ns	0.000677ns	0.00262ns	0	0 b
#6343	`SendRequest`	net6.0	150μs	794ns	4.42μs	0.16	14.47 KB
#6343	`SendRequest`	netcoreapp3.1	168μs	1.04μs	10.1μs	0.164	17.27 KB
#6343	`SendRequest`	net472	0ns	0ns	0ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	608μs	4.78μs	45.8μs	0.556	0	0	41.76 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	678μs	2.28μs	7.91μs	0.347	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	net472	861μs	3.66μs	13.7μs	8.45	2.53	0.422	53.35 KB
#6343	`WriteAndFlushEnrichedTraces`	net6.0	594μs	2.9μs	17.4μs	0.563	0	0	41.65 KB
#6343	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	708μs	4.03μs	29.6μs	0.34	0	0	41.66 KB
#6343	`WriteAndFlushEnrichedTraces`	net472	918μs	2.7μs	10.1μs	8.8	2.31	0.463	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.29μs	1.22ns	4.72ns	0.0144	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	2.85ns	11ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.13μs	2.31ns	8.64ns	0.157	0.00106	987 B
#6343	`ExecuteNonQuery`	net6.0	1.26μs	1.45ns	5.43ns	0.0146	0	1.02 KB
#6343	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.73ns	6.69ns	0.0131	0	1.02 KB
#6343	`ExecuteNonQuery`	net472	2.09μs	2.07ns	8.01ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.2μs	0.713ns	2.76ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.522ns	1.88ns	0.0131	976 B
master	`CallElasticsearch`	net472	2.66μs	2.37ns	9.17ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.321ns	1.24ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	1.43ns	5.55ns	0.0134	1.02 KB
master	`CallElasticsearchAsync`	net472	2.62μs	1.21ns	4.68ns	0.166	1.05 KB
#6343	`CallElasticsearch`	net6.0	1.26μs	3.21ns	12.4ns	0.0137	976 B
#6343	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.651ns	2.35ns	0.0129	976 B
#6343	`CallElasticsearch`	net472	2.54μs	2.32ns	8.68ns	0.158	995 B
#6343	`CallElasticsearchAsync`	net6.0	1.23μs	1.54ns	7.2ns	0.0133	952 B
#6343	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	2.77ns	10.4ns	0.0132	1.02 KB
#6343	`CallElasticsearchAsync`	net472	2.58μs	1.66ns	6.43ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6343

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.130	1,191.82	1,346.21

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.19μs	0.582ns	2.18ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.59μs	1.3ns	4.85ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.81μs	0.76ns	2.94ns	0.145	915 B
#6343	`ExecuteAsync`	net6.0	1.35μs	0.925ns	3.46ns	0.0135	952 B
#6343	`ExecuteAsync`	netcoreapp3.1	1.71μs	1.67ns	6.24ns	0.0127	952 B
#6343	`ExecuteAsync`	net472	1.8μs	1.21ns	4.69ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.45μs	1.5ns	5.8ns	0.0311	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.18μs	2.63ns	10.2ns	0.0389	2.85 KB
master	`SendAsync`	net472	7.16μs	1.74ns	6.72ns	0.494	3.12 KB
#6343	`SendAsync`	net6.0	4.29μs	1.89ns	7.09ns	0.0322	2.31 KB
#6343	`SendAsync`	netcoreapp3.1	5.33μs	3.2ns	12.4ns	0.0371	2.85 KB
#6343	`SendAsync`	net472	7.41μs	4.09ns	14.2ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	1.41ns	5.27ns	0.0226	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.3μs	1.52ns	5.68ns	0.0218	1.64 KB
master	`EnrichedLog`	net472	2.62μs	1.04ns	4.01ns	0.249	1.57 KB
#6343	`EnrichedLog`	net6.0	1.45μs	0.81ns	3.03ns	0.0234	1.64 KB
#6343	`EnrichedLog`	netcoreapp3.1	2.25μs	1.08ns	4.19ns	0.0225	1.64 KB
#6343	`EnrichedLog`	net472	2.67μs	4.91ns	19ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	235ns	911ns	0.061	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	145ns	560ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	138ns	534ns	0.684	0.228	4.46 KB
#6343	`EnrichedLog`	net6.0	120μs	122ns	457ns	0	0	4.28 KB
#6343	`EnrichedLog`	netcoreapp3.1	124μs	167ns	646ns	0	0	4.28 KB
#6343	`EnrichedLog`	net472	151μs	187ns	723ns	0.682	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.19ns	4.59ns	0.0303	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.04μs	1.3ns	4.86ns	0.0303	2.2 KB
master	`EnrichedLog`	net472	4.89μs	1.19ns	4.44ns	0.321	2.02 KB
#6343	`EnrichedLog`	net6.0	3.23μs	1.57ns	6.08ns	0.0302	2.2 KB
#6343	`EnrichedLog`	netcoreapp3.1	4.16μs	2.65ns	10.3ns	0.0291	2.2 KB
#6343	`EnrichedLog`	net472	4.86μs	2.5ns	9.67ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.33μs	0.984ns	3.81ns	0.0159	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.76μs	1.08ns	4.19ns	0.0152	1.14 KB
master	`SendReceive`	net472	2.1μs	1.01ns	3.78ns	0.183	1.16 KB
#6343	`SendReceive`	net6.0	1.38μs	1.13ns	4.36ns	0.0164	1.14 KB
#6343	`SendReceive`	netcoreapp3.1	1.76μs	0.834ns	3.12ns	0.015	1.14 KB
#6343	`SendReceive`	net472	2.06μs	2.48ns	9.6ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.66μs	0.937ns	3.51ns	0.0215	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.98μs	2.76ns	10.7ns	0.0219	1.65 KB
master	`EnrichedLog`	net472	4.55μs	2.45ns	9.51ns	0.323	2.04 KB
#6343	`EnrichedLog`	net6.0	2.72μs	0.921ns	3.44ns	0.0218	1.6 KB
#6343	`EnrichedLog`	netcoreapp3.1	3.82μs	3.16ns	12.2ns	0.0208	1.65 KB
#6343	`EnrichedLog`	net472	4.35μs	2.66ns	9.94ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6343

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.128	483.73	545.77

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	405ns	0.288ns	1.11ns	0.00814	576 B
master	`StartFinishSpan`	netcoreapp3.1	656ns	0.217ns	0.813ns	0.00764	576 B
master	`StartFinishSpan`	net472	639ns	0.675ns	2.62ns	0.0916	578 B
master	`StartFinishScope`	net6.0	484ns	0.247ns	0.925ns	0.00971	696 B
master	`StartFinishScope`	netcoreapp3.1	758ns	0.341ns	1.28ns	0.00944	696 B
master	`StartFinishScope`	net472	895ns	0.456ns	1.77ns	0.104	658 B
#6343	`StartFinishSpan`	net6.0	418ns	0.331ns	1.28ns	0.00805	576 B
#6343	`StartFinishSpan`	netcoreapp3.1	599ns	0.701ns	2.53ns	0.00778	576 B
#6343	`StartFinishSpan`	net472	709ns	0.377ns	1.46ns	0.0918	578 B
#6343	`StartFinishScope`	net6.0	546ns	0.783ns	3.03ns	0.00983	696 B
#6343	`StartFinishScope`	netcoreapp3.1	681ns	0.61ns	2.36ns	0.00918	696 B
#6343	`StartFinishScope`	net472	844ns	0.399ns	1.55ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6343

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	1.127	1,047.84	1,181.16

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	646ns	0.517ns	1.93ns	0.00975	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1μs	0.992ns	3.84ns	0.00904	696 B
master	`RunOnMethodBegin`	net472	1.05μs	0.503ns	1.95ns	0.104	658 B
#6343	`RunOnMethodBegin`	net6.0	673ns	0.565ns	2.11ns	0.00969	696 B
#6343	`RunOnMethodBegin`	netcoreapp3.1	993ns	0.626ns	2.42ns	0.0094	696 B
#6343	`RunOnMethodBegin`	net472	1.18μs	0.449ns	1.74ns	0.104	658 B

Update dotnet test to take memory dump on hang

0a16282

andrewlock added the area:tests unit tests, integration tests label Nov 25, 2024

andrewlock requested a review from tonyredondo November 25, 2024 11:30

andrewlock requested a review from a team as a code owner November 25, 2024 11:30

tonyredondo approved these changes Nov 25, 2024

View reviewed changes

andrewlock commented Nov 25, 2024

View reviewed changes

tracer/test/Datadog.Trace.TestHelpers.AutoInstrumentation/TestHelper.cs Outdated Show resolved Hide resolved

Update tracer/test/Datadog.Trace.TestHelpers.AutoInstrumentation/Test…

b242f3f

…Helper.cs

default to expecting 0

74f76da

andrewlock requested review from a team as code owners November 26, 2024 13:33

kevingosse approved these changes Nov 27, 2024

View reviewed changes

grmbl early flake detection

f8e3b67

andrewlock merged commit 2ff91cf into master Nov 28, 2024
77 checks passed

andrewlock deleted the andre/ci/take-memory-dump-dotnet-test branch November 28, 2024 11:37

github-actions bot added this to the vNext-v3 milestone Nov 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `dotnet test` tests to take memory dump on hang #6343

Update `dotnet test` tests to take memory dump on hang #6343

andrewlock commented Nov 25, 2024

datadog-ddstaging bot commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6343

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6343

Raw results

Slower ⚠️ in #6343

Raw results

Update dotnet test tests to take memory dump on hang #6343

Update dotnet test tests to take memory dump on hang #6343

Conversation

andrewlock commented Nov 25, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

datadog-ddstaging bot commented Nov 25, 2024 • edited Loading

Datadog Report

New Flaky Tests (2)

andrewlock commented Nov 25, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 25, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Nov 25, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6343

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6343

Raw results

Slower ⚠️ in #6343

Raw results

Update `dotnet test` tests to take memory dump on hang #6343

Update `dotnet test` tests to take memory dump on hang #6343

datadog-ddstaging bot commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading