[CI Visibility] Fix GitCommandParser test

[tonyredondo]

Summary of changes

The PR fixes the GitCommand Parser test

Reason for change

The test is failing on some platforms because we work with a detached Head, and that makes the Branch to be null.

Implementation details

Removes the branch assertion.

Other details

[andrewlock]

Thanks!

[datadog-ddstaging]

Datadog Report

Branch report: tony/fix-civisibility-test
Commit report: b1a8992
Test service: dd-trace-dotnet

✅ 0 Failed, 450849 Passed, 2740 Skipped, 19h 34m 21.68s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

• Serialization_ServiceEntrySpan - Datadog.Trace.Tests.Tagging.TagsListTests - Last Failure

  Expand for error

   Expected deserializedSpan.Tags.Count to be 21, but found 31 (difference of 10).
  

[andrewlock]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (6289)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6289) - mean (72ms)  : 63, 80
     .   : milestone, 72,
    master - mean (71ms)  : 65, 77
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6289) - mean (1,110ms)  : 1090, 1131
     .   : milestone, 1110,
    master - mean (1,106ms)  : 1082, 1131
     .   : milestone, 1106,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6289) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6289) - mean (771ms)  : 757, 784
     .   : milestone, 771,
    master - mean (773ms)  : 759, 788
     .   : milestone, 773,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6289) - mean (92ms)  : 91, 94
     .   : milestone, 92,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6289) - mean (727ms)  : 710, 744
     .   : milestone, 727,
    master - mean (728ms)  : 710, 746
     .   : milestone, 728,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6289) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6289) - mean (1,210ms)  : 1189, 1232
     .   : milestone, 1210,
    master - mean (1,227ms)  : 1201, 1254
     .   : milestone, 1227,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6289) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (276ms)  : 270, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6289) - mean (946ms)  : 927, 966
     .   : milestone, 946,
    master - mean (945ms)  : 919, 971
     .   : milestone, 945,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6289) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (265ms)  : 260, 271
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6289) - mean (933ms)  : 914, 953
     .   : milestone, 933,
    master - mean (929ms)  : 914, 945
     .   : milestone, 929,

Loading

[andrewlock]

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

• This PR (6289)
• master
• benchmarks/2.9.0

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6289) (11.097M)   : 0, 11097297
    master (11.248M)   : 0, 11247687
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6289) (7.127M)   : 0, 7127091
    master (7.236M)   : 0, 7235877
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.529M)   : 0, 7529290

    section Manual
    master (11.094M)   : 0, 11093560

    section Manual + Automatic
    This PR (6289) (6.536M)   : 0, 6536426
    master (6.699M)   : 0, 6698725

    section DD_TRACE_ENABLED=0
    master (10.232M)   : 0, 10231991

Loading

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6289) (9.709M)   : 0, 9709325
    master (9.599M)   : 0, 9599416
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6289) (6.299M)   : 0, 6298948
    master (6.401M)   : 0, 6400631

    section Trace stats
    master (6.833M)   : 0, 6832952

    section Manual
    master (9.648M)   : 0, 9648079

    section Manual + Automatic
    This PR (6289) (6.026M)   : 0, 6025502
    master (6.042M)   : 0, 6041665

    section DD_TRACE_ENABLED=0
    master (8.938M)   : 0, 8938482

Loading

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6289) (9.957M)   : 0, 9956574
    master (9.703M)   : 0, 9703135
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6289) (6.351M)   : 0, 6350592
    master (6.287M)   : 0, 6286829
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.870M)   : 0, 6869636

    section Manual
    master (9.395M)   : 0, 9394829

    section Manual + Automatic
    This PR (6289) (5.869M)   : 0, 5868950
    master (5.848M)   : 0, 5848196

    section DD_TRACE_ENABLED=0
    master (8.825M)   : 0, 8824661

Loading