-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix R2R build for OSX-ARM64 #6264
Conversation
...applications/integrations/Samples.ManualInstrumentation/Samples.ManualInstrumentation.csproj
Outdated
Show resolved
Hide resolved
tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/ManualInstrumentationTests.cs
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 376684 Passed, 2086 Skipped, 14h 37m 44.21s Total Time |
…nstrumentationTests.cs Co-authored-by: Andrew Lock <[email protected]>
4f45403
to
3455370
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6264) - mean (70ms) : 67, 72
. : milestone, 70,
master - mean (70ms) : 68, 72
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6264) - mean (1,110ms) : 1093, 1127
. : milestone, 1110,
master - mean (1,109ms) : 1089, 1130
. : milestone, 1109,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6264) - mean (108ms) : 106, 110
. : milestone, 108,
master - mean (108ms) : 106, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6264) - mean (777ms) : 762, 793
. : milestone, 777,
master - mean (774ms) : 761, 787
. : milestone, 774,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6264) - mean (92ms) : 89, 95
. : milestone, 92,
master - mean (92ms) : 89, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6264) - mean (730ms) : 712, 749
. : milestone, 730,
master - mean (731ms) : 714, 749
. : milestone, 731,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6264) - mean (191ms) : 188, 194
. : milestone, 191,
master - mean (190ms) : 187, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6264) - mean (1,224ms) : 1205, 1243
. : milestone, 1224,
master - mean (1,221ms) : 1196, 1245
. : milestone, 1221,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6264) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6264) - mean (947ms) : 930, 964
. : milestone, 947,
master - mean (949ms) : 929, 970
. : milestone, 949,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6264) - mean (264ms) : 261, 268
. : milestone, 264,
master - mean (264ms) : 261, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (6264) - mean (933ms) : 920, 946
. : milestone, 933,
master - mean (937ms) : 912, 962
. : milestone, 937,
|
Summary of changes
Fix R2R build for OSX-ARM64
Reason for change
Currently if we try to build
Samples.ManualInstrumentation
project with R2R on osx-arm64 it will fail.Other details