-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make snapshot tests compatible with running on Docker v2 #6260
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 369266 Passed, 2080 Skipped, 15h 5m 39.78s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6260) - mean (69ms) : 67, 71
. : milestone, 69,
master - mean (70ms) : 68, 71
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6260) - mean (1,110ms) : 1091, 1129
. : milestone, 1110,
master - mean (1,111ms) : 1093, 1129
. : milestone, 1111,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6260) - mean (108ms) : 105, 110
. : milestone, 108,
master - mean (108ms) : 105, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6260) - mean (768ms) : 753, 782
. : milestone, 768,
master - mean (770ms) : 753, 788
. : milestone, 770,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6260) - mean (92ms) : 90, 93
. : milestone, 92,
master - mean (92ms) : 90, 93
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6260) - mean (727ms) : 708, 745
. : milestone, 727,
master - mean (727ms) : 716, 739
. : milestone, 727,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6260) - mean (190ms) : 187, 193
. : milestone, 190,
master - mean (191ms) : 188, 194
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6260) - mean (1,222ms) : 1195, 1250
. : milestone, 1222,
master - mean (1,222ms) : 1198, 1246
. : milestone, 1222,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6260) - mean (276ms) : 271, 281
. : milestone, 276,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6260) - mean (946ms) : 930, 963
. : milestone, 946,
master - mean (951ms) : 937, 964
. : milestone, 951,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6260) - mean (267ms) : 262, 273
. : milestone, 267,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6260) - mean (974ms) : 882, 1066
. : milestone, 974,
master - mean (936ms) : 915, 957
. : milestone, 936,
|
Benchmarks Report for tracer 🐌Benchmarks for #6260 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 | 1.144 | 1,374.66 | 1,201.62 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.37μs | 1.93ns | 7.48ns | 0.0136 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.51μs | 0.541ns | 1.95ns | 0.0129 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.51μs | 1.83ns | 7.11ns | 0.157 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.44μs | 0.643ns | 2.49ns | 0.0131 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.65μs | 0.695ns | 2.6ns | 0.0137 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.54μs | 0.708ns | 2.74ns | 0.167 | 0 | 0 | 1.05 KB |
#6260 | CallElasticsearch |
net6.0 | 1.21μs | 2.82ns | 10.9ns | 0.0138 | 0 | 0 | 976 B |
#6260 | CallElasticsearch |
netcoreapp3.1 | 1.54μs | 1ns | 3.48ns | 0.013 | 0 | 0 | 976 B |
#6260 | CallElasticsearch |
net472 | 2.47μs | 1.4ns | 5.44ns | 0.158 | 0 | 0 | 995 B |
#6260 | CallElasticsearchAsync |
net6.0 | 1.32μs | 1.02ns | 3.94ns | 0.0131 | 0 | 0 | 952 B |
#6260 | CallElasticsearchAsync |
netcoreapp3.1 | 1.61μs | 1.42ns | 5.5ns | 0.0137 | 0 | 0 | 1.02 KB |
#6260 | CallElasticsearchAsync |
net472 | 2.63μs | 1.28ns | 4.94ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.13μs | 0.481ns | 1.86ns | 0.0131 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.67μs | 0.376ns | 1.3ns | 0.0124 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.79μs | 1.6ns | 5.54ns | 0.145 | 0 | 0 | 915 B |
#6260 | ExecuteAsync |
net6.0 | 1.15μs | 0.624ns | 2.42ns | 0.0132 | 0 | 0 | 952 B |
#6260 | ExecuteAsync |
netcoreapp3.1 | 1.61μs | 0.545ns | 2.04ns | 0.0129 | 0 | 0 | 952 B |
#6260 | ExecuteAsync |
net472 | 1.84μs | 0.956ns | 3.7ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.41μs | 2.68ns | 10ns | 0.0329 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.27μs | 1.8ns | 6.74ns | 0.037 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.42μs | 3.7ns | 13.8ns | 0.493 | 0 | 0 | 3.12 KB |
#6260 | SendAsync |
net6.0 | 4.34μs | 1.67ns | 6.02ns | 0.0326 | 0 | 0 | 2.31 KB |
#6260 | SendAsync |
netcoreapp3.1 | 5.3μs | 2.38ns | 9.22ns | 0.0396 | 0 | 0 | 2.85 KB |
#6260 | SendAsync |
net472 | 7.36μs | 1.64ns | 6.13ns | 0.493 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.59μs | 5.07ns | 19.6ns | 0.0233 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.14μs | 1.24ns | 4.81ns | 0.0224 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.48μs | 1.68ns | 6.51ns | 0.25 | 0 | 0 | 1.57 KB |
#6260 | EnrichedLog |
net6.0 | 1.51μs | 1.36ns | 5.08ns | 0.0235 | 0 | 0 | 1.64 KB |
#6260 | EnrichedLog |
netcoreapp3.1 | 2.24μs | 1.7ns | 6.14ns | 0.0215 | 0 | 0 | 1.64 KB |
#6260 | EnrichedLog |
net472 | 2.61μs | 1.1ns | 4.25ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 120μs | 174ns | 675ns | 0.0601 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 120μs | 191ns | 741ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 151μs | 210ns | 787ns | 0.678 | 0.226 | 0 | 4.46 KB |
#6260 | EnrichedLog |
net6.0 | 119μs | 110ns | 412ns | 0.0598 | 0 | 0 | 4.28 KB |
#6260 | EnrichedLog |
netcoreapp3.1 | 121μs | 198ns | 765ns | 0 | 0 | 0 | 4.28 KB |
#6260 | EnrichedLog |
net472 | 154μs | 151ns | 584ns | 0.689 | 0.23 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.16μs | 0.709ns | 2.75ns | 0.0316 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.13μs | 0.543ns | 1.96ns | 0.0308 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.94μs | 1.55ns | 5.99ns | 0.319 | 0 | 0 | 2.02 KB |
#6260 | EnrichedLog |
net6.0 | 2.96μs | 1.45ns | 5.61ns | 0.0298 | 0 | 0 | 2.2 KB |
#6260 | EnrichedLog |
netcoreapp3.1 | 4.08μs | 1.08ns | 3.9ns | 0.0306 | 0 | 0 | 2.2 KB |
#6260 | EnrichedLog |
net472 | 4.92μs | 1.74ns | 6.51ns | 0.319 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.33μs | 0.356ns | 1.33ns | 0.0159 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.72μs | 0.584ns | 2.11ns | 0.0146 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.05μs | 0.847ns | 3.06ns | 0.184 | 0 | 0 | 1.16 KB |
#6260 | SendReceive |
net6.0 | 1.4μs | 0.687ns | 2.57ns | 0.0162 | 0 | 0 | 1.14 KB |
#6260 | SendReceive |
netcoreapp3.1 | 1.79μs | 2.26ns | 8.74ns | 0.015 | 0 | 0 | 1.14 KB |
#6260 | SendReceive |
net472 | 2.11μs | 1.1ns | 4.13ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.74μs | 1.15ns | 4.46ns | 0.0218 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.94μs | 2.75ns | 10.3ns | 0.0217 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.46μs | 2.48ns | 9.27ns | 0.322 | 0 | 0 | 2.04 KB |
#6260 | EnrichedLog |
net6.0 | 2.78μs | 0.835ns | 3.13ns | 0.0222 | 0 | 0 | 1.6 KB |
#6260 | EnrichedLog |
netcoreapp3.1 | 3.92μs | 2.38ns | 8.89ns | 0.0216 | 0 | 0 | 1.65 KB |
#6260 | EnrichedLog |
net472 | 4.41μs | 1.24ns | 4.65ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6260
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0
1.194
473.26
396.47
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.194 | 473.26 | 396.47 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 473ns | 0.421ns | 1.57ns | 0.0081 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 664ns | 2.41ns | 9.32ns | 0.0075 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 720ns | 0.797ns | 3.09ns | 0.0915 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 522ns | 0.457ns | 1.77ns | 0.00978 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 765ns | 0.641ns | 2.48ns | 0.00916 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 906ns | 0.849ns | 3.29ns | 0.104 | 0 | 0 | 658 B |
#6260 | StartFinishSpan |
net6.0 | 397ns | 0.155ns | 0.579ns | 0.00802 | 0 | 0 | 576 B |
#6260 | StartFinishSpan |
netcoreapp3.1 | 620ns | 0.944ns | 3.66ns | 0.00765 | 0 | 0 | 576 B |
#6260 | StartFinishSpan |
net472 | 749ns | 0.325ns | 1.22ns | 0.0915 | 0 | 0 | 578 B |
#6260 | StartFinishScope |
net6.0 | 538ns | 0.214ns | 0.827ns | 0.00973 | 0 | 0 | 696 B |
#6260 | StartFinishScope |
netcoreapp3.1 | 707ns | 0.881ns | 3.29ns | 0.00919 | 0 | 0 | 696 B |
#6260 | StartFinishScope |
net472 | 885ns | 0.471ns | 1.82ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6260
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.151
730.85
634.71
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.151 | 730.85 | 634.71 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 731ns | 0.424ns | 1.59ns | 0.00951 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 977ns | 1.19ns | 4.59ns | 0.00928 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.15μs | 1.61ns | 6.23ns | 0.104 | 0 | 0 | 658 B |
#6260 | RunOnMethodBegin |
net6.0 | 635ns | 0.248ns | 0.959ns | 0.00978 | 0 | 0 | 696 B |
#6260 | RunOnMethodBegin |
netcoreapp3.1 | 953ns | 0.476ns | 1.85ns | 0.00916 | 0 | 0 | 696 B |
#6260 | RunOnMethodBegin |
net472 | 1.16μs | 0.279ns | 1.08ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6260) (10.938M) : 0, 10938420
master (11.092M) : 0, 11092190
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6260) (7.253M) : 0, 7253444
master (7.315M) : 0, 7314582
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.630M) : 0, 7629946
section Manual
master (11.027M) : 0, 11026584
section Manual + Automatic
This PR (6260) (6.746M) : 0, 6745672
master (6.813M) : 0, 6813328
section DD_TRACE_ENABLED=0
master (10.150M) : 0, 10150076
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6260) (9.626M) : 0, 9626176
master (9.560M) : 0, 9559953
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6260) (6.531M) : 0, 6530888
master (6.378M) : 0, 6377870
section Trace stats
master (6.751M) : 0, 6751094
section Manual
master (9.498M) : 0, 9497984
section Manual + Automatic
This PR (6260) (6.000M) : 0, 5999817
master (5.967M) : 0, 5966547
section DD_TRACE_ENABLED=0
master (8.995M) : 0, 8994981
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6260) (8.348M) : 0, 8348084
master (10.347M) : 0, 10347441
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6260) (6.607M) : 0, 6607003
master (6.779M) : 0, 6779281
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.590M) : 0, 7590179
section Manual
master (10.414M) : 0, 10413511
section Manual + Automatic
This PR (6260) (6.196M) : 0, 6196264
master (5.506M) : 0, 5506075
section DD_TRACE_ENABLED=0
master (9.537M) : 0, 9537294
|
Summary of changes
Makes the snapshot tests (and build) compatible with docker compose v2
Reason for change
We're still using docker compose v1 in the snapshot tests currently, but the latest .NET 9 images using noble will crash when running on these. This is a preparatory step for updating to docker compose v2
Implementation details
_
with-
in the docker-compose project names (_
isn't valid)network.client.ip
andhttp.client_ip
in the snapshotsTest coverage
This is the test