Convert WebRequestTests to snapshot tests #6223

andrewlock · 2024-10-30T15:42:42Z

Summary of changes

Converts the WebRequestTests to use snapshot tests instead of adhoc assertions

Reason for change

While working on something else (.NET 9) these tests were failing, but it was really hard to understand why - snapshots make that easy.

Implementation details

Ran locally with .NET FX, .NET 8, and .NET Core 2.1, and checked for differences

Test coverage

Coverage is the same - I'll also do an "all TFMs" run to make sure nothing will break post-merge

andrewlock · 2024-10-30T15:43:18Z

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/WebRequestTests.cs

+                                   spans =>
+                                       spans.OrderBy(x => VerifyHelper.GetRootSpanResourceName(x, spans))
+                                            .ThenBy(x => VerifyHelper.GetSpanDepth(x, spans))
+                                            .ThenBy(x => x.Tags.TryGetValue("http.url", out var url) ? url : string.Empty)


A bit annoying, but we need to add this extra sorting layer to get stable snapshots

datadog-ddstaging · 2024-10-30T16:15:31Z

Datadog Report

Branch report: andrew/ci/convert-web-request-tests-to-snapshot
Commit report: 4e63c00
Test service: dd-trace-dotnet

✅ 0 Failed, 389245 Passed, 2780 Skipped, 34h 6m 41.64s Total Time

andrewlock · 2024-10-30T16:25:28Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6223) - mean (71ms)  : 68, 73
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6223) - mean (1,114ms)  : 1091, 1137
     .   : milestone, 1114,
    master - mean (1,118ms)  : 1096, 1140
     .   : milestone, 1118,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6223) - mean (110ms)  : 107, 112
     .   : milestone, 110,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6223) - mean (777ms)  : 759, 795
     .   : milestone, 777,
    master - mean (778ms)  : 753, 803
     .   : milestone, 778,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6223) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6223) - mean (728ms)  : 710, 747
     .   : milestone, 728,
    master - mean (733ms)  : 716, 750
     .   : milestone, 733,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6223) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6223) - mean (1,204ms)  : 1184, 1225
     .   : milestone, 1204,
    master - mean (1,204ms)  : 1181, 1227
     .   : milestone, 1204,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6223) - mean (277ms)  : 273, 280
     .   : milestone, 277,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6223) - mean (944ms)  : 930, 957
     .   : milestone, 944,
    master - mean (945ms)  : 927, 964
     .   : milestone, 945,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6223) - mean (265ms)  : 262, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6223) - mean (928ms)  : 906, 950
     .   : milestone, 928,
    master - mean (928ms)  : 907, 950
     .   : milestone, 928,

andrewlock · 2024-10-30T17:31:27Z

Benchmarks Report for tracer 🐌

Benchmarks for #6223 compared to master:

1 benchmarks are faster, with geometric mean 1.169
1 benchmarks are slower, with geometric mean 1.194
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.7μs	42.8ns	267ns	0.0162	0.00406	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.92μs	53.5ns	288ns	0.0189	0.00943	0	5.61 KB
master	`StartStopWithChild`	net472	16μs	66.6ns	258ns	1.04	0.33	0.0967	6.06 KB
#6223	`StartStopWithChild`	net6.0	7.89μs	44.6ns	315ns	0.0155	0.00774	0	5.43 KB
#6223	`StartStopWithChild`	netcoreapp3.1	10μs	56.5ns	395ns	0.0149	0.00496	0	5.62 KB
#6223	`StartStopWithChild`	net472	16.3μs	66.9ns	259ns	1.03	0.325	0.0975	6.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	482μs	278ns	1.04μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	383ns	1.48μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	839μs	253ns	911ns	0.419	3.3 KB
#6223	`WriteAndFlushEnrichedTraces`	net6.0	524μs	1.32μs	4.95μs	0	2.7 KB
#6223	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	443ns	1.72μs	0	2.7 KB
#6223	`WriteAndFlushEnrichedTraces`	net472	838μs	341ns	1.32μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	200μs	1.15μs	9.6μs	0.19	18.45 KB
master	`SendRequest`	netcoreapp3.1	225μs	1.31μs	11.6μs	0.207	20.61 KB
master	`SendRequest`	net472	0.00136ns	0.000644ns	0.00241ns	0	0 b
#6223	`SendRequest`	net6.0	197μs	1.13μs	8.62μs	0.194	18.45 KB
#6223	`SendRequest`	netcoreapp3.1	227μs	1.31μs	10.8μs	0.223	20.61 KB
#6223	`SendRequest`	net472	9.06E‑05ns	9.06E‑05ns	0.000326ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	558μs	2.95μs	14.7μs	0.556	0	0	41.45 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	3.57μs	18.2μs	0.329	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	net472	868μs	2.52μs	9.42μs	8.3	2.62	0.437	53.34 KB
#6223	`WriteAndFlushEnrichedTraces`	net6.0	572μs	3.01μs	16.2μs	0.638	0	0	41.56 KB
#6223	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	692μs	3.9μs	26.1μs	0.345	0	0	41.73 KB
#6223	`WriteAndFlushEnrichedTraces`	net472	851μs	4.27μs	18.1μs	8.33	2.5	0.417	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	1.23ns	4.76ns	0.0145	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.82μs	1.45ns	5.6ns	0.0137	1.02 KB
master	`ExecuteNonQuery`	net472	2.08μs	2.74ns	10.6ns	0.157	987 B
#6223	`ExecuteNonQuery`	net6.0	1.38μs	1.34ns	5.03ns	0.0144	1.02 KB
#6223	`ExecuteNonQuery`	netcoreapp3.1	1.84μs	1.46ns	5.64ns	0.013	1.02 KB
#6223	`ExecuteNonQuery`	net472	2.16μs	2.76ns	10.7ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.585ns	2.19ns	0.014	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.82ns	3.07ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.53μs	2.45ns	9.49ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.23μs	0.381ns	1.43ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.686ns	2.66ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.59μs	2ns	7.74ns	0.167	1.05 KB
#6223	`CallElasticsearch`	net6.0	1.29μs	0.325ns	1.22ns	0.0137	976 B
#6223	`CallElasticsearch`	netcoreapp3.1	1.5μs	0.8ns	3.1ns	0.0129	976 B
#6223	`CallElasticsearch`	net472	2.53μs	1.3ns	5.02ns	0.157	995 B
#6223	`CallElasticsearchAsync`	net6.0	1.31μs	0.465ns	1.8ns	0.013	952 B
#6223	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	1.85ns	7.17ns	0.0137	1.02 KB
#6223	`CallElasticsearchAsync`	net472	2.57μs	1.44ns	5.59ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.33μs	0.646ns	2.42ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.61ns	2.28ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.77μs	1.19ns	4.6ns	0.145	915 B
#6223	`ExecuteAsync`	net6.0	1.24μs	0.587ns	2.2ns	0.0136	952 B
#6223	`ExecuteAsync`	netcoreapp3.1	1.66μs	1.65ns	6.41ns	0.0126	952 B
#6223	`ExecuteAsync`	net472	1.7μs	1.22ns	4.74ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.13μs	1.38ns	5.15ns	0.031	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.08μs	1.79ns	6.93ns	0.0382	2.76 KB
master	`SendAsync`	net472	7.83μs	3.37ns	12.6ns	0.497	3.15 KB
#6223	`SendAsync`	net6.0	4.13μs	1.05ns	3.78ns	0.0309	2.22 KB
#6223	`SendAsync`	netcoreapp3.1	5.07μs	1.58ns	6.1ns	0.0358	2.76 KB
#6223	`SendAsync`	net472	7.72μs	2.32ns	8.97ns	0.5	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	0.988ns	3.7ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	1.44ns	5.39ns	0.0227	1.64 KB
master	`EnrichedLog`	net472	2.5μs	1.24ns	4.79ns	0.249	1.57 KB
#6223	`EnrichedLog`	net6.0	1.44μs	0.614ns	2.3ns	0.0229	1.64 KB
#6223	`EnrichedLog`	netcoreapp3.1	2.4μs	1.01ns	3.9ns	0.0218	1.64 KB
#6223	`EnrichedLog`	net472	2.62μs	1.1ns	4.13ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	117μs	162ns	628ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	169ns	655ns	0.0622	0	4.28 KB
master	`EnrichedLog`	net472	152μs	241ns	932ns	0.684	0.228	4.46 KB
#6223	`EnrichedLog`	net6.0	116μs	202ns	781ns	0.0582	0	4.28 KB
#6223	`EnrichedLog`	netcoreapp3.1	122μs	171ns	641ns	0	0	4.28 KB
#6223	`EnrichedLog`	net472	150μs	241ns	934ns	0.68	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.18ns	4.57ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.15μs	1.99ns	7.7ns	0.0292	2.2 KB
master	`EnrichedLog`	net472	4.78μs	1.12ns	3.88ns	0.32	2.02 KB
#6223	`EnrichedLog`	net6.0	3.05μs	1.05ns	3.8ns	0.031	2.2 KB
#6223	`EnrichedLog`	netcoreapp3.1	4.27μs	2.32ns	8.99ns	0.03	2.2 KB
#6223	`EnrichedLog`	net472	4.95μs	2.64ns	9.87ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.3μs	0.596ns	2.31ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.518ns	2.01ns	0.0151	1.14 KB
master	`SendReceive`	net472	2.16μs	1.02ns	3.95ns	0.183	1.16 KB
#6223	`SendReceive`	net6.0	1.38μs	1.18ns	4.59ns	0.0159	1.14 KB
#6223	`SendReceive`	netcoreapp3.1	1.83μs	0.792ns	3.07ns	0.0155	1.14 KB
#6223	`SendReceive`	net472	2.05μs	2.56ns	9.9ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	1.1ns	4.28ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.78μs	1.74ns	6.52ns	0.0209	1.65 KB
master	`EnrichedLog`	net472	4.39μs	1.86ns	6.71ns	0.324	2.04 KB
#6223	`EnrichedLog`	net6.0	2.79μs	2.06ns	7.96ns	0.0223	1.6 KB
#6223	`EnrichedLog`	netcoreapp3.1	3.92μs	1.26ns	4.89ns	0.022	1.65 KB
#6223	`EnrichedLog`	net472	4.41μs	1.97ns	7.38ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6223

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.194	544.34	649.79

Faster 🎉 in #6223

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.169	471.32	403.14

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	471ns	0.337ns	1.26ns	0.0081	576 B
master	`StartFinishSpan`	netcoreapp3.1	544ns	0.28ns	1.01ns	0.00786	576 B
master	`StartFinishSpan`	net472	662ns	0.729ns	2.82ns	0.0915	578 B
master	`StartFinishScope`	net6.0	500ns	0.388ns	1.5ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	796ns	3.86ns	15.9ns	0.0095	696 B
master	`StartFinishScope`	net472	909ns	0.415ns	1.55ns	0.104	658 B
#6223	`StartFinishSpan`	net6.0	403ns	0.212ns	0.793ns	0.00808	576 B
#6223	`StartFinishSpan`	netcoreapp3.1	650ns	0.406ns	1.52ns	0.00773	576 B
#6223	`StartFinishSpan`	net472	664ns	0.304ns	1.18ns	0.0916	578 B
#6223	`StartFinishScope`	net6.0	491ns	0.333ns	1.29ns	0.00983	696 B
#6223	`StartFinishScope`	netcoreapp3.1	750ns	0.38ns	1.47ns	0.00937	696 B
#6223	`StartFinishScope`	net472	858ns	0.958ns	3.71ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	669ns	0.569ns	2.2ns	0.00972	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	954ns	0.395ns	1.53ns	0.00913	696 B
master	`RunOnMethodBegin`	net472	1.17μs	0.489ns	1.89ns	0.104	658 B
#6223	`RunOnMethodBegin`	net6.0	676ns	0.401ns	1.55ns	0.00983	696 B
#6223	`RunOnMethodBegin`	netcoreapp3.1	1.03μs	3.14ns	12.2ns	0.00937	696 B
#6223	`RunOnMethodBegin`	net472	1.16μs	0.53ns	2.05ns	0.104	658 B

andrewlock · 2024-10-30T19:30:10Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6223) (11.287M)   : 0, 11286734
    master (11.037M)   : 0, 11037382
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6223) (7.461M)   : 0, 7460932
    master (7.332M)   : 0, 7331545
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.599M)   : 0, 7599283

    section Manual
    master (11.138M)   : 0, 11137529

    section Manual + Automatic
    This PR (6223) (6.831M)   : 0, 6831461
    master (6.810M)   : 0, 6810452

    section DD_TRACE_ENABLED=0
    master (10.315M)   : 0, 10314577

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6223) (9.639M)   : 0, 9639332
    master (9.239M)   : 0, 9238939
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6223) (6.486M)   : 0, 6486032
    master (6.663M)   : 0, 6663078

    section Trace stats
    master (6.810M)   : 0, 6810312

    section Manual
    master (9.476M)   : 0, 9476291

    section Manual + Automatic
    This PR (6223) (6.220M)   : 0, 6220231
    master (5.927M)   : 0, 5927373

    section DD_TRACE_ENABLED=0
    master (8.897M)   : 0, 8896810

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6223) (9.783M)   : 0, 9783431
    master (9.875M)   : 0, 9874887
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6223) (6.329M)   : 0, 6329380
    master (6.385M)   : 0, 6384926
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.066M)   : 0, 7066003

    section Manual
    master (9.880M)   : 0, 9880054

    section Manual + Automatic
    This PR (6223) (6.065M)   : 0, 6064796
    master (6.127M)   : 0, 6126574

    section DD_TRACE_ENABLED=0
    master (9.337M)   : 0, 9337260

andrewlock added the area:tests unit tests, integration tests label Oct 30, 2024

andrewlock requested review from a team as code owners October 30, 2024 15:42

andrewlock commented Oct 30, 2024

View reviewed changes

Convert WebRequestTests to snapshot tests

4e63c00

andrewlock force-pushed the andrew/ci/convert-web-request-tests-to-snapshot branch from 2811fee to 4e63c00 Compare October 30, 2024 15:52

kevingosse approved these changes Oct 31, 2024

View reviewed changes

andrewlock merged commit ddc6f9c into master Oct 31, 2024
77 checks passed

andrewlock deleted the andrew/ci/convert-web-request-tests-to-snapshot branch October 31, 2024 09:32

github-actions bot added this to the vNext-v3 milestone Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert WebRequestTests to snapshot tests #6223

Convert WebRequestTests to snapshot tests #6223

andrewlock commented Oct 30, 2024 •

edited

Loading

andrewlock Oct 30, 2024

datadog-ddstaging bot commented Oct 30, 2024 •

edited

Loading

andrewlock commented Oct 30, 2024

andrewlock commented Oct 30, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6223

Faster 🎉 in #6223

Raw results

Raw results

andrewlock commented Oct 30, 2024

Convert WebRequestTests to snapshot tests #6223

Convert WebRequestTests to snapshot tests #6223

Conversation

andrewlock commented Oct 30, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

andrewlock Oct 30, 2024

Choose a reason for hiding this comment

datadog-ddstaging bot commented Oct 30, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 30, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 30, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6223

Faster 🎉 in #6223

Raw results

Raw results

andrewlock commented Oct 30, 2024

Throughput/Crank Report ⚡

andrewlock commented Oct 30, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 30, 2024 •

edited

Loading