Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all RC int values to long, to mirror RC backend #6219

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

robertpi
Copy link
Member

Summary of changes

RC backend use long for there integer fields.

@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 30, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 30, 2024

Datadog Report

Branch report: robert/correct-rc-version-size
Commit report: e2e4936
Test service: dd-trace-dotnet

✅ 0 Failed, 368697 Passed, 2101 Skipped, 15h 30m 4.47s Total Time

@andrewlock
Copy link
Member

andrewlock commented Oct 30, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6219) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6219) - mean (1,117ms)  : 1096, 1138
     .   : milestone, 1117,
    master - mean (1,118ms)  : 1096, 1140
     .   : milestone, 1118,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6219) - mean (110ms)  : 107, 114
     .   : milestone, 110,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6219) - mean (775ms)  : 762, 789
     .   : milestone, 775,
    master - mean (778ms)  : 753, 803
     .   : milestone, 778,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6219) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6219) - mean (730ms)  : 711, 750
     .   : milestone, 730,
    master - mean (733ms)  : 716, 750
     .   : milestone, 733,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6219) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6219) - mean (1,199ms)  : 1172, 1227
     .   : milestone, 1199,
    master - mean (1,204ms)  : 1181, 1227
     .   : milestone, 1204,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6219) - mean (277ms)  : 271, 282
     .   : milestone, 277,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6219) - mean (940ms)  : 922, 958
     .   : milestone, 940,
    master - mean (945ms)  : 927, 964
     .   : milestone, 945,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6219) - mean (265ms)  : 260, 271
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6219) - mean (923ms)  : 905, 941
     .   : milestone, 923,
    master - mean (928ms)  : 907, 950
     .   : milestone, 928,

Loading

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions:

  • Should we convert uint to ulong?
  • Should we be using unsigned values for any of these?

@andrewlock
Copy link
Member

andrewlock commented Oct 30, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6219) (11.207M)   : 0, 11206817
    master (11.037M)   : 0, 11037382
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6219) (7.340M)   : 0, 7340386
    master (7.332M)   : 0, 7331545
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.599M)   : 0, 7599283

    section Manual
    master (11.138M)   : 0, 11137529

    section Manual + Automatic
    This PR (6219) (6.903M)   : 0, 6903351
    master (6.810M)   : 0, 6810452

    section DD_TRACE_ENABLED=0
    master (10.315M)   : 0, 10314577

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6219) (9.740M)   : 0, 9740125
    master (9.239M)   : 0, 9238939
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6219) (6.581M)   : 0, 6580792
    master (6.663M)   : 0, 6663078

    section Trace stats
    master (6.810M)   : 0, 6810312

    section Manual
    master (9.476M)   : 0, 9476291

    section Manual + Automatic
    This PR (6219) (6.238M)   : 0, 6238130
    master (5.927M)   : 0, 5927373

    section DD_TRACE_ENABLED=0
    master (8.897M)   : 0, 8896810

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6219) (9.866M)   : 0, 9866330
    master (9.875M)   : 0, 9874887
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6219) (6.402M)   : 0, 6401913
    master (6.385M)   : 0, 6384926
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.066M)   : 0, 7066003

    section Manual
    master (9.880M)   : 0, 9880054

    section Manual + Automatic
    This PR (6219) (5.910M)   : 0, 5909809
    master (6.127M)   : 0, 6126574

    section DD_TRACE_ENABLED=0
    master (9.337M)   : 0, 9337260

Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 30, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6219 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.56μs 37.5ns 202ns 0.0157 0.00787 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.84μs 55.8ns 414ns 0.02 0.01 0 5.62 KB
master StartStopWithChild net472 16.4μs 49.1ns 190ns 1 0.294 0.0817 6.06 KB
#6219 StartStopWithChild net6.0 7.6μs 43.9ns 340ns 0.011 0.00365 0 5.43 KB
#6219 StartStopWithChild netcoreapp3.1 9.95μs 54.3ns 384ns 0.0138 0.00459 0 5.62 KB
#6219 StartStopWithChild net472 16.1μs 50.5ns 196ns 1.02 0.312 0.107 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 484μs 198ns 768ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 237ns 887ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 841μs 671ns 2.6μs 0.417 0 0 3.3 KB
#6219 WriteAndFlushEnrichedTraces net6.0 492μs 826ns 3.6μs 0 0 0 2.7 KB
#6219 WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 440ns 1.65μs 0 0 0 2.7 KB
#6219 WriteAndFlushEnrichedTraces net472 830μs 397ns 1.43μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 207μs 1.47μs 14.7μs 0.197 0 0 18.45 KB
master SendRequest netcoreapp3.1 221μs 1.27μs 9.59μs 0.214 0 0 20.61 KB
master SendRequest net472 0.00161ns 0.000618ns 0.00239ns 0 0 0 0 b
#6219 SendRequest net6.0 199μs 1.12μs 7.61μs 0.185 0 0 18.45 KB
#6219 SendRequest netcoreapp3.1 227μs 1.39μs 13.8μs 0.22 0 0 20.61 KB
#6219 SendRequest net472 0.00027ns 0.00016ns 0.000622ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 572μs 3.07μs 16.5μs 0.566 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 692μs 3.7μs 20.6μs 0.332 0 0 41.76 KB
master WriteAndFlushEnrichedTraces net472 893μs 4.37μs 18μs 8.09 2.25 0.45 53.27 KB
#6219 WriteAndFlushEnrichedTraces net6.0 569μs 3.05μs 16.7μs 0.581 0 0 41.49 KB
#6219 WriteAndFlushEnrichedTraces netcoreapp3.1 712μs 3.63μs 22.1μs 0.336 0 0 41.68 KB
#6219 WriteAndFlushEnrichedTraces net472 859μs 3.44μs 12.9μs 8.45 2.53 0.422 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.25μs 0.592ns 2.21ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.74μs 3.42ns 13.2ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 1.91ns 7.39ns 0.156 0 0 987 B
#6219 ExecuteNonQuery net6.0 1.28μs 1.03ns 3.98ns 0.014 0 0 1.02 KB
#6219 ExecuteNonQuery netcoreapp3.1 1.78μs 1.03ns 3.99ns 0.0139 0 0 1.02 KB
#6219 ExecuteNonQuery net472 2.09μs 3.04ns 11.8ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.13μs 1.9ns 7.12ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.59μs 0.592ns 2.29ns 0.0136 0 0 976 B
master CallElasticsearch net472 2.47μs 1.07ns 3.86ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.34μs 0.536ns 2.01ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 0.763ns 2.75ns 0.0136 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 0.898ns 3.48ns 0.167 0 0 1.05 KB
#6219 CallElasticsearch net6.0 1.16μs 0.541ns 2.03ns 0.0133 0 0 976 B
#6219 CallElasticsearch netcoreapp3.1 1.49μs 0.679ns 2.54ns 0.0128 0 0 976 B
#6219 CallElasticsearch net472 2.56μs 2.44ns 9.46ns 0.158 0 0 995 B
#6219 CallElasticsearchAsync net6.0 1.25μs 0.368ns 1.43ns 0.0131 0 0 952 B
#6219 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.7ns 2.62ns 0.0143 0 0 1.02 KB
#6219 CallElasticsearchAsync net472 2.68μs 2.47ns 8.9ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.38μs 0.85ns 3.29ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.64μs 0.783ns 2.82ns 0.0123 0 0 952 B
master ExecuteAsync net472 1.74μs 0.71ns 2.75ns 0.145 0 0 915 B
#6219 ExecuteAsync net6.0 1.25μs 0.527ns 2.04ns 0.0132 0 0 952 B
#6219 ExecuteAsync netcoreapp3.1 1.64μs 0.989ns 3.7ns 0.0123 0 0 952 B
#6219 ExecuteAsync net472 1.79μs 1.17ns 4.53ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.22μs 1.48ns 5.73ns 0.0317 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.06μs 2.75ns 10.7ns 0.0379 0 0 2.76 KB
master SendAsync net472 7.72μs 4.27ns 16.5ns 0.496 0 0 3.15 KB
#6219 SendAsync net6.0 4.04μs 2.19ns 8.48ns 0.0303 0 0 2.22 KB
#6219 SendAsync netcoreapp3.1 5.06μs 3.69ns 14.3ns 0.0357 0 0 2.76 KB
#6219 SendAsync net472 7.9μs 3.17ns 12.3ns 0.498 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.46μs 0.512ns 1.92ns 0.0233 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.29μs 1.41ns 5.26ns 0.0217 0 0 1.64 KB
master EnrichedLog net472 2.48μs 0.967ns 3.75ns 0.249 0 0 1.57 KB
#6219 EnrichedLog net6.0 1.55μs 1.18ns 4.41ns 0.0226 0 0 1.64 KB
#6219 EnrichedLog netcoreapp3.1 2.19μs 0.792ns 2.74ns 0.022 0 0 1.64 KB
#6219 EnrichedLog net472 2.54μs 1.16ns 4.48ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 120μs 228ns 884ns 0.0608 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 341ns 1.32μs 0.0596 0 0 4.28 KB
master EnrichedLog net472 152μs 187ns 723ns 0.679 0.226 0 4.46 KB
#6219 EnrichedLog net6.0 117μs 133ns 514ns 0.0587 0 0 4.28 KB
#6219 EnrichedLog netcoreapp3.1 122μs 312ns 1.21μs 0 0 0 4.28 KB
#6219 EnrichedLog net472 150μs 314ns 1.22μs 0.673 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.21μs 1.29ns 5.01ns 0.0306 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.37μs 1.71ns 6.4ns 0.0287 0 0 2.2 KB
master EnrichedLog net472 4.91μs 4.23ns 14.6ns 0.32 0 0 2.02 KB
#6219 EnrichedLog net6.0 3.16μs 1.01ns 3.92ns 0.03 0 0 2.2 KB
#6219 EnrichedLog netcoreapp3.1 4.09μs 1.32ns 5.13ns 0.0307 0 0 2.2 KB
#6219 EnrichedLog net472 4.99μs 1.58ns 6.12ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.3μs 0.7ns 2.62ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.79μs 0.703ns 2.63ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.15μs 0.727ns 2.82ns 0.183 0 0 1.16 KB
#6219 SendReceive net6.0 1.37μs 1.08ns 4.18ns 0.016 0 0 1.14 KB
#6219 SendReceive netcoreapp3.1 1.78μs 0.792ns 2.96ns 0.0152 0 0 1.14 KB
#6219 SendReceive net472 2.08μs 2.37ns 9.18ns 0.183 0.00105 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.73μs 0.865ns 3.12ns 0.0218 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.9μs 2.48ns 9.61ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.27μs 2.13ns 7.96ns 0.324 0 0 2.04 KB
#6219 EnrichedLog net6.0 2.78μs 1.15ns 4.44ns 0.0223 0 0 1.6 KB
#6219 EnrichedLog netcoreapp3.1 3.84μs 2.23ns 8.35ns 0.0212 0 0 1.65 KB
#6219 EnrichedLog net472 4.32μs 8.69ns 33.7ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 397ns 0.138ns 0.516ns 0.00799 0 0 576 B
master StartFinishSpan netcoreapp3.1 565ns 0.29ns 1.08ns 0.00788 0 0 576 B
master StartFinishSpan net472 673ns 0.331ns 1.15ns 0.0917 0 0 578 B
master StartFinishScope net6.0 597ns 0.236ns 0.913ns 0.00958 0 0 696 B
master StartFinishScope netcoreapp3.1 719ns 0.528ns 1.98ns 0.00968 0 0 696 B
master StartFinishScope net472 865ns 0.643ns 2.49ns 0.104 0 0 658 B
#6219 StartFinishSpan net6.0 399ns 0.231ns 0.895ns 0.00801 0 0 576 B
#6219 StartFinishSpan netcoreapp3.1 558ns 0.463ns 1.79ns 0.00774 0 0 576 B
#6219 StartFinishSpan net472 725ns 0.556ns 2.15ns 0.0916 0 0 578 B
#6219 StartFinishScope net6.0 569ns 1.72ns 6.67ns 0.00962 0 0 696 B
#6219 StartFinishScope netcoreapp3.1 784ns 2.7ns 10.4ns 0.00946 0 0 696 B
#6219 StartFinishScope net472 899ns 0.428ns 1.66ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 618ns 1.6ns 6.2ns 0.01 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 949ns 0.548ns 2.12ns 0.00907 0 0 696 B
master RunOnMethodBegin net472 1.13μs 0.319ns 1.19ns 0.104 0 0 658 B
#6219 RunOnMethodBegin net6.0 687ns 0.344ns 1.33ns 0.00961 0 0 696 B
#6219 RunOnMethodBegin netcoreapp3.1 886ns 0.69ns 2.58ns 0.00934 0 0 696 B
#6219 RunOnMethodBegin net472 1.14μs 2.83ns 11ns 0.104 0 0 658 B

@robertpi robertpi marked this pull request as ready for review October 31, 2024 08:15
@robertpi robertpi requested a review from a team as a code owner October 31, 2024 08:15
@robertpi robertpi merged commit f9cf180 into master Oct 31, 2024
75 of 77 checks passed
@robertpi robertpi deleted the robert/correct-rc-version-size branch October 31, 2024 10:22
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 31, 2024
andrewlock pushed a commit that referenced this pull request Nov 1, 2024
## Summary of changes

RC backend use long for there integer fields.
@andrewlock andrewlock added area:remote-config and removed area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) labels Nov 1, 2024
andrewlock added a commit that referenced this pull request Nov 4, 2024
…6228)

## Summary of changes

RC backend use long for there integer fields.

Backport of 
- #6219

Co-authored-by: Robert Pickering <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants