-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move all RC int values to long, to mirror RC backend #6219
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 368697 Passed, 2101 Skipped, 15h 30m 4.47s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6219) - mean (71ms) : 68, 74
. : milestone, 71,
master - mean (70ms) : 68, 72
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6219) - mean (1,117ms) : 1096, 1138
. : milestone, 1117,
master - mean (1,118ms) : 1096, 1140
. : milestone, 1118,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6219) - mean (110ms) : 107, 114
. : milestone, 110,
master - mean (110ms) : 106, 114
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6219) - mean (775ms) : 762, 789
. : milestone, 775,
master - mean (778ms) : 753, 803
. : milestone, 778,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6219) - mean (93ms) : 90, 96
. : milestone, 93,
master - mean (94ms) : 90, 97
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (6219) - mean (730ms) : 711, 750
. : milestone, 730,
master - mean (733ms) : 716, 750
. : milestone, 733,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6219) - mean (191ms) : 187, 195
. : milestone, 191,
master - mean (190ms) : 187, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6219) - mean (1,199ms) : 1172, 1227
. : milestone, 1199,
master - mean (1,204ms) : 1181, 1227
. : milestone, 1204,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6219) - mean (277ms) : 271, 282
. : milestone, 277,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6219) - mean (940ms) : 922, 958
. : milestone, 940,
master - mean (945ms) : 927, 964
. : milestone, 945,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6219) - mean (265ms) : 260, 271
. : milestone, 265,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6219) - mean (923ms) : 905, 941
. : milestone, 923,
master - mean (928ms) : 907, 950
. : milestone, 928,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions:
- Should we convert
uint
toulong
? - Should we be using unsigned values for any of these?
tracer/src/Datadog.Trace/RemoteConfigurationManagement/Protocol/RcmConfigState.cs
Show resolved
Hide resolved
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6219) (11.207M) : 0, 11206817
master (11.037M) : 0, 11037382
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6219) (7.340M) : 0, 7340386
master (7.332M) : 0, 7331545
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.599M) : 0, 7599283
section Manual
master (11.138M) : 0, 11137529
section Manual + Automatic
This PR (6219) (6.903M) : 0, 6903351
master (6.810M) : 0, 6810452
section DD_TRACE_ENABLED=0
master (10.315M) : 0, 10314577
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6219) (9.740M) : 0, 9740125
master (9.239M) : 0, 9238939
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6219) (6.581M) : 0, 6580792
master (6.663M) : 0, 6663078
section Trace stats
master (6.810M) : 0, 6810312
section Manual
master (9.476M) : 0, 9476291
section Manual + Automatic
This PR (6219) (6.238M) : 0, 6238130
master (5.927M) : 0, 5927373
section DD_TRACE_ENABLED=0
master (8.897M) : 0, 8896810
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6219) (9.866M) : 0, 9866330
master (9.875M) : 0, 9874887
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6219) (6.402M) : 0, 6401913
master (6.385M) : 0, 6384926
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.066M) : 0, 7066003
section Manual
master (9.880M) : 0, 9880054
section Manual + Automatic
This PR (6219) (5.910M) : 0, 5909809
master (6.127M) : 0, 6126574
section DD_TRACE_ENABLED=0
master (9.337M) : 0, 9337260
|
Benchmarks Report for tracer 🐌Benchmarks for #6219 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
## Summary of changes RC backend use long for there integer fields.
…6228) ## Summary of changes RC backend use long for there integer fields. Backport of - #6219 Co-authored-by: Robert Pickering <[email protected]>
Summary of changes
RC backend use long for there integer fields.