Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Instrumentation] DEBUG-3076 Code origin for exit spans #6216

Merged
merged 16 commits into from
Nov 7, 2024

Conversation

dudikeleti
Copy link
Contributor

@dudikeleti dudikeleti commented Oct 29, 2024

Summary of changes

This PR introduce the Code origin for span feature. In this PR there is the implementation for exit span and the implementation for entry span will be in a following PR.

Reason for change

We want to let user the ability to see from where in the code each exit span was created, and in the future, let the user automatically put probe there.

Implementation details

We are adding code roigin information tags to the span.

Test coverage

SpanCodeOriginTests.cs

@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Oct 29, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 29, 2024

Datadog Report

Branch report: dudik/code-origin-exit-span
Commit report: 872901b
Test service: dd-trace-dotnet

❌ 48 Failed (3 Known Flaky), 314167 Passed, 2664 Skipped, 25h 16m 22.33s Total Time
⌛ 1 Performance Regression

❌ Failed Tests (48)

This report shows up to 5 failed tests.

  • SetCodeOrigin_WhenEnabled_SetsCorrectTags - Datadog.Trace.Tests.Debugger.SpanCodeOriginTests - Details

    Expand for error
     Expected frame0Method to be "TestMethod" with a length of 10, but "SetCodeOrigin_WhenEnabled_SetsCorrectTags" has a length of 41, differs near "Set" (index 0).
    
  • SetCodeOrigin_WhenEnabled_SetsCorrectTags - Datadog.Trace.Tests.Debugger.SpanCodeOriginTests - Details

    Expand for error
     Expected frame0Method to be "TestMethod" with a length of 10, but "SetCodeOrigin_WhenEnabled_SetsCorrectTags" has a length of 41, differs near "Set" (index 0).
    
  • SetCodeOrigin_WhenEnabled_SetsCorrectTags - Datadog.Trace.Tests.Debugger.SpanCodeOriginTests - Details

    Expand for error
     Expected frame0Method to be "TestMethod" with a length of 10, but "SetCodeOrigin_WhenEnabled_SetsCorrectTags" has a length of 41, differs near "Set" (index 0).
    
  • SetCodeOrigin_WhenEnabled_SetsCorrectTags - Datadog.Trace.Tests.Debugger.SpanCodeOriginTests - Details

    Expand for error
     Expected frame0Method to be "TestMethod" with a length of 10, but "SetCodeOrigin_WhenEnabled_SetsCorrectTags" has a length of 41, differs near "Set" (index 0).
    
  • SetCodeOrigin_WhenEnabled_SetsCorrectTags - Datadog.Trace.Tests.Debugger.SpanCodeOriginTests - Details

    Expand for error
     Expected frame0Method to be "TestMethod" with a length of 10, but "SetCodeOrigin_WhenEnabled_SetsCorrectTags" has a length of 41, differs near "Set" (index 0).
    

⌛ Performance Regressions vs Default Branch (1)

  • Profiler_cpu_walltime - scenarios 3.53s (+193.91ms, +6%) - Details

@andrewlock
Copy link
Member

andrewlock commented Oct 29, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6216) - mean (69ms)  : 68, 71
     .   : milestone, 69,
    master - mean (69ms)  : 68, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6216) - mean (1,111ms)  : 1091, 1131
     .   : milestone, 1111,
    master - mean (1,107ms)  : 1085, 1130
     .   : milestone, 1107,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6216) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6216) - mean (771ms)  : 756, 785
     .   : milestone, 771,
    master - mean (772ms)  : 747, 798
     .   : milestone, 772,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6216) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6216) - mean (729ms)  : 713, 744
     .   : milestone, 729,
    master - mean (726ms)  : 714, 737
     .   : milestone, 726,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6216) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6216) - mean (1,224ms)  : 1202, 1245
     .   : milestone, 1224,
    master - mean (1,223ms)  : 1196, 1250
     .   : milestone, 1223,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6216) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6216) - mean (950ms)  : 931, 970
     .   : milestone, 950,
    master - mean (955ms)  : 939, 970
     .   : milestone, 955,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6216) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (265ms)  : 262, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6216) - mean (933ms)  : 912, 955
     .   : milestone, 933,
    master - mean (937ms)  : 913, 961
     .   : milestone, 937,

Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 29, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6216 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.159
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.88μs 44.6ns 312ns 0.0153 0.00765 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.98μs 53.9ns 332ns 0.0238 0.00952 0 5.8 KB
master StartStopWithChild net472 16.2μs 33.2ns 120ns 1.05 0.312 0.088 6.2 KB
#6216 StartStopWithChild net6.0 8.05μs 45.1ns 282ns 0.0126 0.00421 0 5.61 KB
#6216 StartStopWithChild netcoreapp3.1 9.89μs 55.5ns 359ns 0.02 0.01 0 5.8 KB
#6216 StartStopWithChild net472 16.4μs 61.3ns 237ns 1.05 0.325 0.106 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 505μs 231ns 895ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 283ns 1.1μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 883μs 575ns 2.23μs 0.443 0 0 3.3 KB
#6216 WriteAndFlushEnrichedTraces net6.0 464μs 188ns 704ns 0 0 0 2.7 KB
#6216 WriteAndFlushEnrichedTraces netcoreapp3.1 627μs 515ns 1.99μs 0 0 0 2.7 KB
#6216 WriteAndFlushEnrichedTraces net472 839μs 386ns 1.44μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 196μs 1.04μs 6.33μs 0.195 0 0 18.73 KB
master SendRequest netcoreapp3.1 211μs 924ns 3.46μs 0.209 0 0 20.89 KB
master SendRequest net472 0.00186ns 0.000705ns 0.00264ns 0 0 0 0 b
#6216 SendRequest net6.0 202μs 1.13μs 7.31μs 0.198 0 0 18.73 KB
#6216 SendRequest netcoreapp3.1 220μs 1.25μs 9.47μs 0.225 0 0 20.89 KB
#6216 SendRequest net472 0.00294ns 0.00122ns 0.00456ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 551μs 2.86μs 13.4μs 0.548 0 0 41.6 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 680μs 3.1μs 12μs 0.34 0 0 41.85 KB
master WriteAndFlushEnrichedTraces net472 849μs 2.53μs 9.48μs 8.45 2.53 0.422 53.28 KB
#6216 WriteAndFlushEnrichedTraces net6.0 567μs 2.71μs 11.5μs 0.581 0 0 41.64 KB
#6216 WriteAndFlushEnrichedTraces netcoreapp3.1 692μs 3.92μs 29.1μs 0.336 0 0 41.69 KB
#6216 WriteAndFlushEnrichedTraces net472 892μs 3.27μs 12.7μs 8.42 2.66 0.443 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.27μs 1.06ns 4.1ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.7μs 2.15ns 8.33ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 1.23ns 4.76ns 0.157 0.00102 0 987 B
#6216 ExecuteNonQuery net6.0 1.22μs 1.09ns 4.23ns 0.0146 0 0 1.02 KB
#6216 ExecuteNonQuery netcoreapp3.1 1.79μs 1.46ns 5.67ns 0.0133 0 0 1.02 KB
#6216 ExecuteNonQuery net472 2.06μs 1.7ns 6.57ns 0.157 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.26μs 0.572ns 2.22ns 0.014 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 0.886ns 3.43ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.62μs 2.99ns 11.6ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.2μs 0.8ns 2.99ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.523ns 1.96ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.53μs 1.41ns 5.29ns 0.167 0 0 1.05 KB
#6216 CallElasticsearch net6.0 1.23μs 0.692ns 2.68ns 0.0136 0 0 976 B
#6216 CallElasticsearch netcoreapp3.1 1.57μs 0.74ns 2.77ns 0.0134 0 0 976 B
#6216 CallElasticsearch net472 2.49μs 1.84ns 7.12ns 0.157 0 0 995 B
#6216 CallElasticsearchAsync net6.0 1.26μs 0.41ns 1.54ns 0.0132 0 0 952 B
#6216 CallElasticsearchAsync netcoreapp3.1 1.66μs 0.811ns 2.93ns 0.0132 0 0 1.02 KB
#6216 CallElasticsearchAsync net472 2.6μs 0.701ns 2.62ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.32μs 0.676ns 2.53ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 1.21ns 4.52ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.79μs 0.401ns 1.45ns 0.145 0 0 915 B
#6216 ExecuteAsync net6.0 1.23μs 0.732ns 2.74ns 0.0129 0 0 952 B
#6216 ExecuteAsync netcoreapp3.1 1.6μs 0.742ns 2.87ns 0.0127 0 0 952 B
#6216 ExecuteAsync net472 1.77μs 0.466ns 1.74ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.44μs 1.91ns 7.39ns 0.0333 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.36μs 1.71ns 6.4ns 0.0372 0 0 2.85 KB
master SendAsync net472 7.37μs 1.55ns 6ns 0.493 0 0 3.12 KB
#6216 SendAsync net6.0 4.42μs 10.1ns 36.6ns 0.0326 0 0 2.31 KB
#6216 SendAsync netcoreapp3.1 5.47μs 2.37ns 8.88ns 0.0383 0 0 2.85 KB
#6216 SendAsync net472 7.55μs 3.32ns 12.4ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 1.04ns 3.88ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.26μs 1.05ns 4.07ns 0.0225 0 0 1.64 KB
master EnrichedLog net472 2.66μs 0.941ns 3.52ns 0.25 0 0 1.57 KB
#6216 EnrichedLog net6.0 1.54μs 0.98ns 3.67ns 0.0231 0 0 1.64 KB
#6216 EnrichedLog netcoreapp3.1 2.3μs 2.89ns 10.8ns 0.0218 0 0 1.64 KB
#6216 EnrichedLog net472 2.58μs 1.75ns 6.56ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 259ns 1μs 0.0587 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 154ns 595ns 0.0589 0 0 4.28 KB
master EnrichedLog net472 153μs 224ns 868ns 0.691 0.23 0 4.46 KB
#6216 EnrichedLog net6.0 118μs 230ns 862ns 0.0585 0 0 4.28 KB
#6216 EnrichedLog netcoreapp3.1 122μs 174ns 652ns 0 0 0 4.28 KB
#6216 EnrichedLog net472 155μs 148ns 555ns 0.691 0.23 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.95μs 0.803ns 3.11ns 0.031 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 3.99μs 1.17ns 4.36ns 0.0279 0 0 2.2 KB
master EnrichedLog net472 4.85μs 1.62ns 6.29ns 0.32 0 0 2.02 KB
#6216 EnrichedLog net6.0 3.13μs 0.949ns 3.55ns 0.0312 0 0 2.2 KB
#6216 EnrichedLog netcoreapp3.1 4.13μs 1.57ns 6.1ns 0.0289 0 0 2.2 KB
#6216 EnrichedLog net472 4.83μs 1.46ns 5.45ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.25μs 1.29ns 4.98ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.73μs 0.913ns 3.54ns 0.0156 0 0 1.14 KB
master SendReceive net472 2.21μs 1.12ns 4.32ns 0.183 0 0 1.16 KB
#6216 SendReceive net6.0 1.3μs 1.02ns 3.97ns 0.0162 0 0 1.14 KB
#6216 SendReceive netcoreapp3.1 1.77μs 1.4ns 5.44ns 0.0151 0 0 1.14 KB
#6216 SendReceive net472 2.11μs 0.643ns 2.49ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6216

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.133 2,626.49 2,975.71

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 1.01ns 3.91ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.93μs 2.17ns 8.13ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.47μs 3.48ns 13ns 0.323 0 0 2.04 KB
#6216 EnrichedLog net6.0 2.98μs 1.39ns 5.39ns 0.0223 0 0 1.6 KB
#6216 EnrichedLog netcoreapp3.1 3.9μs 1.04ns 4.02ns 0.0217 0 0 1.65 KB
#6216 EnrichedLog net472 4.38μs 2.42ns 9.38ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.191ns 0.713ns 0.00807 0 0 576 B
master StartFinishSpan netcoreapp3.1 572ns 0.867ns 3.36ns 0.00773 0 0 576 B
master StartFinishSpan net472 696ns 0.786ns 3.05ns 0.0917 0 0 578 B
master StartFinishScope net6.0 488ns 0.28ns 1.08ns 0.00976 0 0 696 B
master StartFinishScope netcoreapp3.1 798ns 0.541ns 2.1ns 0.00926 0 0 696 B
master StartFinishScope net472 917ns 0.916ns 3.55ns 0.104 0 0 658 B
#6216 StartFinishSpan net6.0 390ns 0.383ns 1.48ns 0.00803 0 0 576 B
#6216 StartFinishSpan netcoreapp3.1 622ns 0.565ns 2.19ns 0.00778 0 0 576 B
#6216 StartFinishSpan net472 701ns 0.231ns 0.895ns 0.0918 0 0 578 B
#6216 StartFinishScope net6.0 517ns 0.298ns 1.16ns 0.00988 0 0 696 B
#6216 StartFinishScope netcoreapp3.1 802ns 0.287ns 1.07ns 0.00966 0 0 696 B
#6216 StartFinishScope net472 846ns 0.37ns 1.43ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6216

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.186 649.81 770.55

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 650ns 0.76ns 2.94ns 0.00966 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 971ns 0.724ns 2.8ns 0.00922 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.911ns 3.53ns 0.104 0 0 658 B
#6216 RunOnMethodBegin net6.0 771ns 0.606ns 2.27ns 0.00969 0 0 696 B
#6216 RunOnMethodBegin netcoreapp3.1 955ns 0.785ns 2.83ns 0.00952 0 0 696 B
#6216 RunOnMethodBegin net472 1.17μs 0.589ns 2.2ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

andrewlock commented Oct 29, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6216) (11.084M)   : 0, 11084135
    master (11.136M)   : 0, 11135915
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6216) (7.240M)   : 0, 7239506
    master (7.187M)   : 0, 7186704
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.427M)   : 0, 7426907

    section Manual
    master (11.098M)   : 0, 11097657

    section Manual + Automatic
    This PR (6216) (6.804M)   : 0, 6803757
    master (6.654M)   : 0, 6654380

    section DD_TRACE_ENABLED=0
    master (10.119M)   : 0, 10118579

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6216) (9.607M)   : 0, 9606780
    master (9.394M)   : 0, 9393776
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6216) (6.412M)   : 0, 6411785
    master (6.542M)   : 0, 6541950

    section Trace stats
    master (6.783M)   : 0, 6783288

    section Manual
    master (9.544M)   : 0, 9543974

    section Manual + Automatic
    This PR (6216) (6.012M)   : 0, 6011834
    master (6.029M)   : 0, 6028696

    section DD_TRACE_ENABLED=0
    master (8.862M)   : 0, 8862284

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6216) (10.075M)   : 0, 10075328
    master (10.125M)   : 0, 10124778
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6216) (6.383M)   : 0, 6383120
    master (6.523M)   : 0, 6523473
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.166M)   : 0, 7165805

    section Manual
    master (9.735M)   : 0, 9735078

    section Manual + Automatic
    This PR (6216) (6.048M)   : 0, 6048205
    master (5.934M)   : 0, 5933603

    section DD_TRACE_ENABLED=0
    master (9.219M)   : 0, 9219305

Loading

@dudikeleti dudikeleti marked this pull request as ready for review October 30, 2024 11:49
@dudikeleti dudikeleti requested review from a team as code owners October 30, 2024 11:49
@dudikeleti dudikeleti force-pushed the dudik/code-origin-exit-span branch 2 times, most recently from e094951 to 2aa42bb Compare October 31, 2024 10:53
Copy link
Contributor

@GreenMatan GreenMatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given a review in person

@dudikeleti dudikeleti force-pushed the dudik/code-origin-exit-span branch 2 times, most recently from 665d7c7 to e7391f4 Compare October 31, 2024 17:09
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just some minor suggestions

On a different note, calling new StackTrace() for every span seems very expensive... is this something that would only be enabled temporarily? It looks like it would be globally enabled as far as I can tell, which seems like it could have a huge impact on performance? 🤔

@dudikeleti dudikeleti force-pushed the dudik/code-origin-exit-span branch 2 times, most recently from ccc2d56 to a453128 Compare November 6, 2024 08:16
@dudikeleti
Copy link
Contributor Author

Mostly just some minor suggestions

On a different note, calling new StackTrace() for every span seems very expensive... is this something that would only be enabled temporarily? It looks like it would be globally enabled as far as I can tell, which seems like it could have a huge impact on performance? 🤔

Right now it's disabled by default but we plan to enabled it. The plan is also to improve this and not use new StackTrace for every span.

@dudikeleti dudikeleti merged commit 0450aaa into master Nov 7, 2024
74 of 81 checks passed
@dudikeleti dudikeleti deleted the dudik/code-origin-exit-span branch November 7, 2024 10:37
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 7, 2024
dudikeleti added a commit that referenced this pull request Nov 12, 2024
…processor (#6242)

## Summary of changes
This PR is changes the weay we acessing span in probe processor. See
this
[comment](#6216 (comment))
for more info.
@andrewlock andrewlock added type:new-feature and removed area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants