Proposed fix: Remove dependency on System.IO.Compression for .NET Framework build #6192

zacharycmontoya · 2024-10-24T04:09:08Z

Summary of changes

Replaces usages of System.IO.Compression (ZipEntry) with a vendored SharpZibLib

Reason for change

Since System.IO.Compression can be consumed by applications with the out-of-band System.IO.Compression NuGet package, it can potentially cause assembly loading issues. This is the main reason why we do not use System.Net.Http in our .NET Framework build, as we previously observed crashes there.

Implementation details

Vendor in SharpZipLib v1.3.3 (MIT License)
Remove AssemblyReference to System.IO.Compression
Update Datadog.Trace.Logging.TracerFlare.DebugLogReader to use SharpZipLib instead of System.IO.Compression.ZipArchive
Update Datadog.Trace.Trimming.xml Root Descriptors File
Update snapshot tests that assert Datadog.Trace assembly references

Test coverage

Re-uses existing tests for tracer flare which authors the zip files

Other details

datadog-ddstaging · 2024-10-24T04:27:32Z

Datadog Report

Branch report: zach.montoya/fix-compression-lib
Commit report: e01f1b5
Test service: dd-trace-dotnet

✅ 0 Failed, 369251 Passed, 2096 Skipped, 15h 24m 28.07s Total Time

tracer/src/Datadog.Trace/Vendors/ICSharpCode.SharpZipLib/Encryption/ZipAESTransform.cs

andrewlock · 2024-10-24T04:51:52Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6192) - mean (69ms)  : 67, 72
     .   : milestone, 69,
    master - mean (69ms)  : 68, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6192) - mean (1,109ms)  : 1090, 1128
     .   : milestone, 1109,
    master - mean (1,105ms)  : 1085, 1124
     .   : milestone, 1105,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6192) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6192) - mean (773ms)  : 760, 785
     .   : milestone, 773,
    master - mean (768ms)  : 753, 783
     .   : milestone, 768,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6192) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 90, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6192) - mean (735ms)  : 714, 756
     .   : milestone, 735,
    master - mean (725ms)  : 709, 740
     .   : milestone, 725,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6192) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6192) - mean (1,223ms)  : 1195, 1252
     .   : milestone, 1223,
    master - mean (1,218ms)  : 1193, 1244
     .   : milestone, 1218,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6192) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6192) - mean (952ms)  : 935, 969
     .   : milestone, 952,
    master - mean (944ms)  : 928, 960
     .   : milestone, 944,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6192) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6192) - mean (936ms)  : 917, 955
     .   : milestone, 936,
    master - mean (927ms)  : 907, 947
     .   : milestone, 927,

andrewlock · 2024-10-24T06:50:37Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6192) (11.259M)   : 0, 11258817
    master (11.092M)   : 0, 11092190
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6192) (7.298M)   : 0, 7297687
    master (7.315M)   : 0, 7314582
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.630M)   : 0, 7629946

    section Manual
    master (11.027M)   : 0, 11026584

    section Manual + Automatic
    This PR (6192) (6.786M)   : 0, 6786331
    master (6.813M)   : 0, 6813328

    section DD_TRACE_ENABLED=0
    master (10.150M)   : 0, 10150076

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6192) (9.613M)   : 0, 9612735
    master (9.560M)   : 0, 9559953
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6192) (6.565M)   : 0, 6564648
    master (6.378M)   : 0, 6377870

    section Trace stats
    master (6.751M)   : 0, 6751094

    section Manual
    master (9.498M)   : 0, 9497984

    section Manual + Automatic
    This PR (6192) (6.006M)   : 0, 6006469
    master (5.967M)   : 0, 5966547

    section DD_TRACE_ENABLED=0
    master (8.995M)   : 0, 8994981

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6192) (9.973M)   : 0, 9972523
    master (10.347M)   : 0, 10347441
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6192) (6.478M)   : 0, 6477870
    master (6.779M)   : 0, 6779281
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.590M)   : 0, 7590179

    section Manual
    master (10.414M)   : 0, 10413511

    section Manual + Automatic
    This PR (6192) (6.208M)   : 0, 6208110
    master (5.506M)   : 0, 5506075

    section DD_TRACE_ENABLED=0
    master (9.537M)   : 0, 9537294

tracer/build/_build/UpdateVendors/VendoredDependency.cs

tracer/src/Datadog.Trace/Logging/TracerFlare/DebugLogReader.cs

lucaspimentel · 2024-10-24T13:51:01Z

tracer/src/Datadog.Trace/Datadog.Trace.csproj

@@ -38,7 +38,6 @@
  <ItemGroup Condition=" $(TargetFramework.StartsWith('net4')) ">
    <Reference Include="System.Configuration" />
    <Reference Include="System.Web" />
-    <Reference Include="System.IO.Compression" />


…ild, since this package can be consumed by applications with the out-of-band System.IO.Compression NuGet package Details: - Vendor in SharpZipLib v1.3.3 (MIT License) - Remove AssemblyReference to System.IO.Compression - Update Datadog.Trace.Logging.TracerFlare.DebugLogReader to use SharpZipLib instead of System.IO.Compression.ZipArchive - Update Datadog.Trace.Trimming.xml Root Descriptors File - Update snapshot tests that assert Datadog.Trace assembly references

andrewlock · 2024-10-24T18:19:32Z

Benchmarks Report for tracer 🐌

Benchmarks for #6192 compared to master:

3 benchmarks are faster, with geometric mean 1.171
1 benchmarks are slower, with geometric mean 1.145
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.99μs	44.6ns	306ns	0.0124	0.00413	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	55.7ns	348ns	0.0193	0.00964	0	5.8 KB
master	`StartStopWithChild`	net472	16.3μs	51.8ns	200ns	1.04	0.303	0.0984	6.21 KB
#6192	`StartStopWithChild`	net6.0	7.82μs	43.7ns	280ns	0.0159	0.00797	0	5.61 KB
#6192	`StartStopWithChild`	netcoreapp3.1	9.8μs	47.1ns	194ns	0.0194	0.00969	0	5.81 KB
#6192	`StartStopWithChild`	net472	16.3μs	43.6ns	163ns	1.04	0.3	0.0891	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	489μs	468ns	1.75μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	255ns	986ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	839μs	500ns	1.93μs	0.419	3.3 KB
#6192	`WriteAndFlushEnrichedTraces`	net6.0	472μs	276ns	1.07μs	0	2.7 KB
#6192	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	312ns	1.21μs	0	2.7 KB
#6192	`WriteAndFlushEnrichedTraces`	net472	839μs	362ns	1.4μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	203μs	1.18μs	9.8μs	0.194	18.73 KB
master	`SendRequest`	netcoreapp3.1	226μs	1.3μs	10.3μs	0.216	20.89 KB
master	`SendRequest`	net472	0.00038ns	0.000225ns	0.000841ns	0	0 b
#6192	`SendRequest`	net6.0	202μs	1.16μs	9.5μs	0.201	18.73 KB
#6192	`SendRequest`	netcoreapp3.1	223μs	1.26μs	8.63μs	0.22	20.89 KB
#6192	`SendRequest`	net472	1.19E‑05ns	1.19E‑05ns	4.46E‑05ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6192

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.56 KB	41.8 KB	240 B	0.58%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	561μs	1.87μs	7μs	0.546	0	0	41.56 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	693μs	3.51μs	16.1μs	0.342	0	0	41.78 KB
master	`WriteAndFlushEnrichedTraces`	net472	870μs	2.7μs	10.5μs	8.08	2.55	0.425	53.35 KB
#6192	`WriteAndFlushEnrichedTraces`	net6.0	561μs	2.38μs	8.89μs	0.581	0	0	41.8 KB
#6192	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	683μs	3.26μs	15.3μs	0.338	0	0	41.73 KB
#6192	`WriteAndFlushEnrichedTraces`	net472	878μs	4.08μs	15.8μs	8.3	2.62	0.437	53.31 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.38μs	1.33ns	4.78ns	0.0144	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.72μs	1.45ns	5.44ns	0.0134	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	1.52ns	5.68ns	0.156	0.00105	987 B
#6192	`ExecuteNonQuery`	net6.0	1.29μs	0.86ns	3.33ns	0.0145	0	1.02 KB
#6192	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	0.922ns	3.32ns	0.0133	0	1.02 KB
#6192	`ExecuteNonQuery`	net472	2.13μs	1.76ns	6.83ns	0.156	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.37μs	1.93ns	7.48ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.541ns	1.95ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.51μs	1.83ns	7.11ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.44μs	0.643ns	2.49ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.695ns	2.6ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.54μs	0.708ns	2.74ns	0.167	1.05 KB
#6192	`CallElasticsearch`	net6.0	1.25μs	0.7ns	2.62ns	0.0138	976 B
#6192	`CallElasticsearch`	netcoreapp3.1	1.5μs	4.43ns	17.1ns	0.0134	976 B
#6192	`CallElasticsearch`	net472	2.58μs	1.54ns	5.96ns	0.157	995 B
#6192	`CallElasticsearchAsync`	net6.0	1.34μs	0.765ns	2.86ns	0.0133	952 B
#6192	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.483ns	1.81ns	0.0137	1.02 KB
#6192	`CallElasticsearchAsync`	net472	2.6μs	1.15ns	4.14ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6192

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.145	1,132.20	1,296.92

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.13μs	0.481ns	1.86ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.376ns	1.3ns	0.0124	952 B
master	`ExecuteAsync`	net472	1.79μs	1.6ns	5.54ns	0.145	915 B
#6192	`ExecuteAsync`	net6.0	1.3μs	0.552ns	2.14ns	0.0131	952 B
#6192	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.465ns	1.74ns	0.0131	952 B
#6192	`ExecuteAsync`	net472	1.79μs	0.55ns	2.06ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.41μs	2.68ns	10ns	0.0329	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.27μs	1.8ns	6.74ns	0.037	2.85 KB
master	`SendAsync`	net472	7.42μs	3.7ns	13.8ns	0.493	3.12 KB
#6192	`SendAsync`	net6.0	4.42μs	1.85ns	6.66ns	0.031	2.31 KB
#6192	`SendAsync`	netcoreapp3.1	5.26μs	1.11ns	4.02ns	0.0393	2.85 KB
#6192	`SendAsync`	net472	7.39μs	1.72ns	6.44ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.59μs	5.07ns	19.6ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.14μs	1.24ns	4.81ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.48μs	1.68ns	6.51ns	0.25	1.57 KB
#6192	`EnrichedLog`	net6.0	1.63μs	0.716ns	2.77ns	0.0226	1.64 KB
#6192	`EnrichedLog`	netcoreapp3.1	2.37μs	0.667ns	2.5ns	0.0225	1.64 KB
#6192	`EnrichedLog`	net472	2.52μs	1.14ns	4.11ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	174ns	675ns	0.0601	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	191ns	741ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	210ns	787ns	0.678	0.226	4.46 KB
#6192	`EnrichedLog`	net6.0	117μs	161ns	625ns	0	0	4.28 KB
#6192	`EnrichedLog`	netcoreapp3.1	121μs	164ns	591ns	0.0606	0	4.28 KB
#6192	`EnrichedLog`	net472	151μs	153ns	591ns	0.685	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.16μs	0.709ns	2.75ns	0.0316	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.13μs	0.543ns	1.96ns	0.0308	2.2 KB
master	`EnrichedLog`	net472	4.94μs	1.55ns	5.99ns	0.319	2.02 KB
#6192	`EnrichedLog`	net6.0	3.14μs	0.848ns	3.28ns	0.0299	2.2 KB
#6192	`EnrichedLog`	netcoreapp3.1	4.07μs	0.878ns	3.4ns	0.0288	2.2 KB
#6192	`EnrichedLog`	net472	4.8μs	1.34ns	5.18ns	0.318	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.33μs	0.356ns	1.33ns	0.0159	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.72μs	0.584ns	2.11ns	0.0146	1.14 KB
master	`SendReceive`	net472	2.05μs	0.847ns	3.06ns	0.184	1.16 KB
#6192	`SendReceive`	net6.0	1.35μs	0.746ns	2.89ns	0.0159	1.14 KB
#6192	`SendReceive`	netcoreapp3.1	1.74μs	1.38ns	5.35ns	0.0149	1.14 KB
#6192	`SendReceive`	net472	2.07μs	0.516ns	1.86ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.74μs	1.15ns	4.46ns	0.0218	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.94μs	2.75ns	10.3ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.46μs	2.48ns	9.27ns	0.322	2.04 KB
#6192	`EnrichedLog`	net6.0	2.75μs	0.75ns	2.7ns	0.022	1.6 KB
#6192	`EnrichedLog`	netcoreapp3.1	3.99μs	1.29ns	4.99ns	0.022	1.65 KB
#6192	`EnrichedLog`	net472	4.41μs	2.83ns	11ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6192

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.200	473.26	394.26
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.185	667.15	562.77

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	473ns	0.421ns	1.57ns	0.0081	576 B
master	`StartFinishSpan`	netcoreapp3.1	664ns	2.41ns	9.32ns	0.0075	576 B
master	`StartFinishSpan`	net472	720ns	0.797ns	3.09ns	0.0915	578 B
master	`StartFinishScope`	net6.0	522ns	0.457ns	1.77ns	0.00978	696 B
master	`StartFinishScope`	netcoreapp3.1	765ns	0.641ns	2.48ns	0.00916	696 B
master	`StartFinishScope`	net472	906ns	0.849ns	3.29ns	0.104	658 B
#6192	`StartFinishSpan`	net6.0	394ns	0.204ns	0.79ns	0.00811	576 B
#6192	`StartFinishSpan`	netcoreapp3.1	563ns	0.251ns	0.94ns	0.00759	576 B
#6192	`StartFinishSpan`	net472	738ns	1.29ns	5ns	0.0915	578 B
#6192	`StartFinishScope`	net6.0	531ns	0.452ns	1.75ns	0.0097	696 B
#6192	`StartFinishScope`	netcoreapp3.1	696ns	0.667ns	2.58ns	0.00915	696 B
#6192	`StartFinishScope`	net472	905ns	1.14ns	4.41ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6192

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.128	730.85	647.90

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	731ns	0.424ns	1.59ns	0.00951	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	977ns	1.19ns	4.59ns	0.00928	696 B
master	`RunOnMethodBegin`	net472	1.15μs	1.61ns	6.23ns	0.104	658 B
#6192	`RunOnMethodBegin`	net6.0	647ns	0.407ns	1.47ns	0.00965	696 B
#6192	`RunOnMethodBegin`	netcoreapp3.1	880ns	0.951ns	3.68ns	0.00937	696 B
#6192	`RunOnMethodBegin`	net472	1.15μs	1.88ns	7.27ns	0.105	658 B

…r .NET Framework build of Datadog.Trace. This means there is no difference in behavior for other builds of Datadog.Trace.

andrewlock

LGTM, thanks!

lucaspimentel · 2024-11-06T17:35:00Z

.../Snapshots/PublicApiTests.Datadog.Trace.AssemblyReferencesHaveNotChanged.net461.verified.txt

@@ -3,7 +3,6 @@ System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
 System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
 System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
 System.Data, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
-System.IO.Compression, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089


…yption mode, which we don't even use.

github-advanced-security bot found potential problems Oct 24, 2024

View reviewed changes

tracer/src/Datadog.Trace/Vendors/ICSharpCode.SharpZipLib/Encryption/ZipAESTransform.cs Fixed Show resolved Hide resolved

andrewlock reviewed Oct 24, 2024

View reviewed changes

tracer/build/_build/UpdateVendors/VendoredDependency.cs Outdated Show resolved Hide resolved

tracer/src/Datadog.Trace/Logging/TracerFlare/DebugLogReader.cs Outdated Show resolved Hide resolved

lucaspimentel reviewed Oct 24, 2024

View reviewed changes

zacharycmontoya force-pushed the zach.montoya/fix-compression-lib branch from b0e0e9e to 89f01c0 Compare October 24, 2024 16:57

Update changes so that we only vendor SharpZipLib (and use it) for ou…

59971aa

…r .NET Framework build of Datadog.Trace. This means there is no difference in behavior for other builds of Datadog.Trace.

zacharycmontoya force-pushed the zach.montoya/fix-compression-lib branch from 4ed1784 to 59971aa Compare October 24, 2024 22:03

andrewlock approved these changes Oct 29, 2024

View reviewed changes

zacharycmontoya marked this pull request as ready for review November 6, 2024 17:27

zacharycmontoya requested review from a team as code owners November 6, 2024 17:27

Merge branch 'master' into zach.montoya/fix-compression-lib

5b65b5b

zacharycmontoya changed the title ~~Proposed fix: Remove dependency on System.IO.Compression for .NET Framework ild~~ Proposed fix: Remove dependency on System.IO.Compression for .NET Framework build Nov 6, 2024

lucaspimentel reviewed Nov 6, 2024

View reviewed changes

lucaspimentel approved these changes Nov 6, 2024

View reviewed changes

Manually vendor ZipAESTransform.cs to remove usage of vulnerable encr…

e01f1b5

…yption mode, which we don't even use.

zacharycmontoya merged commit 0f95b89 into master Nov 11, 2024
75 of 77 checks passed

zacharycmontoya deleted the zach.montoya/fix-compression-lib branch November 11, 2024 16:30

github-actions bot added this to the vNext-v3 milestone Nov 11, 2024

andrewlock added type:bug area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) dependencies Pull requests that update a dependency file labels Nov 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposed fix: Remove dependency on System.IO.Compression for .NET Framework build #6192

Proposed fix: Remove dependency on System.IO.Compression for .NET Framework build #6192

zacharycmontoya commented Oct 24, 2024

datadog-ddstaging bot commented Oct 24, 2024 •

edited

Loading

andrewlock commented Oct 24, 2024 •

edited

Loading

andrewlock commented Oct 24, 2024 •

edited

Loading

lucaspimentel Oct 24, 2024

andrewlock commented Oct 24, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #6192

Raw results

Raw results

Raw results

Slower ⚠️ in #6192

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6192

Raw results

Faster 🎉 in #6192

Raw results

andrewlock left a comment

lucaspimentel Nov 6, 2024

Proposed fix: Remove dependency on System.IO.Compression for .NET Framework build #6192

Proposed fix: Remove dependency on System.IO.Compression for .NET Framework build #6192

Conversation

zacharycmontoya commented Oct 24, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Oct 24, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 24, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 24, 2024 • edited Loading

Throughput/Crank Report ⚡

lucaspimentel Oct 24, 2024

Choose a reason for hiding this comment

andrewlock commented Oct 24, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6192

Raw results

Raw results

Raw results

Slower ⚠️ in #6192

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6192

Raw results

Faster 🎉 in #6192

Raw results

andrewlock left a comment

Choose a reason for hiding this comment

lucaspimentel Nov 6, 2024

Choose a reason for hiding this comment

datadog-ddstaging bot commented Oct 24, 2024 •

edited

Loading

andrewlock commented Oct 24, 2024 •

edited

Loading

andrewlock commented Oct 24, 2024 •

edited

Loading

andrewlock commented Oct 24, 2024 •

edited

Loading