Make DD_TRACE_<INTEGRATION>_ENABLED Case Insensitive #6175

link04 · 2024-10-21T15:17:56Z

Summary of changes

Added a option to check for upper cased integration names and moved the case sensitive option as fallback 1.

Reason for change

Currently for Linux DD_TRACE_<INTEGRATION>_ENABLED needs to have an integration name that matches the name's casing on the existing dictionary we check but need to make it case insensitive like all other languages:

https://datadoghq.atlassian.net/browse/APMAPI-476

Implementation details

Test coverage

Other details

datadog-ddstaging · 2024-10-21T15:39:50Z

Datadog Report

Branch report: maximo/consistent-integrations-enabled-casing
Commit report: 3bc695e
Test service: dd-trace-dotnet

✅ 0 Failed, 369396 Passed, 2087 Skipped, 15h 4m 19.8s Total Time

andrewlock · 2024-10-21T15:51:45Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6175) - mean (71ms)  : 68, 73
     .   : milestone, 71,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6175) - mean (1,117ms)  : 1096, 1139
     .   : milestone, 1117,
    master - mean (1,117ms)  : 1095, 1139
     .   : milestone, 1117,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6175) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (111ms)  : 107, 114
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (6175) - mean (777ms)  : 763, 791
     .   : milestone, 777,
    master - mean (777ms)  : 762, 791
     .   : milestone, 777,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6175) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6175) - mean (734ms)  : 713, 755
     .   : milestone, 734,
    master - mean (734ms)  : 717, 751
     .   : milestone, 734,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6175) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6175) - mean (1,208ms)  : 1178, 1238
     .   : milestone, 1208,
    master - mean (1,204ms)  : 1177, 1232
     .   : milestone, 1204,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6175) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (275ms)  : 270, 281
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6175) - mean (950ms)  : 935, 965
     .   : milestone, 950,
    master - mean (948ms)  : 927, 969
     .   : milestone, 948,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6175) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6175) - mean (926ms)  : 906, 946
     .   : milestone, 926,
    master - mean (929ms)  : 912, 946
     .   : milestone, 929,

andrewlock · 2024-10-21T18:53:40Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6175) (11.175M)   : 0, 11174514
    master (11.239M)   : 0, 11238698
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6175) (7.290M)   : 0, 7290358
    master (7.276M)   : 0, 7276283
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.623M)   : 0, 7622719

    section Manual
    master (11.047M)   : 0, 11046529

    section Manual + Automatic
    This PR (6175) (6.836M)   : 0, 6836200
    master (6.860M)   : 0, 6859678

    section DD_TRACE_ENABLED=0
    master (10.213M)   : 0, 10212915

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6175) (9.538M)   : 0, 9538099
    master (9.437M)   : 0, 9436619
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6175) (6.425M)   : 0, 6425356
    master (6.727M)   : 0, 6727464

    section Trace stats
    master (6.723M)   : 0, 6723131

    section Manual
    master (9.372M)   : 0, 9371618

    section Manual + Automatic
    This PR (6175) (6.038M)   : 0, 6038035
    master (6.063M)   : 0, 6063264

    section DD_TRACE_ENABLED=0
    master (8.797M)   : 0, 8796790

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6175) (10.151M)   : 0, 10150797
    master (10.059M)   : 0, 10059432
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6175) (6.635M)   : 0, 6635381
    master (6.455M)   : 0, 6454669
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.193M)   : 0, 7192976

    section Manual
    master (9.914M)   : 0, 9914007

    section Manual + Automatic
    This PR (6175) (6.382M)   : 0, 6382026
    master (6.023M)   : 0, 6022873

    section DD_TRACE_ENABLED=0
    master (9.155M)   : 0, 9155421

andrewlock · 2024-10-22T00:57:03Z

Benchmarks Report for tracer 🐌

Benchmarks for #6175 compared to master:

2 benchmarks are faster, with geometric mean 1.114
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.7μs	44.5ns	378ns	0.0151	0.00756	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.91μs	54.8ns	338ns	0.0196	0.00979	0	5.61 KB
master	`StartStopWithChild`	net472	16.4μs	58.8ns	228ns	1	0.3	0.081	6.06 KB
#6175	`StartStopWithChild`	net6.0	7.88μs	44.8ns	314ns	0.0188	0.00752	0	5.43 KB
#6175	`StartStopWithChild`	netcoreapp3.1	9.68μs	48.5ns	233ns	0.0242	0.00968	0	5.62 KB
#6175	`StartStopWithChild`	net472	16.1μs	38.5ns	144ns	1.02	0.32	0.104	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	492μs	477ns	1.85μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	660μs	300ns	1.12μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	838μs	611ns	2.28μs	0.417	3.3 KB
#6175	`WriteAndFlushEnrichedTraces`	net6.0	489μs	410ns	1.54μs	0	2.7 KB
#6175	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	660μs	278ns	1.04μs	0	2.7 KB
#6175	`WriteAndFlushEnrichedTraces`	net472	844μs	424ns	1.64μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	214μs	1.25μs	12.1μs	0.218	18.45 KB
master	`SendRequest`	netcoreapp3.1	241μs	1.37μs	10.5μs	0.236	20.61 KB
master	`SendRequest`	net472	0.00301ns	0.0011ns	0.00426ns	0	0 b
#6175	`SendRequest`	net6.0	207μs	1.19μs	9.99μs	0.217	18.45 KB
#6175	`SendRequest`	netcoreapp3.1	238μs	1.34μs	12.2μs	0.243	20.61 KB
#6175	`SendRequest`	net472	0.00118ns	0.000469ns	0.00182ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	616μs	3.53μs	25.4μs	0.625	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	745μs	3.82μs	19.1μs	0.342	0	0	41.77 KB
master	`WriteAndFlushEnrichedTraces`	net472	926μs	4.67μs	20.4μs	8.4	2.33	0.466	53.33 KB
#6175	`WriteAndFlushEnrichedTraces`	net6.0	593μs	2.45μs	8.82μs	0.595	0	0	41.57 KB
#6175	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	674μs	3.39μs	16.3μs	0.343	0	0	41.68 KB
#6175	`WriteAndFlushEnrichedTraces`	net472	901μs	3.77μs	13.6μs	8.36	2.64	0.44	53.34 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.3μs	1.29ns	4.98ns	0.0143	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	5.81ns	21ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.09μs	1.33ns	5.16ns	0.156	0.00105	987 B
#6175	`ExecuteNonQuery`	net6.0	1.37μs	1.43ns	5.55ns	0.0143	0	1.02 KB
#6175	`ExecuteNonQuery`	netcoreapp3.1	1.71μs	1.79ns	6.93ns	0.0138	0	1.02 KB
#6175	`ExecuteNonQuery`	net472	2.04μs	2.57ns	9.97ns	0.156	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.299ns	1.16ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.44μs	0.845ns	3.16ns	0.0131	976 B
master	`CallElasticsearch`	net472	2.59μs	2.03ns	7.85ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.38μs	0.775ns	2.9ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.52μs	0.687ns	2.48ns	0.0138	1.02 KB
master	`CallElasticsearchAsync`	net472	2.58μs	1.61ns	6.24ns	0.167	1.05 KB
#6175	`CallElasticsearch`	net6.0	1.25μs	0.932ns	3.61ns	0.0137	976 B
#6175	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.491ns	1.9ns	0.0133	976 B
#6175	`CallElasticsearch`	net472	2.51μs	0.97ns	3.76ns	0.157	995 B
#6175	`CallElasticsearchAsync`	net6.0	1.27μs	0.316ns	1.18ns	0.0133	952 B
#6175	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.719ns	2.59ns	0.0138	1.02 KB
#6175	`CallElasticsearchAsync`	net472	2.64μs	1.92ns	7.42ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6175

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.114	1,340.15	1,202.80

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.467ns	1.81ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.58μs	0.606ns	2.27ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.75μs	0.676ns	2.62ns	0.145	915 B
#6175	`ExecuteAsync`	net6.0	1.2μs	0.828ns	3.1ns	0.0132	952 B
#6175	`ExecuteAsync`	netcoreapp3.1	1.57μs	1.83ns	7.07ns	0.0125	952 B
#6175	`ExecuteAsync`	net472	1.71μs	0.598ns	2.24ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.15μs	2.43ns	9.1ns	0.031	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.17μs	3.02ns	11.7ns	0.0362	2.76 KB
master	`SendAsync`	net472	7.2μs	2.05ns	7.95ns	0.486	3.07 KB
#6175	`SendAsync`	net6.0	4.31μs	2.14ns	8.01ns	0.0304	2.22 KB
#6175	`SendAsync`	netcoreapp3.1	5.17μs	3.76ns	13.5ns	0.0363	2.76 KB
#6175	`SendAsync`	net472	7.23μs	1.55ns	6ns	0.487	3.07 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.52μs	0.828ns	3.1ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.23μs	1ns	3.76ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.57μs	1ns	3.75ns	0.249	1.57 KB
#6175	`EnrichedLog`	net6.0	1.52μs	2.16ns	8.09ns	0.0229	1.64 KB
#6175	`EnrichedLog`	netcoreapp3.1	2.15μs	1.48ns	5.32ns	0.0225	1.64 KB
#6175	`EnrichedLog`	net472	2.46μs	1.69ns	6.56ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	267ns	1.04μs	0.0573	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	206ns	799ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	209ns	811ns	0.681	0.227	4.46 KB
#6175	`EnrichedLog`	net6.0	117μs	125ns	468ns	0	0	4.28 KB
#6175	`EnrichedLog`	netcoreapp3.1	121μs	280ns	1.05μs	0	0	4.28 KB
#6175	`EnrichedLog`	net472	153μs	245ns	948ns	0.682	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.14μs	0.991ns	3.84ns	0.0298	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.12μs	1.39ns	5.2ns	0.0292	2.2 KB
master	`EnrichedLog`	net472	4.84μs	0.87ns	3.37ns	0.319	2.02 KB
#6175	`EnrichedLog`	net6.0	3.12μs	0.979ns	3.66ns	0.0313	2.2 KB
#6175	`EnrichedLog`	netcoreapp3.1	4.12μs	1.04ns	3.9ns	0.0289	2.2 KB
#6175	`EnrichedLog`	net472	4.86μs	2.3ns	8.61ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.35μs	1.05ns	4.06ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.68μs	1.36ns	5.28ns	0.0156	1.14 KB
master	`SendReceive`	net472	2.13μs	5.19ns	20.1ns	0.183	1.16 KB
#6175	`SendReceive`	net6.0	1.35μs	0.629ns	2.18ns	0.0161	1.14 KB
#6175	`SendReceive`	netcoreapp3.1	1.68μs	3.07ns	11.5ns	0.0152	1.14 KB
#6175	`SendReceive`	net472	2.09μs	2.88ns	10.4ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.7μs	0.668ns	2.59ns	0.0215	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.95μs	2.14ns	7.4ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.49μs	3.45ns	13.4ns	0.323	2.04 KB
#6175	`EnrichedLog`	net6.0	2.75μs	0.746ns	2.89ns	0.022	1.6 KB
#6175	`EnrichedLog`	netcoreapp3.1	3.9μs	4.14ns	16ns	0.0215	1.65 KB
#6175	`EnrichedLog`	net472	4.32μs	1.91ns	7.16ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6175

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.114	640.48	574.84

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	409ns	0.119ns	0.462ns	0.00802	576 B
master	`StartFinishSpan`	netcoreapp3.1	640ns	0.468ns	1.69ns	0.0078	576 B
master	`StartFinishSpan`	net472	685ns	0.272ns	1.05ns	0.0915	578 B
master	`StartFinishScope`	net6.0	484ns	0.133ns	0.514ns	0.00974	696 B
master	`StartFinishScope`	netcoreapp3.1	675ns	1.26ns	4.88ns	0.00944	696 B
master	`StartFinishScope`	net472	872ns	0.775ns	3ns	0.105	658 B
#6175	`StartFinishSpan`	net6.0	410ns	0.149ns	0.559ns	0.00797	576 B
#6175	`StartFinishSpan`	netcoreapp3.1	575ns	0.288ns	1.12ns	0.00759	576 B
#6175	`StartFinishSpan`	net472	684ns	0.268ns	1.04ns	0.0915	578 B
#6175	`StartFinishScope`	net6.0	486ns	0.417ns	1.61ns	0.00978	696 B
#6175	`StartFinishScope`	netcoreapp3.1	702ns	0.569ns	2.2ns	0.00939	696 B
#6175	`StartFinishScope`	net472	899ns	1.19ns	4.61ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	644ns	0.279ns	1.08ns	0.00974	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	983ns	0.62ns	2.4ns	0.00934	696 B
master	`RunOnMethodBegin`	net472	1.17μs	0.278ns	1.08ns	0.104	658 B
#6175	`RunOnMethodBegin`	net6.0	581ns	0.21ns	0.786ns	0.00977	696 B
#6175	`RunOnMethodBegin`	netcoreapp3.1	994ns	0.455ns	1.76ns	0.00898	696 B
#6175	`RunOnMethodBegin`	net472	1.1μs	0.306ns	1.18ns	0.104	658 B

tracer/test/Datadog.Trace.Tests/Configuration/IntegrationSettingsTests.cs

lucaspimentel · 2024-10-31T18:17:01Z

tracer/src/Datadog.Trace/Configuration/IntegrationSettings.cs

@@ -49,6 +49,7 @@ internal IntegrationSettings(string integrationName, IConfigurationSource? sourc
            var config = new ConfigurationBuilder(source, NullConfigurationTelemetry.Instance);
            EnabledInternal = config
                     .WithKeys(
+                          string.Format(ConfigurationKeys.Integrations.Enabled, integrationName.ToUpperInvariant()),


nice 👍🏽

…ngsTests.cs Co-authored-by: Lucas Pimentel <[email protected]>

Looking for upper cased integration name

41105a6

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 21, 2024

Updated based on recommendation and added test

6be69b3

link04 marked this pull request as ready for review October 22, 2024 21:34

link04 requested a review from a team as a code owner October 22, 2024 21:34

zacharycmontoya reviewed Oct 29, 2024

View reviewed changes

tracer/test/Datadog.Trace.Tests/Configuration/IntegrationSettingsTests.cs Outdated Show resolved Hide resolved

Update test based on comment

51d9973

zacharycmontoya approved these changes Oct 31, 2024

View reviewed changes

lucaspimentel reviewed Oct 31, 2024

View reviewed changes

tracer/test/Datadog.Trace.Tests/Configuration/IntegrationSettingsTests.cs Show resolved Hide resolved

lucaspimentel reviewed Oct 31, 2024

View reviewed changes

lucaspimentel approved these changes Oct 31, 2024

View reviewed changes

Update tracer/test/Datadog.Trace.Tests/Configuration/IntegrationSetti…

3bc695e

…ngsTests.cs Co-authored-by: Lucas Pimentel <[email protected]>

link04 merged commit 2eb04ff into master Nov 1, 2024
73 of 74 checks passed

link04 deleted the maximo/consistent-integrations-enabled-casing branch November 1, 2024 04:55

github-actions bot added this to the vNext-v3 milestone Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make DD_TRACE_<INTEGRATION>_ENABLED Case Insensitive #6175

Make DD_TRACE_<INTEGRATION>_ENABLED Case Insensitive #6175

link04 commented Oct 21, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 21, 2024 •

edited

Loading

andrewlock commented Oct 21, 2024 •

edited

Loading

andrewlock commented Oct 21, 2024 •

edited

Loading

andrewlock commented Oct 22, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6175

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6175

Raw results

Raw results

lucaspimentel Oct 31, 2024

Make DD_TRACE_<INTEGRATION>_ENABLED Case Insensitive #6175

Make DD_TRACE_<INTEGRATION>_ENABLED Case Insensitive #6175

Conversation

link04 commented Oct 21, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Oct 21, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 21, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 21, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Oct 22, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6175

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6175

Raw results

Raw results

lucaspimentel Oct 31, 2024

Choose a reason for hiding this comment

link04 commented Oct 21, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 21, 2024 •

edited

Loading

andrewlock commented Oct 21, 2024 •

edited

Loading

andrewlock commented Oct 21, 2024 •

edited

Loading

andrewlock commented Oct 22, 2024 •

edited

Loading