[ASM] Update WAF version to 1.20.1 #6174

NachoEchevarria · 2024-10-21T13:59:53Z

Summary of changes

This PR updates the WAF to its latest version.

This version corrects some issues related to Rasp's Lfi vulnerability and adds some ShellI features.

Reason for change

Implementation details

Test coverage

Other details

github-actions · 2024-10-21T14:00:38Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

-        "_dd.appsec.waf.version": "1.20.0",
+        "_dd.appsec.waf.version": "1.20.1",

8 occurrences of :

-      _dd.appsec.waf.version: 1.20.0,
+      _dd.appsec.waf.version: 1.20.1,

datadog-ddstaging · 2024-10-21T14:22:33Z

Datadog Report

Branch report: nacho/UpdateWafVersion1.20.1
Commit report: aac6a00
Test service: dd-trace-dotnet

✅ 0 Failed, 364815 Passed, 2092 Skipped, 15h 8m 56.5s Total Time

andrewlock · 2024-10-22T09:25:47Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6174) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6174) - mean (1,115ms)  : 1090, 1140
     .   : milestone, 1115,
    master - mean (1,108ms)  : 1087, 1128
     .   : milestone, 1108,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6174) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6174) - mean (771ms)  : 757, 786
     .   : milestone, 771,
    master - mean (775ms)  : 757, 794
     .   : milestone, 775,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6174) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6174) - mean (728ms)  : 705, 751
     .   : milestone, 728,
    master - mean (726ms)  : 712, 740
     .   : milestone, 726,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6174) - mean (191ms)  : 187, 194
     .   : milestone, 191,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6174) - mean (1,210ms)  : 1178, 1242
     .   : milestone, 1210,
    master - mean (1,199ms)  : 1173, 1224
     .   : milestone, 1199,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6174) - mean (275ms)  : 271, 279
     .   : milestone, 275,
    master - mean (276ms)  : 272, 279
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6174) - mean (945ms)  : 924, 967
     .   : milestone, 945,
    master - mean (943ms)  : 927, 960
     .   : milestone, 943,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6174) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6174) - mean (926ms)  : 907, 945
     .   : milestone, 926,
    master - mean (931ms)  : 914, 948
     .   : milestone, 931,

andrewlock · 2024-10-22T09:51:14Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6174) (10.944M)   : 0, 10944455
    master (11.119M)   : 0, 11118546
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6174) (7.390M)   : 0, 7390126
    master (7.321M)   : 0, 7321152
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.757M)   : 0, 7756918

    section Manual
    master (11.210M)   : 0, 11209846

    section Manual + Automatic
    This PR (6174) (6.813M)   : 0, 6812513
    master (6.740M)   : 0, 6740459

    section DD_TRACE_ENABLED=0
    master (10.109M)   : 0, 10109349

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6174) (9.746M)   : 0, 9745518
    master (9.561M)   : 0, 9560673
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6174) (6.689M)   : 0, 6688598
    master (6.578M)   : 0, 6578194

    section Trace stats
    master (6.868M)   : 0, 6867545

    section Manual
    master (9.568M)   : 0, 9568124

    section Manual + Automatic
    This PR (6174) (6.137M)   : 0, 6137325
    master (6.203M)   : 0, 6203435

    section DD_TRACE_ENABLED=0
    master (8.858M)   : 0, 8857806

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6174) (9.919M)   : 0, 9918782
    master (9.889M)   : 0, 9889232
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6174) (6.437M)   : 0, 6436646
    master (6.396M)   : 0, 6396160
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.205M)   : 0, 7205159

    section Manual
    master (9.853M)   : 0, 9852595

    section Manual + Automatic
    This PR (6174) (5.947M)   : 0, 5947445
    master (5.939M)   : 0, 5939480

    section DD_TRACE_ENABLED=0
    master (9.222M)   : 0, 9221606

andrewlock · 2024-10-22T10:12:47Z

Benchmarks Report for tracer 🐌

Benchmarks for #6174 compared to master:

1 benchmarks are faster, with geometric mean 1.156
1 benchmarks are slower, with geometric mean 1.180
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.8μs	43.4ns	310ns	0.0152	0.00758	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.86μs	54.5ns	318ns	0.0242	0.00968	0	5.61 KB
master	`StartStopWithChild`	net472	16.1μs	59ns	228ns	1.02	0.311	0.0957	6.06 KB
#6174	`StartStopWithChild`	net6.0	7.53μs	42.6ns	301ns	0.0194	0.00776	0	5.42 KB
#6174	`StartStopWithChild`	netcoreapp3.1	9.88μs	54.5ns	349ns	0.0242	0.0145	0.00484	5.62 KB
#6174	`StartStopWithChild`	net472	16.2μs	35.5ns	137ns	1.03	0.321	0.0883	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	478μs	127ns	459ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	493ns	1.91μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	837μs	387ns	1.45μs	0.422	3.3 KB
#6174	`WriteAndFlushEnrichedTraces`	net6.0	469μs	126ns	470ns	0	2.7 KB
#6174	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	645μs	355ns	1.37μs	0	2.7 KB
#6174	`WriteAndFlushEnrichedTraces`	net472	842μs	714ns	2.76μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	206μs	1.55μs	15.5μs	0.212	18.45 KB
master	`SendRequest`	netcoreapp3.1	231μs	1.35μs	12.6μs	0.216	20.61 KB
master	`SendRequest`	net472	0.000903ns	0.000508ns	0.00197ns	0	0 b
#6174	`SendRequest`	net6.0	214μs	1.22μs	9.44μs	0.198	18.45 KB
#6174	`SendRequest`	netcoreapp3.1	223μs	1.29μs	10.3μs	0.204	20.61 KB
#6174	`SendRequest`	net472	0.000706ns	0.000411ns	0.00154ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6174

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.49 KB	41.84 KB	349 B	0.84%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	598μs	3.4μs	23.6μs	0.563	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	767μs	4.24μs	26.2μs	0.383	0	0	41.49 KB
master	`WriteAndFlushEnrichedTraces`	net472	875μs	2.76μs	10.3μs	8.33	2.31	0.463	53.34 KB
#6174	`WriteAndFlushEnrichedTraces`	net6.0	573μs	3.02μs	14.8μs	0.59	0	0	41.56 KB
#6174	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	685μs	3.48μs	16μs	0.334	0	0	41.84 KB
#6174	`WriteAndFlushEnrichedTraces`	net472	882μs	4.65μs	23.3μs	8.39	2.52	0.419	53.34 KB

Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6174

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.156	1,356.94	1,174.27

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.36μs	0.76ns	2.84ns	0.0143	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.54ns	5.76ns	0.0135	1.02 KB
master	`ExecuteNonQuery`	net472	2.12μs	1.71ns	6.61ns	0.157	987 B
#6174	`ExecuteNonQuery`	net6.0	1.18μs	1.48ns	5.75ns	0.0141	1.02 KB
#6174	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.12ns	4.17ns	0.0132	1.02 KB
#6174	`ExecuteNonQuery`	net472	2.1μs	2.43ns	9.42ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.19μs	2.91ns	11.3ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.59μs	0.604ns	2.26ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.59μs	1.14ns	4.4ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.3μs	0.557ns	2.16ns	0.0136	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.745ns	2.79ns	0.0141	1.02 KB
master	`CallElasticsearchAsync`	net472	2.47μs	1.53ns	5.94ns	0.167	1.05 KB
#6174	`CallElasticsearch`	net6.0	1.21μs	0.547ns	2.05ns	0.0133	976 B
#6174	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.68ns	2.45ns	0.0132	976 B
#6174	`CallElasticsearch`	net472	2.45μs	1ns	3.75ns	0.158	995 B
#6174	`CallElasticsearchAsync`	net6.0	1.2μs	0.417ns	1.56ns	0.0132	952 B
#6174	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.743ns	2.68ns	0.0139	1.02 KB
#6174	`CallElasticsearchAsync`	net472	2.68μs	0.882ns	3.42ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.38μs	1.03ns	3.99ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	1.8ns	6.74ns	0.0123	952 B
master	`ExecuteAsync`	net472	1.78μs	0.713ns	2.76ns	0.145	915 B
#6174	`ExecuteAsync`	net6.0	1.29μs	0.502ns	1.95ns	0.0135	952 B
#6174	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.98ns	3.8ns	0.0127	952 B
#6174	`ExecuteAsync`	net472	1.77μs	0.757ns	2.83ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.18μs	2.36ns	9.13ns	0.031	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.01μs	1.48ns	5.54ns	0.0378	2.76 KB
master	`SendAsync`	net472	7.91μs	1.26ns	4.72ns	0.498	3.15 KB
#6174	`SendAsync`	net6.0	4.27μs	1.08ns	4.19ns	0.03	2.22 KB
#6174	`SendAsync`	netcoreapp3.1	5.2μs	2.36ns	8.82ns	0.0365	2.76 KB
#6174	`SendAsync`	net472	7.83μs	14.6ns	54.7ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.51μs	0.841ns	3.03ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.2μs	1.81ns	6.75ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.68μs	1.03ns	3.98ns	0.249	1.57 KB
#6174	`EnrichedLog`	net6.0	1.44μs	0.861ns	3.33ns	0.0233	1.64 KB
#6174	`EnrichedLog`	netcoreapp3.1	2.3μs	1.11ns	4ns	0.0221	1.64 KB
#6174	`EnrichedLog`	net472	2.56μs	0.575ns	2.15ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	117μs	221ns	856ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	273ns	1.02μs	0.0597	0	4.28 KB
master	`EnrichedLog`	net472	150μs	188ns	704ns	0.673	0.224	4.46 KB
#6174	`EnrichedLog`	net6.0	117μs	143ns	554ns	0.0589	0	4.28 KB
#6174	`EnrichedLog`	netcoreapp3.1	120μs	430ns	1.66μs	0.0597	0	4.28 KB
#6174	`EnrichedLog`	net472	152μs	170ns	657ns	0.683	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.08μs	1.03ns	3.98ns	0.0313	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.23μs	1.69ns	6.56ns	0.0297	2.2 KB
master	`EnrichedLog`	net472	4.7μs	1.57ns	6.09ns	0.32	2.02 KB
#6174	`EnrichedLog`	net6.0	3.11μs	0.96ns	3.72ns	0.0312	2.2 KB
#6174	`EnrichedLog`	netcoreapp3.1	4.34μs	1.32ns	5.13ns	0.0281	2.2 KB
#6174	`EnrichedLog`	net472	4.81μs	1.12ns	4.33ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.4μs	0.902ns	3.49ns	0.0161	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	2.36ns	9.13ns	0.015	0	1.14 KB
master	`SendReceive`	net472	2.15μs	0.688ns	2.48ns	0.184	0.00107	1.16 KB
#6174	`SendReceive`	net6.0	1.34μs	0.455ns	1.7ns	0.0161	0	1.14 KB
#6174	`SendReceive`	netcoreapp3.1	1.76μs	0.85ns	3.29ns	0.015	0	1.14 KB
#6174	`SendReceive`	net472	2.15μs	1.72ns	6.66ns	0.184	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.55μs	0.732ns	2.83ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.94μs	1.57ns	5.87ns	0.022	1.65 KB
master	`EnrichedLog`	net472	4.36μs	1.31ns	4.89ns	0.322	2.04 KB
#6174	`EnrichedLog`	net6.0	2.76μs	0.69ns	2.58ns	0.0221	1.6 KB
#6174	`EnrichedLog`	netcoreapp3.1	3.99μs	0.966ns	3.74ns	0.0219	1.65 KB
#6174	`EnrichedLog`	net472	4.5μs	2.45ns	8.5ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6174

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.180	486.31	573.74

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	400ns	0.414ns	1.6ns	0.00801	576 B
master	`StartFinishSpan`	netcoreapp3.1	586ns	0.379ns	1.47ns	0.00756	576 B
master	`StartFinishSpan`	net472	720ns	0.739ns	2.86ns	0.0917	578 B
master	`StartFinishScope`	net6.0	486ns	0.378ns	1.46ns	0.00984	696 B
master	`StartFinishScope`	netcoreapp3.1	762ns	4.05ns	19.8ns	0.00946	696 B
master	`StartFinishScope`	net472	859ns	0.956ns	3.7ns	0.104	658 B
#6174	`StartFinishSpan`	net6.0	399ns	0.35ns	1.35ns	0.00801	576 B
#6174	`StartFinishSpan`	netcoreapp3.1	582ns	0.43ns	1.67ns	0.00775	576 B
#6174	`StartFinishSpan`	net472	744ns	0.931ns	3.6ns	0.0917	578 B
#6174	`StartFinishScope`	net6.0	573ns	0.645ns	2.41ns	0.00984	696 B
#6174	`StartFinishScope`	netcoreapp3.1	715ns	0.612ns	2.37ns	0.00933	696 B
#6174	`StartFinishScope`	net472	842ns	0.695ns	2.69ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	659ns	1.67ns	6.47ns	0.00979	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	942ns	1.28ns	4.44ns	0.00906	696 B
master	`RunOnMethodBegin`	net472	1.08μs	0.95ns	3.68ns	0.104	658 B
#6174	`RunOnMethodBegin`	net6.0	732ns	0.585ns	2.27ns	0.00987	696 B
#6174	`RunOnMethodBegin`	netcoreapp3.1	926ns	1.07ns	4.16ns	0.00925	696 B
#6174	`RunOnMethodBegin`	net472	1.13μs	1.36ns	5.25ns	0.104	658 B

Update WAF version

63ce3f1

NachoEchevarria changed the title ~~Update WAF version~~ [ASM] Update WAF version to 1.20.1 Oct 21, 2024

NachoEchevarria added the area:asm label Oct 21, 2024

Merge branch 'master' into nacho/UpdateWafVersion1.20.1

aac6a00

NachoEchevarria marked this pull request as ready for review October 22, 2024 10:24

NachoEchevarria requested review from a team as code owners October 22, 2024 10:24

anna-git approved these changes Oct 22, 2024

View reviewed changes

lucaspimentel approved these changes Oct 22, 2024

View reviewed changes

NachoEchevarria merged commit ed3b441 into master Oct 22, 2024
75 checks passed

NachoEchevarria deleted the nacho/UpdateWafVersion1.20.1 branch October 22, 2024 14:36

github-actions bot added this to the vNext-v3 milestone Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASM] Update WAF version to 1.20.1 #6174

[ASM] Update WAF version to 1.20.1 #6174

NachoEchevarria commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024

datadog-ddstaging bot commented Oct 21, 2024 •

edited

Loading

andrewlock commented Oct 22, 2024

andrewlock commented Oct 22, 2024

andrewlock commented Oct 22, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #6174

Raw results

Faster 🎉 in #6174

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6174

Raw results

Raw results

[ASM] Update WAF version to 1.20.1 #6174

[ASM] Update WAF version to 1.20.1 #6174

Conversation

NachoEchevarria commented Oct 21, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

github-actions bot commented Oct 21, 2024

Snapshots difference summary

datadog-ddstaging bot commented Oct 21, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 22, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 22, 2024

Throughput/Crank Report ⚡

andrewlock commented Oct 22, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6174

Raw results

Faster 🎉 in #6174

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6174

Raw results

Raw results

NachoEchevarria commented Oct 21, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 21, 2024 •

edited

Loading