Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Visibility] Ensure commit messages are trimmed #6170

Merged

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Oct 18, 2024

Summary of changes

In this PR we ensure that the commit message gets trimmed.

Reason for change

We saw this issue in v2.41.0, I couldn't reproduce it in 3.x but let's do this just to be sure.

Implementation details

Call string.Trim

Other details

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 18, 2024

Datadog Report

Branch report: tony/civisiblity-ensure-commit-messages-are-trimmed
Commit report: ea2457e
Test service: dd-trace-dotnet

✅ 0 Failed, 369508 Passed, 2097 Skipped, 15h 32m 30.67s Total Time

@andrewlock
Copy link
Member

andrewlock commented Oct 18, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6170) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6170) - mean (1,110ms)  : 1090, 1131
     .   : milestone, 1110,
    master - mean (1,106ms)  : 1086, 1127
     .   : milestone, 1106,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6170) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6170) - mean (770ms)  : 755, 786
     .   : milestone, 770,
    master - mean (772ms)  : 755, 788
     .   : milestone, 772,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6170) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6170) - mean (723ms)  : 709, 736
     .   : milestone, 723,
    master - mean (726ms)  : 707, 746
     .   : milestone, 726,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6170) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6170) - mean (1,198ms)  : 1177, 1220
     .   : milestone, 1198,
    master - mean (1,202ms)  : 1175, 1230
     .   : milestone, 1202,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6170) - mean (276ms)  : 271, 282
     .   : milestone, 276,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6170) - mean (942ms)  : 923, 962
     .   : milestone, 942,
    master - mean (947ms)  : 929, 964
     .   : milestone, 947,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6170) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (265ms)  : 261, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6170) - mean (927ms)  : 907, 947
     .   : milestone, 927,
    master - mean (932ms)  : 910, 953
     .   : milestone, 932,

Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 18, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6170) (11.254M)   : 0, 11254444
    master (11.127M)   : 0, 11126752
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6170) (7.387M)   : 0, 7386658
    master (7.377M)   : 0, 7376563
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.612M)   : 0, 7612091

    section Manual
    master (11.042M)   : 0, 11042306

    section Manual + Automatic
    This PR (6170) (6.792M)   : 0, 6791633
    master (6.743M)   : 0, 6742844

    section DD_TRACE_ENABLED=0
    master (10.176M)   : 0, 10175955

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6170) (9.350M)   : 0, 9350302
    master (9.601M)   : 0, 9600942
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6170) (6.586M)   : 0, 6585763
    master (6.478M)   : 0, 6477825

    section Trace stats
    master (6.824M)   : 0, 6824216

    section Manual
    master (9.656M)   : 0, 9655746

    section Manual + Automatic
    This PR (6170) (6.053M)   : 0, 6053363
    master (6.006M)   : 0, 6006388

    section DD_TRACE_ENABLED=0
    master (8.643M)   : 0, 8642890

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6170) (9.826M)   : 0, 9826248
    master (10.217M)   : 0, 10217051
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6170) (6.410M)   : crit ,0, 6410011
    master (6.825M)   : 0, 6825492
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.437M)   : 0, 7437330

    section Manual
    master (9.999M)   : 0, 9998601

    section Manual + Automatic
    This PR (6170) (5.880M)   : 0, 5879665
    master (6.024M)   : 0, 6023637

    section DD_TRACE_ENABLED=0
    master (9.286M)   : 0, 9286300

Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 18, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6170 compared to master:

  • All benchmarks have the same speed
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.91μs 44.4ns 291ns 0.0154 0.00771 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.92μs 53.8ns 323ns 0.0147 0.00491 0 5.62 KB
master StartStopWithChild net472 16.6μs 67.5ns 261ns 1.04 0.332 0.0912 6.06 KB
#6170 StartStopWithChild net6.0 7.76μs 41.6ns 224ns 0.0116 0.00387 0 5.43 KB
#6170 StartStopWithChild netcoreapp3.1 9.89μs 53.9ns 381ns 0.0151 0.00504 0 5.62 KB
#6170 StartStopWithChild net472 16.6μs 72.4ns 280ns 1.01 0.292 0.0918 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 471μs 399ns 1.44μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 599ns 2.24μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 838μs 400ns 1.5μs 0.417 0 0 3.3 KB
#6170 WriteAndFlushEnrichedTraces net6.0 469μs 627ns 2.43μs 0 0 0 2.7 KB
#6170 WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 368ns 1.38μs 0 0 0 2.7 KB
#6170 WriteAndFlushEnrichedTraces net472 851μs 417ns 1.62μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 191μs 1.08μs 7.15μs 0.195 0 0 18.45 KB
master SendRequest netcoreapp3.1 230μs 1.48μs 14.7μs 0.231 0 0 20.61 KB
master SendRequest net472 0.00486ns 0.00168ns 0.00649ns 0 0 0 0 b
#6170 SendRequest net6.0 209μs 1.22μs 11.1μs 0.2 0 0 18.45 KB
#6170 SendRequest netcoreapp3.1 224μs 1.31μs 12.1μs 0.22 0 0 20.61 KB
#6170 SendRequest net472 0.0034ns 0.000942ns 0.00365ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6170

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.96 KB 41.75 KB -214 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 606μs 3.41μs 24.1μs 0.573 0 0 41.66 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 675μs 2.6μs 9.37μs 0.34 0 0 41.96 KB
master WriteAndFlushEnrichedTraces net472 900μs 3.32μs 12.4μs 8.36 2.64 0.44 53.33 KB
#6170 WriteAndFlushEnrichedTraces net6.0 555μs 1.56μs 7.47μs 0.573 0 0 41.54 KB
#6170 WriteAndFlushEnrichedTraces netcoreapp3.1 679μs 3.37μs 15.4μs 0.327 0 0 41.75 KB
#6170 WriteAndFlushEnrichedTraces net472 892μs 4.48μs 19.5μs 8.8 2.64 0.44 53.36 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.36μs 1.49ns 5.79ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.72μs 1.78ns 6.9ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 1.89ns 7.31ns 0.156 0 0 987 B
#6170 ExecuteNonQuery net6.0 1.3μs 1.26ns 4.7ns 0.0143 0 0 1.02 KB
#6170 ExecuteNonQuery netcoreapp3.1 1.75μs 1.78ns 6.89ns 0.0139 0 0 1.02 KB
#6170 ExecuteNonQuery net472 2.03μs 1.55ns 5.99ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 0.335ns 1.25ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 0.774ns 2.9ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.51μs 1.63ns 6.31ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.25μs 0.385ns 1.44ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 1.48ns 5.52ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 1.86ns 6.97ns 0.167 0 0 1.05 KB
#6170 CallElasticsearch net6.0 1.2μs 0.449ns 1.68ns 0.0134 0 0 976 B
#6170 CallElasticsearch netcoreapp3.1 1.53μs 0.758ns 2.83ns 0.0129 0 0 976 B
#6170 CallElasticsearch net472 2.41μs 1.12ns 4.21ns 0.157 0 0 995 B
#6170 CallElasticsearchAsync net6.0 1.33μs 0.62ns 2.4ns 0.0133 0 0 952 B
#6170 CallElasticsearchAsync netcoreapp3.1 1.57μs 0.409ns 1.58ns 0.0133 0 0 1.02 KB
#6170 CallElasticsearchAsync net472 2.53μs 2.14ns 8.3ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.625ns 2.34ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 3.15ns 12.2ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.86μs 3.61ns 14ns 0.145 0 0 915 B
#6170 ExecuteAsync net6.0 1.15μs 0.62ns 2.32ns 0.0133 0 0 952 B
#6170 ExecuteAsync netcoreapp3.1 1.65μs 2.1ns 7.84ns 0.0131 0 0 952 B
#6170 ExecuteAsync net472 1.77μs 0.628ns 2.43ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.17μs 3.97ns 14.8ns 0.0313 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.05μs 2.15ns 8.31ns 0.0378 0 0 2.76 KB
master SendAsync net472 7.74μs 7.42ns 28.7ns 0.499 0 0 3.15 KB
#6170 SendAsync net6.0 4.26μs 1.23ns 4.25ns 0.0297 0 0 2.22 KB
#6170 SendAsync netcoreapp3.1 4.96μs 2.12ns 8.22ns 0.0372 0 0 2.76 KB
#6170 SendAsync net472 7.66μs 2.13ns 8.26ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.5μs 0.854ns 3.19ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.11μs 1.74ns 6.52ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.56μs 0.606ns 2.18ns 0.249 0 0 1.57 KB
#6170 EnrichedLog net6.0 1.55μs 0.667ns 2.31ns 0.0234 0 0 1.64 KB
#6170 EnrichedLog netcoreapp3.1 2.11μs 2.22ns 8.32ns 0.0221 0 0 1.64 KB
#6170 EnrichedLog net472 2.5μs 0.719ns 2.59ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 178ns 690ns 0.0579 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 94.5ns 354ns 0 0 0 4.28 KB
master EnrichedLog net472 153μs 97.7ns 378ns 0.687 0.229 0 4.46 KB
#6170 EnrichedLog net6.0 118μs 116ns 451ns 0 0 0 4.28 KB
#6170 EnrichedLog netcoreapp3.1 121μs 128ns 494ns 0 0 0 4.28 KB
#6170 EnrichedLog net472 153μs 129ns 498ns 0.682 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.22μs 1.18ns 4.57ns 0.0306 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.24μs 1.46ns 5.26ns 0.0276 0 0 2.2 KB
master EnrichedLog net472 4.94μs 2.88ns 11.1ns 0.319 0 0 2.02 KB
#6170 EnrichedLog net6.0 3.08μs 0.675ns 2.52ns 0.0309 0 0 2.2 KB
#6170 EnrichedLog netcoreapp3.1 4.47μs 4.71ns 18.2ns 0.0293 0 0 2.2 KB
#6170 EnrichedLog net472 4.92μs 1.96ns 7.59ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.42μs 1.57ns 6.08ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.68μs 0.557ns 2.16ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.1μs 0.62ns 2.32ns 0.183 0 0 1.16 KB
#6170 SendReceive net6.0 1.3μs 0.913ns 3.54ns 0.0159 0 0 1.14 KB
#6170 SendReceive netcoreapp3.1 1.74μs 2.1ns 8.12ns 0.0157 0 0 1.14 KB
#6170 SendReceive net472 2.11μs 0.951ns 3.29ns 0.183 0.00106 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.71μs 1.15ns 4.45ns 0.023 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.96μs 1.34ns 5.18ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.51μs 1.81ns 6.76ns 0.323 0 0 2.04 KB
#6170 EnrichedLog net6.0 2.64μs 0.894ns 3.34ns 0.0223 0 0 1.6 KB
#6170 EnrichedLog netcoreapp3.1 4.08μs 0.808ns 2.91ns 0.0205 0 0 1.65 KB
#6170 EnrichedLog net472 4.52μs 2.46ns 9.51ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 460ns 0.193ns 0.749ns 0.00808 0 0 576 B
master StartFinishSpan netcoreapp3.1 551ns 0.227ns 0.879ns 0.00774 0 0 576 B
master StartFinishSpan net472 696ns 0.66ns 2.47ns 0.0917 0 0 578 B
master StartFinishScope net6.0 490ns 0.18ns 0.672ns 0.00983 0 0 696 B
master StartFinishScope netcoreapp3.1 741ns 1.85ns 7.17ns 0.00945 0 0 696 B
master StartFinishScope net472 899ns 0.424ns 1.59ns 0.104 0 0 658 B
#6170 StartFinishSpan net6.0 465ns 0.171ns 0.64ns 0.00812 0 0 576 B
#6170 StartFinishSpan netcoreapp3.1 566ns 0.25ns 0.97ns 0.0078 0 0 576 B
#6170 StartFinishSpan net472 686ns 0.548ns 2.05ns 0.0918 0 0 578 B
#6170 StartFinishScope net6.0 491ns 0.29ns 1.12ns 0.00972 0 0 696 B
#6170 StartFinishScope netcoreapp3.1 770ns 0.571ns 2.21ns 0.00927 0 0 696 B
#6170 StartFinishScope net472 934ns 0.749ns 2.9ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 597ns 0.253ns 0.979ns 0.00989 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.03μs 1.09ns 4.23ns 0.00932 0 0 696 B
master RunOnMethodBegin net472 1.18μs 0.538ns 2.01ns 0.105 0 0 658 B
#6170 RunOnMethodBegin net6.0 603ns 0.369ns 1.43ns 0.00985 0 0 696 B
#6170 RunOnMethodBegin netcoreapp3.1 948ns 0.434ns 1.62ns 0.00933 0 0 696 B
#6170 RunOnMethodBegin net472 1.14μs 0.442ns 1.65ns 0.104 0 0 658 B

@tonyredondo tonyredondo merged commit 62592f5 into master Oct 21, 2024
74 checks passed
@tonyredondo tonyredondo deleted the tony/civisiblity-ensure-commit-messages-are-trimmed branch October 21, 2024 12:21
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants