-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Update tests to save output to xunit.txt files #6160
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6160) - mean (72ms) : 62, 82
. : milestone, 72,
master - mean (72ms) : 64, 80
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6160) - mean (987ms) : 963, 1012
. : milestone, 987,
master - mean (987ms) : 959, 1014
. : milestone, 987,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6160) - mean (108ms) : 106, 110
. : milestone, 108,
master - mean (108ms) : 106, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6160) - mean (687ms) : 673, 701
. : milestone, 687,
master - mean (684ms) : 665, 703
. : milestone, 684,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6160) - mean (93ms) : 88, 98
. : milestone, 93,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6160) - mean (641ms) : 628, 654
. : milestone, 641,
master - mean (639ms) : 624, 655
. : milestone, 639,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6160) - mean (191ms) : 186, 195
. : milestone, 191,
master - mean (192ms) : 187, 197
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6160) - mean (1,100ms) : 1071, 1129
. : milestone, 1100,
master - mean (1,101ms) : 1075, 1126
. : milestone, 1101,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6160) - mean (276ms) : 273, 279
. : milestone, 276,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6160) - mean (876ms) : 849, 903
. : milestone, 876,
master - mean (881ms) : 851, 911
. : milestone, 881,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6160) - mean (266ms) : 262, 270
. : milestone, 266,
master - mean (266ms) : 262, 269
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6160) - mean (856ms) : 825, 888
. : milestone, 856,
master - mean (857ms) : 827, 886
. : milestone, 857,
|
Datadog ReportBranch report: ✅ 0 Failed, 449755 Passed, 3198 Skipped, 21h 23m 10.89s Total Time |
Benchmarks Report for tracer 🐌Benchmarks for #6160 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.240 | 599.32 | 743.01 | |
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.159 | 481.37 | 557.86 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 398ns | 0.624ns | 2.42ns | 0.008 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 612ns | 0.604ns | 2.26ns | 0.00772 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 599ns | 0.633ns | 2.37ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 482ns | 0.756ns | 2.93ns | 0.00971 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 759ns | 0.973ns | 3.77ns | 0.00945 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 919ns | 1.84ns | 7.11ns | 0.104 | 0 | 0 | 658 B |
#6160 | StartFinishSpan |
net6.0 | 395ns | 0.761ns | 2.95ns | 0.00803 | 0 | 0 | 576 B |
#6160 | StartFinishSpan |
netcoreapp3.1 | 588ns | 0.944ns | 3.66ns | 0.0078 | 0 | 0 | 576 B |
#6160 | StartFinishSpan |
net472 | 743ns | 1.34ns | 5.18ns | 0.0917 | 0 | 0 | 578 B |
#6160 | StartFinishScope |
net6.0 | 558ns | 0.692ns | 2.68ns | 0.00985 | 0 | 0 | 696 B |
#6160 | StartFinishScope |
netcoreapp3.1 | 754ns | 1.32ns | 5.12ns | 0.00966 | 0 | 0 | 696 B |
#6160 | StartFinishScope |
net472 | 918ns | 1.81ns | 7.03ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 599ns | 0.34ns | 1.32ns | 0.00976 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 930ns | 1.45ns | 5.23ns | 0.00935 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.13μs | 2.19ns | 8.49ns | 0.104 | 0 | 0 | 658 B |
#6160 | RunOnMethodBegin |
net6.0 | 630ns | 0.861ns | 3.33ns | 0.00971 | 0 | 0 | 696 B |
#6160 | RunOnMethodBegin |
netcoreapp3.1 | 962ns | 2.13ns | 8.27ns | 0.00955 | 0 | 0 | 696 B |
#6160 | RunOnMethodBegin |
net472 | 1.12μs | 1.31ns | 4.89ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6160) (11.235M) : 0, 11235418
master (11.120M) : 0, 11120201
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6160) (7.191M) : 0, 7191074
master (7.143M) : 0, 7143247
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.563M) : 0, 7562834
section Manual
master (11.052M) : 0, 11051540
section Manual + Automatic
This PR (6160) (6.649M) : 0, 6649215
master (6.532M) : 0, 6532471
section DD_TRACE_ENABLED=0
master (10.176M) : 0, 10176174
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6160) (9.522M) : 0, 9522441
master (9.435M) : 0, 9435139
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6160) (6.420M) : 0, 6419518
master (6.301M) : 0, 6300608
section Trace stats
master (6.646M) : 0, 6646045
section Manual
master (9.564M) : 0, 9563833
section Manual + Automatic
This PR (6160) (5.996M) : 0, 5995764
master (5.897M) : 0, 5897193
section DD_TRACE_ENABLED=0
master (8.862M) : 0, 8862065
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6160) (9.718M) : 0, 9717936
master (9.832M) : 0, 9832351
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6160) (6.302M) : 0, 6302290
master (6.258M) : 0, 6258447
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.950M) : 0, 6950057
section Manual
master (9.945M) : 0, 9945109
section Manual + Automatic
This PR (6160) (5.816M) : 0, 5816254
master (5.742M) : 0, 5742033
section DD_TRACE_ENABLED=0
master (9.091M) : 0, 9091089
|
4604300
to
714e946
Compare
…taDog/dd-trace-dotnet into chrisnas/xunit_output_to_file
Summary of changes
Update all tests to send output to console AND file
Reason for change
That way, it is possible to have the tests output visible in the CI with xunit.txt file to download
Implementation details
Update all tests
Test coverage
n/a
Other details