-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .sln
project ordering
#6156
Conversation
.sln
project ordering
Datadog ReportBranch report: ✅ 0 Failed, 368179 Passed, 2099 Skipped, 15h 8m 23.39s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6156) - mean (70ms) : 68, 72
. : milestone, 70,
master - mean (71ms) : 68, 75
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6156) - mean (1,114ms) : 1093, 1136
. : milestone, 1114,
master - mean (1,129ms) : 1105, 1153
. : milestone, 1129,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6156) - mean (109ms) : 107, 112
. : milestone, 109,
master - mean (112ms) : 108, 116
. : milestone, 112,
section CallTarget+Inlining+NGEN
This PR (6156) - mean (773ms) : 757, 788
. : milestone, 773,
master - mean (791ms) : 767, 815
. : milestone, 791,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6156) - mean (92ms) : 90, 95
. : milestone, 92,
master - mean (95ms) : 92, 99
. : milestone, 95,
section CallTarget+Inlining+NGEN
This PR (6156) - mean (730ms) : 714, 745
. : milestone, 730,
master - mean (749ms) : 732, 765
. : milestone, 749,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6156) - mean (191ms) : 188, 194
. : milestone, 191,
master - mean (190ms) : 186, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6156) - mean (1,201ms) : 1177, 1225
. : milestone, 1201,
master - mean (1,205ms) : 1156, 1255
. : milestone, 1205,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6156) - mean (278ms) : 272, 283
. : milestone, 278,
master - mean (277ms) : 271, 284
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6156) - mean (942ms) : 923, 961
. : milestone, 942,
master - mean (947ms) : 930, 964
. : milestone, 947,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6156) - mean (266ms) : 261, 270
. : milestone, 266,
master - mean (266ms) : 260, 272
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6156) - mean (932ms) : 910, 954
. : milestone, 932,
master - mean (929ms) : 907, 950
. : milestone, 929,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6156) (11.077M) : 0, 11077481
master (10.879M) : 0, 10878586
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6156) (7.248M) : 0, 7248008
master (7.360M) : 0, 7359645
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.759M) : 0, 7758687
section Manual
master (11.183M) : 0, 11183363
section Manual + Automatic
This PR (6156) (6.682M) : 0, 6682073
master (6.756M) : 0, 6755648
section DD_TRACE_ENABLED=0
master (10.216M) : 0, 10216257
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6156) (9.732M) : 0, 9731768
master (9.604M) : 0, 9604295
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6156) (6.574M) : 0, 6573938
master (6.653M) : 0, 6652975
section Trace stats
master (6.966M) : 0, 6966327
section Manual
master (9.484M) : 0, 9484205
section Manual + Automatic
This PR (6156) (6.007M) : 0, 6006988
master (5.968M) : 0, 5968075
section DD_TRACE_ENABLED=0
master (8.908M) : 0, 8907937
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6156) (9.971M) : 0, 9970967
master (10.287M) : 0, 10286765
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6156) (6.612M) : 0, 6611565
master (6.541M) : 0, 6541131
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.268M) : 0, 7268357
section Manual
master (10.078M) : 0, 10077965
section Manual + Automatic
This PR (6156) (5.879M) : crit ,0, 5879220
master (6.224M) : 0, 6223558
section DD_TRACE_ENABLED=0
master (9.403M) : 0, 9402673
|
Benchmarks Report for tracer 🐌Benchmarks for #6156 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.142 | 492.96 | 562.82 | |
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.124 | 553.48 | 621.93 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.158 | 472.34 | 407.86 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 472ns | 0.174ns | 0.627ns | 0.00806 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 564ns | 3.08ns | 17.4ns | 0.00801 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 669ns | 0.432ns | 1.62ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 493ns | 0.295ns | 1.14ns | 0.00979 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 761ns | 0.506ns | 1.89ns | 0.00927 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 846ns | 0.634ns | 2.37ns | 0.104 | 0 | 0 | 658 B |
#6156 | StartFinishSpan |
net6.0 | 408ns | 0.377ns | 1.46ns | 0.0082 | 0 | 0 | 576 B |
#6156 | StartFinishSpan |
netcoreapp3.1 | 622ns | 0.332ns | 1.24ns | 0.00768 | 0 | 0 | 576 B |
#6156 | StartFinishSpan |
net472 | 670ns | 0.477ns | 1.72ns | 0.0918 | 0 | 0 | 578 B |
#6156 | StartFinishScope |
net6.0 | 563ns | 0.156ns | 0.563ns | 0.00974 | 0 | 0 | 696 B |
#6156 | StartFinishScope |
netcoreapp3.1 | 686ns | 1.36ns | 5.28ns | 0.00939 | 0 | 0 | 696 B |
#6156 | StartFinishScope |
net472 | 935ns | 0.887ns | 3.2ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 593ns | 0.179ns | 0.669ns | 0.00985 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 928ns | 0.44ns | 1.65ns | 0.00933 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.18μs | 1.69ns | 6.55ns | 0.105 | 0 | 0 | 658 B |
#6156 | RunOnMethodBegin |
net6.0 | 649ns | 0.268ns | 1ns | 0.00987 | 0 | 0 | 696 B |
#6156 | RunOnMethodBegin |
netcoreapp3.1 | 949ns | 0.962ns | 3.72ns | 0.00909 | 0 | 0 | 696 B |
#6156 | RunOnMethodBegin |
net472 | 1.12μs | 0.966ns | 3.61ns | 0.104 | 0 | 0 | 658 B |
Merging before you get conflicts 😅 |
Thanks! The build wasn't finished by the time I had to go |
Summary of changes
Visual Studio
sln
stuff main one is to get theSamples.AWS.EventBridge
to show up correctly.Reason for change
sln
was messed up causing stuff to not show up where you'd expectImplementation details
Drag drop and save
Test coverage
Other recent sample projects changes too in the
sln
but 🤷Other details