Fix return value on error in delegate instrumentation #6153

kevingosse · 2024-10-14T16:57:46Z

Summary of changes

In the delegate instrumentation, when the async callback failed, we returned a default value instead of the original value.

Reason for change

The instrumented method probably had a good reason to return that value to begin with.

Implementation details

Just set the value in the catch block.

Test coverage

Added tests to cover the "failure in callback" case.

Also, fixed a flake in the async test (which is actually the reason why I looked at this code to begin with). The tests were relying on the order of execution of the onDelegateEnd/onDelegateAsyncEnd callbacks, but their order is not guaranteed (because onDelegateAsyncEnd is invoked asynchronously and not awaited).

Add tests

datadog-ddstaging · 2024-10-14T17:22:47Z

Datadog Report

Branch report: kevin/async_func
Commit report: 407940e
Test service: dd-trace-dotnet

✅ 0 Failed, 363916 Passed, 2070 Skipped, 14h 55m 16.96s Total Time

andrewlock · 2024-10-14T17:29:24Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6153) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6153) - mean (1,111ms)  : 1091, 1131
     .   : milestone, 1111,
    master - mean (1,110ms)  : 1094, 1127
     .   : milestone, 1110,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6153) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6153) - mean (768ms)  : 752, 785
     .   : milestone, 768,
    master - mean (769ms)  : 755, 783
     .   : milestone, 769,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6153) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6153) - mean (724ms)  : 709, 740
     .   : milestone, 724,
    master - mean (744ms)  : 657, 831
     .   : milestone, 744,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6153) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (189ms)  : 187, 191
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6153) - mean (1,195ms)  : 1170, 1220
     .   : milestone, 1195,
    master - mean (1,200ms)  : 1174, 1225
     .   : milestone, 1200,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6153) - mean (275ms)  : 270, 280
     .   : milestone, 275,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6153) - mean (938ms)  : 922, 954
     .   : milestone, 938,
    master - mean (939ms)  : 920, 957
     .   : milestone, 939,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6153) - mean (263ms)  : 259, 267
     .   : milestone, 263,
    master - mean (266ms)  : 258, 273
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6153) - mean (920ms)  : 898, 941
     .   : milestone, 920,
    master - mean (927ms)  : 908, 946
     .   : milestone, 927,

andrewlock · 2024-10-14T18:20:43Z

Benchmarks Report for tracer 🐌

Benchmarks for #6153 compared to master:

2 benchmarks are slower, with geometric mean 1.132
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.83μs	45ns	334ns	0.0174	0.0087	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	55.6ns	324ns	0.015	0.00501	0	5.62 KB
master	`StartStopWithChild`	net472	16.4μs	47.8ns	185ns	1.03	0.318	0.106	6.07 KB
#6153	`StartStopWithChild`	net6.0	7.78μs	44ns	330ns	0.0197	0.00789	0	5.42 KB
#6153	`StartStopWithChild`	netcoreapp3.1	10.1μs	31.1ns	116ns	0.0196	0.0098	0	5.62 KB
#6153	`StartStopWithChild`	net472	17μs	68.2ns	264ns	1.02	0.306	0.0994	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	468μs	278ns	1.04μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	643μs	306ns	1.18μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	845μs	630ns	2.44μs	0.419	3.3 KB
#6153	`WriteAndFlushEnrichedTraces`	net6.0	468μs	573ns	2.22μs	0	2.7 KB
#6153	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	635μs	331ns	1.28μs	0	2.7 KB
#6153	`WriteAndFlushEnrichedTraces`	net472	845μs	551ns	2.14μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	199μs	1.16μs	11μs	0.193	18.45 KB
master	`SendRequest`	netcoreapp3.1	223μs	1.3μs	12μs	0.214	20.61 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6153	`SendRequest`	net6.0	194μs	1.12μs	8.87μs	0.195	18.45 KB
#6153	`SendRequest`	netcoreapp3.1	219μs	1.22μs	7.42μs	0.217	20.61 KB
#6153	`SendRequest`	net472	0.00069ns	0.000268ns	0.000928ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	560μs	2.74μs	12.6μs	0.556	0	0	41.45 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	679μs	3.72μs	21.7μs	0.336	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	net472	892μs	3.6μs	14μs	8.09	2.25	0.45	53.29 KB
#6153	`WriteAndFlushEnrichedTraces`	net6.0	555μs	2.77μs	12.4μs	0.543	0	0	41.57 KB
#6153	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	667μs	1.62μs	6.07μs	0.332	0	0	41.59 KB
#6153	`WriteAndFlushEnrichedTraces`	net472	883μs	3.17μs	12.3μs	8.25	2.6	0.434	53.34 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	0.998ns	3.87ns	0.0146	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	0.923ns	3.57ns	0.0131	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	2.27ns	8.78ns	0.156	987 B
#6153	`ExecuteNonQuery`	net6.0	1.27μs	1.37ns	4.95ns	0.0146	1.02 KB
#6153	`ExecuteNonQuery`	netcoreapp3.1	1.83μs	2ns	7.74ns	0.0137	1.02 KB
#6153	`ExecuteNonQuery`	net472	2.08μs	1.97ns	7.63ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.16μs	1.26ns	4.9ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.803ns	3.11ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.47μs	2.06ns	7.96ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.34μs	0.857ns	3.32ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.472ns	1.77ns	0.0141	1.02 KB
master	`CallElasticsearchAsync`	net472	2.73μs	1.57ns	6.09ns	0.166	1.05 KB
#6153	`CallElasticsearch`	net6.0	1.24μs	0.682ns	2.64ns	0.0137	976 B
#6153	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.545ns	1.97ns	0.0132	976 B
#6153	`CallElasticsearch`	net472	2.43μs	1.63ns	6.12ns	0.157	995 B
#6153	`CallElasticsearchAsync`	net6.0	1.23μs	0.468ns	1.69ns	0.013	952 B
#6153	`CallElasticsearchAsync`	netcoreapp3.1	1.56μs	0.866ns	3.12ns	0.014	1.02 KB
#6153	`CallElasticsearchAsync`	net472	2.55μs	2.32ns	8.99ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	1.51ns	5.86ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.61μs	0.606ns	2.35ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.73μs	0.91ns	3.41ns	0.145	915 B
#6153	`ExecuteAsync`	net6.0	1.33μs	0.797ns	2.98ns	0.0133	952 B
#6153	`ExecuteAsync`	netcoreapp3.1	1.58μs	2.22ns	8.58ns	0.0126	952 B
#6153	`ExecuteAsync`	net472	1.78μs	1.3ns	5.05ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.16μs	1.24ns	4.65ns	0.0311	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.11μs	2.7ns	10.5ns	0.0359	2.76 KB
master	`SendAsync`	net472	7.89μs	2.34ns	9.08ns	0.497	3.15 KB
#6153	`SendAsync`	net6.0	4.21μs	5.9ns	22.8ns	0.0295	2.22 KB
#6153	`SendAsync`	netcoreapp3.1	5.09μs	2.25ns	8.42ns	0.036	2.76 KB
#6153	`SendAsync`	net472	7.71μs	2.53ns	9.79ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.46μs	1.4ns	5.61ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.34μs	1.91ns	7.38ns	0.0221	1.64 KB
master	`EnrichedLog`	net472	2.7μs	1.56ns	6.05ns	0.249	1.57 KB
#6153	`EnrichedLog`	net6.0	1.52μs	2.11ns	8.16ns	0.0233	1.64 KB
#6153	`EnrichedLog`	netcoreapp3.1	2.29μs	3ns	11.6ns	0.0219	1.64 KB
#6153	`EnrichedLog`	net472	2.55μs	0.602ns	2.25ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	215ns	834ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	184ns	712ns	0	0	4.28 KB
master	`EnrichedLog`	net472	153μs	127ns	491ns	0.686	0.229	4.46 KB
#6153	`EnrichedLog`	net6.0	116μs	138ns	535ns	0.0583	0	4.28 KB
#6153	`EnrichedLog`	netcoreapp3.1	122μs	141ns	547ns	0	0	4.28 KB
#6153	`EnrichedLog`	net472	152μs	139ns	538ns	0.686	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.95μs	1.03ns	3.71ns	0.031	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.15μs	1.69ns	6.54ns	0.0291	2.2 KB
master	`EnrichedLog`	net472	4.72μs	1.17ns	4.53ns	0.32	2.02 KB
#6153	`EnrichedLog`	net6.0	2.92μs	1.41ns	5.45ns	0.0307	2.2 KB
#6153	`EnrichedLog`	netcoreapp3.1	4.14μs	3ns	11.6ns	0.029	2.2 KB
#6153	`EnrichedLog`	net472	4.86μs	0.91ns	3.4ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.42μs	0.882ns	3.3ns	0.0156	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.69μs	1.03ns	3.57ns	0.0153	0	1.14 KB
master	`SendReceive`	net472	2.19μs	1.56ns	6.03ns	0.183	0.00109	1.16 KB
#6153	`SendReceive`	net6.0	1.39μs	0.564ns	2.19ns	0.0159	0	1.14 KB
#6153	`SendReceive`	netcoreapp3.1	1.8μs	1.2ns	4.65ns	0.0153	0	1.14 KB
#6153	`SendReceive`	net472	1.99μs	0.629ns	2.27ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.73μs	1.15ns	4.15ns	0.0221	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	1.74ns	6.49ns	0.0214	1.65 KB
master	`EnrichedLog`	net472	4.28μs	2.92ns	11.3ns	0.323	2.04 KB
#6153	`EnrichedLog`	net6.0	2.75μs	0.811ns	3.14ns	0.022	1.6 KB
#6153	`EnrichedLog`	netcoreapp3.1	3.96μs	0.738ns	2.76ns	0.0218	1.65 KB
#6153	`EnrichedLog`	net472	4.37μs	1.82ns	6.81ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6153

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.138	480.77	546.89
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.127	552.20	622.46

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	394ns	0.178ns	0.667ns	0.00815	576 B
master	`StartFinishSpan`	netcoreapp3.1	552ns	0.411ns	1.48ns	0.00778	576 B
master	`StartFinishSpan`	net472	774ns	0.569ns	2.2ns	0.0915	578 B
master	`StartFinishScope`	net6.0	481ns	0.221ns	0.825ns	0.00986	696 B
master	`StartFinishScope`	netcoreapp3.1	733ns	1.4ns	5.43ns	0.00935	696 B
master	`StartFinishScope`	net472	947ns	0.751ns	2.91ns	0.104	658 B
#6153	`StartFinishSpan`	net6.0	408ns	0.188ns	0.726ns	0.00819	576 B
#6153	`StartFinishSpan`	netcoreapp3.1	622ns	0.258ns	0.967ns	0.00759	576 B
#6153	`StartFinishSpan`	net472	754ns	0.511ns	1.98ns	0.0916	578 B
#6153	`StartFinishScope`	net6.0	547ns	0.228ns	0.881ns	0.00985	696 B
#6153	`StartFinishScope`	netcoreapp3.1	797ns	0.53ns	2.05ns	0.0092	696 B
#6153	`StartFinishScope`	net472	882ns	0.736ns	2.85ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	662ns	0.373ns	1.44ns	0.00994	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	927ns	0.475ns	1.84ns	0.00924	696 B
master	`RunOnMethodBegin`	net472	1.13μs	0.284ns	0.984ns	0.104	658 B
#6153	`RunOnMethodBegin`	net6.0	624ns	0.522ns	1.95ns	0.00985	696 B
#6153	`RunOnMethodBegin`	netcoreapp3.1	931ns	0.425ns	1.65ns	0.00958	696 B
#6153	`RunOnMethodBegin`	net472	1.14μs	0.721ns	2.79ns	0.104	658 B

tonyredondo

Oh great catch, I missed that one. Thanks for the fix

andrewlock · 2024-10-14T19:38:54Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6153) (11.146M)   : 0, 11145781
    master (11.137M)   : 0, 11137140
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6153) (7.302M)   : 0, 7301913
    master (7.371M)   : 0, 7370758
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.797M)   : 0, 7797307

    section Manual
    master (11.111M)   : 0, 11110541

    section Manual + Automatic
    This PR (6153) (6.664M)   : 0, 6664314
    master (6.715M)   : 0, 6715013

    section DD_TRACE_ENABLED=0
    master (10.145M)   : 0, 10144731

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6153) (9.637M)   : 0, 9637424
    master (9.288M)   : 0, 9287840
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6153) (6.525M)   : 0, 6525047
    master (6.397M)   : 0, 6396905

    section Trace stats
    master (6.866M)   : 0, 6865601

    section Manual
    master (9.556M)   : 0, 9555874

    section Manual + Automatic
    This PR (6153) (6.005M)   : 0, 6004519
    master (6.065M)   : 0, 6065089

    section DD_TRACE_ENABLED=0
    master (8.502M)   : 0, 8501634

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6153) (10.253M)   : 0, 10253347
    master (10.368M)   : 0, 10368181
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6153) (6.941M)   : 0, 6941022
    master (6.778M)   : 0, 6777658
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.515M)   : 0, 7514665

    section Manual
    master (10.210M)   : 0, 10210161

    section Manual + Automatic
    This PR (6153) (6.524M)   : 0, 6523525
    master (6.466M)   : 0, 6466038

    section DD_TRACE_ENABLED=0
    master (9.590M)   : 0, 9589809

andrewlock

Nice catch 👍

Fix return value on delegate instrumentation

f70131c

Add tests

kevingosse requested a review from a team as a code owner October 14, 2024 16:57

Use InvalidOperationException everywhere

407940e

tonyredondo approved these changes Oct 14, 2024

View reviewed changes

andrewlock approved these changes Oct 15, 2024

View reviewed changes

kevingosse merged commit a200693 into master Oct 16, 2024
74 checks passed

kevingosse deleted the kevin/async_func branch October 16, 2024 09:58

github-actions bot added this to the vNext-v3 milestone Oct 16, 2024

andrewlock added type:bug area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) labels Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix return value on error in delegate instrumentation #6153

Fix return value on error in delegate instrumentation #6153

kevingosse commented Oct 14, 2024

datadog-ddstaging bot commented Oct 14, 2024 •

edited

Loading

andrewlock commented Oct 14, 2024

andrewlock commented Oct 14, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6153

Raw results

Raw results

tonyredondo left a comment

andrewlock commented Oct 14, 2024

andrewlock left a comment

Fix return value on error in delegate instrumentation #6153

Fix return value on error in delegate instrumentation #6153

Conversation

kevingosse commented Oct 14, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

datadog-ddstaging bot commented Oct 14, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 14, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 14, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6153

Raw results

Raw results

tonyredondo left a comment

Choose a reason for hiding this comment

andrewlock commented Oct 14, 2024

Throughput/Crank Report ⚡

andrewlock left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Oct 14, 2024 •

edited

Loading