[Crashtracking] Disable crashtracking on Windows by default #6152

kevingosse · 2024-10-14T12:39:57Z

Summary of changes

Disable crashtracking on Windows by default.

Reason for change

The next version of the tracer will be released before we implement proper support for the PDBs in crashtracking, so change it to opt-in for now (effectively disabling it since nobody is going to manually enable it).

Implementation details

Changed the default value of DD_CRASHTRACKING_ENABLED.

Test coverage

Had to update the tests to account for the new default value on Windows.

andrewlock · 2024-10-14T13:12:04Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6152) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6152) - mean (1,111ms)  : 1082, 1140
     .   : milestone, 1111,
    master - mean (1,107ms)  : 1090, 1125
     .   : milestone, 1107,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6152) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6152) - mean (772ms)  : 757, 787
     .   : milestone, 772,
    master - mean (769ms)  : 752, 786
     .   : milestone, 769,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6152) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6152) - mean (735ms)  : 708, 763
     .   : milestone, 735,
    master - mean (727ms)  : 708, 747
     .   : milestone, 727,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6152) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (189ms)  : 186, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6152) - mean (1,202ms)  : 1176, 1228
     .   : milestone, 1202,
    master - mean (1,194ms)  : 1168, 1219
     .   : milestone, 1194,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6152) - mean (275ms)  : 270, 280
     .   : milestone, 275,
    master - mean (275ms)  : 270, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6152) - mean (945ms)  : 923, 966
     .   : milestone, 945,
    master - mean (942ms)  : 925, 958
     .   : milestone, 942,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6152) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (262ms)  : 259, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6152) - mean (926ms)  : 904, 948
     .   : milestone, 926,
    master - mean (922ms)  : 904, 939
     .   : milestone, 922,

datadog-ddstaging · 2024-10-14T13:12:16Z

Datadog Report

Branch report: kevin/disable_ct_windows
Commit report: 0d4f3b3
Test service: dd-trace-dotnet

✅ 0 Failed, 372094 Passed, 2391 Skipped, 16h 44m 12.88s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

SubmitTraces - Datadog.Trace.ClrProfiler.IntegrationTests.CI.MsTestV2EvpTests - Last Failure

Expand for error

 Results do not match.
 Differences:
 Received: MsTestV2EvpTests.SubmitTraces_packageVersion=post_2_2_4.received.txt
 Verified: MsTestV2EvpTests.SubmitTraces_packageVersion=post_2_2_4.verified.txt
 Received Content:
 []
 Verified Content:
 [
   {
     TraceId: Id_1,
 ...

andrewlock · 2024-10-14T14:14:39Z

Benchmarks Report for tracer 🐌

Benchmarks for #6152 compared to master:

1 benchmarks are faster, with geometric mean 1.236
1 benchmarks are slower, with geometric mean 1.138
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.85μs	43.7ns	290ns	0.0124	0.00415	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	56.2ns	364ns	0.0207	0.0104	0	5.61 KB
master	`StartStopWithChild`	net472	16.6μs	38.7ns	150ns	1.03	0.313	0.104	6.08 KB
#6152	`StartStopWithChild`	net6.0	7.84μs	42ns	226ns	0.0152	0.00758	0	5.42 KB
#6152	`StartStopWithChild`	netcoreapp3.1	10μs	56.2ns	389ns	0.0238	0.00952	0	5.62 KB
#6152	`StartStopWithChild`	net472	16.9μs	54.9ns	213ns	1.01	0.29	0.0828	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	478μs	146ns	545ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	206ns	800ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	654ns	2.53μs	0.419	3.3 KB
#6152	`WriteAndFlushEnrichedTraces`	net6.0	490μs	232ns	869ns	0	2.7 KB
#6152	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	635μs	572ns	2.22μs	0	2.7 KB
#6152	`WriteAndFlushEnrichedTraces`	net472	838μs	515ns	1.93μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	190μs	1.03μs	6.24μs	0.201	18.45 KB
master	`SendRequest`	netcoreapp3.1	224μs	1.28μs	9.23μs	0.212	20.61 KB
master	`SendRequest`	net472	0.0314ns	0.00646ns	0.025ns	0	0 b
#6152	`SendRequest`	net6.0	198μs	1.15μs	9.41μs	0.191	18.45 KB
#6152	`SendRequest`	netcoreapp3.1	218μs	1.23μs	8.71μs	0.224	20.61 KB
#6152	`SendRequest`	net472	0.00146ns	0.000599ns	0.00224ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	559μs	3μs	15.6μs	0.568	0	0	41.63 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	680μs	2.27μs	7.86μs	0.342	0	0	41.72 KB
master	`WriteAndFlushEnrichedTraces`	net472	843μs	2.27μs	8.17μs	8.56	2.57	0.428	53.27 KB
#6152	`WriteAndFlushEnrichedTraces`	net6.0	556μs	2.34μs	9.36μs	0.548	0	0	41.47 KB
#6152	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	667μs	2.5μs	9.35μs	0.332	0	0	41.82 KB
#6152	`WriteAndFlushEnrichedTraces`	net472	868μs	3.8μs	14.7μs	8.3	2.62	0.437	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.27μs	1.55ns	5.8ns	0.0145	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	2.38ns	8.9ns	0.0131	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	1.85ns	6.93ns	0.157	987 B
#6152	`ExecuteNonQuery`	net6.0	1.25μs	1.48ns	5.73ns	0.0145	1.02 KB
#6152	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.9ns	7.36ns	0.0133	1.02 KB
#6152	`ExecuteNonQuery`	net472	2.08μs	3.36ns	12.1ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.09μs	1.22ns	4.72ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.63μs	0.507ns	1.9ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.55μs	1.26ns	4.89ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.419ns	1.51ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	1.55ns	5.81ns	0.0138	1.02 KB
master	`CallElasticsearchAsync`	net472	2.57μs	2.41ns	9.02ns	0.166	1.05 KB
#6152	`CallElasticsearch`	net6.0	1.12μs	0.723ns	2.8ns	0.0135	976 B
#6152	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.869ns	3.25ns	0.0133	976 B
#6152	`CallElasticsearch`	net472	2.58μs	2.69ns	10.4ns	0.157	995 B
#6152	`CallElasticsearchAsync`	net6.0	1.19μs	0.474ns	1.77ns	0.0132	952 B
#6152	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	6.61ns	25.6ns	0.0141	1.02 KB
#6152	`CallElasticsearchAsync`	net472	2.69μs	1.78ns	6.9ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.29μs	1.12ns	4.32ns	0.0129	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.66μs	3.5ns	13.6ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.72μs	0.571ns	2.21ns	0.145	915 B
#6152	`ExecuteAsync`	net6.0	1.26μs	0.829ns	3.1ns	0.0132	952 B
#6152	`ExecuteAsync`	netcoreapp3.1	1.59μs	1.12ns	4.19ns	0.0126	952 B
#6152	`ExecuteAsync`	net472	1.77μs	1.09ns	4.07ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.17μs	2.47ns	9.58ns	0.0311	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.01μs	2.23ns	8.65ns	0.0375	2.76 KB
master	`SendAsync`	net472	7.78μs	4.13ns	14.3ns	0.5	3.15 KB
#6152	`SendAsync`	net6.0	4.18μs	1.21ns	4.68ns	0.0312	2.22 KB
#6152	`SendAsync`	netcoreapp3.1	5.14μs	3.22ns	11.6ns	0.0359	2.76 KB
#6152	`SendAsync`	net472	7.71μs	2.39ns	8.93ns	0.497	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.862ns	3.23ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.31μs	1.19ns	4.45ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.69μs	0.793ns	2.86ns	0.25	1.57 KB
#6152	`EnrichedLog`	net6.0	1.59μs	1.5ns	5.81ns	0.0231	1.64 KB
#6152	`EnrichedLog`	netcoreapp3.1	2.34μs	2.16ns	8.35ns	0.0222	1.64 KB
#6152	`EnrichedLog`	net472	2.58μs	1.85ns	7.18ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	134ns	501ns	0.0594	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	225ns	871ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	276ns	1.07μs	0.673	0.224	4.46 KB
#6152	`EnrichedLog`	net6.0	118μs	114ns	441ns	0.0591	0	4.28 KB
#6152	`EnrichedLog`	netcoreapp3.1	122μs	124ns	482ns	0	0	4.28 KB
#6152	`EnrichedLog`	net472	150μs	176ns	681ns	0.668	0.223	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.91μs	1.11ns	4.29ns	0.0308	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.26μs	1.56ns	6.06ns	0.0299	2.2 KB
master	`EnrichedLog`	net472	4.95μs	3.49ns	13.5ns	0.318	2.02 KB
#6152	`EnrichedLog`	net6.0	3.18μs	1.83ns	7.09ns	0.0302	2.2 KB
#6152	`EnrichedLog`	netcoreapp3.1	4.41μs	2.92ns	11.3ns	0.0284	2.2 KB
#6152	`EnrichedLog`	net472	4.9μs	2.64ns	10.2ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.44μs	0.536ns	2ns	0.0159	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.75μs	1.06ns	4.11ns	0.0158	0	1.14 KB
master	`SendReceive`	net472	2.12μs	1.12ns	4.2ns	0.183	0.00106	1.16 KB
#6152	`SendReceive`	net6.0	1.38μs	0.987ns	3.82ns	0.016	0	1.14 KB
#6152	`SendReceive`	netcoreapp3.1	1.77μs	1.91ns	7.38ns	0.0151	0	1.14 KB
#6152	`SendReceive`	net472	2.12μs	0.794ns	2.97ns	0.183	0.00106	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.71μs	0.634ns	2.46ns	0.0217	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.97μs	1.38ns	5.18ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.54μs	1.32ns	4.94ns	0.322	2.04 KB
#6152	`EnrichedLog`	net6.0	2.73μs	0.937ns	3.38ns	0.0218	1.6 KB
#6152	`EnrichedLog`	netcoreapp3.1	3.99μs	2.41ns	9.02ns	0.022	1.65 KB
#6152	`EnrichedLog`	net472	4.58μs	4.56ns	17.6ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6152

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.138	717.24	816.56

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	400ns	0.173ns	0.669ns	0.00805	576 B
master	`StartFinishSpan`	netcoreapp3.1	594ns	0.522ns	2.02ns	0.00781	576 B
master	`StartFinishSpan`	net472	720ns	0.394ns	1.53ns	0.0915	578 B
master	`StartFinishScope`	net6.0	483ns	0.242ns	0.939ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	717ns	0.438ns	1.7ns	0.00935	696 B
master	`StartFinishScope`	net472	932ns	0.652ns	2.52ns	0.105	658 B
#6152	`StartFinishSpan`	net6.0	412ns	0.503ns	1.95ns	0.00805	576 B
#6152	`StartFinishSpan`	netcoreapp3.1	629ns	0.839ns	3.25ns	0.00773	576 B
#6152	`StartFinishSpan`	net472	690ns	0.695ns	2.69ns	0.0917	578 B
#6152	`StartFinishScope`	net6.0	489ns	0.368ns	1.42ns	0.00966	696 B
#6152	`StartFinishScope`	netcoreapp3.1	816ns	0.509ns	1.97ns	0.00941	696 B
#6152	`StartFinishScope`	net472	911ns	0.99ns	3.83ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6152

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.236	734.52	594.18

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	734ns	0.274ns	1.06ns	0.00982	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	916ns	0.21ns	0.758ns	0.00921	696 B
master	`RunOnMethodBegin`	net472	1.12μs	0.475ns	1.71ns	0.104	658 B
#6152	`RunOnMethodBegin`	net6.0	595ns	0.624ns	2.25ns	0.00972	696 B
#6152	`RunOnMethodBegin`	netcoreapp3.1	990ns	0.987ns	3.82ns	0.00902	696 B
#6152	`RunOnMethodBegin`	net472	1.16μs	1.03ns	4.01ns	0.104	658 B

andrewlock · 2024-10-14T14:59:25Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6152) (10.870M)   : 0, 10869840
    master (11.038M)   : 0, 11037687
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6152) (7.233M)   : 0, 7232973
    master (7.215M)   : 0, 7215320
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.562M)   : 0, 7562287

    section Manual
    master (10.967M)   : 0, 10966667

    section Manual + Automatic
    This PR (6152) (6.673M)   : 0, 6672684
    master (6.806M)   : 0, 6805569

    section DD_TRACE_ENABLED=0
    master (10.233M)   : 0, 10232747

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6152) (9.629M)   : 0, 9628675
    master (9.418M)   : 0, 9418416
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6152) (6.602M)   : 0, 6602208
    master (6.507M)   : 0, 6506963

    section Trace stats
    master (6.847M)   : 0, 6846734

    section Manual
    master (9.399M)   : 0, 9399114

    section Manual + Automatic
    This PR (6152) (6.120M)   : 0, 6120320
    master (6.146M)   : 0, 6145874

    section DD_TRACE_ENABLED=0
    master (8.826M)   : 0, 8826339

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6152) (10.529M)   : 0, 10528565
    master (10.033M)   : 0, 10033023
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6152) (6.911M)   : 0, 6910660
    master (6.731M)   : 0, 6731266
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.216M)   : 0, 7215733

    section Manual
    master (9.982M)   : 0, 9982329

    section Manual + Automatic
    This PR (6152) (6.384M)   : 0, 6383904
    master (6.328M)   : 0, 6328172

    section DD_TRACE_ENABLED=0
    master (9.298M)   : 0, 9298379

…6152)" This reverts commit e94a4c3.

…6220) Reverts #6152 Now that PDB support is implemented, we can reactivate crashtracking by default on Windows.

Disable crashtracking on Windows

0d4f3b3

kevingosse requested review from a team as code owners October 14, 2024 12:39

andrewlock approved these changes Oct 14, 2024

View reviewed changes

kevingosse merged commit e94a4c3 into master Oct 14, 2024
82 checks passed

kevingosse deleted the kevin/disable_ct_windows branch October 14, 2024 16:17

github-actions bot added this to the vNext-v3 milestone Oct 14, 2024

andrewlock added the area:crashtracking label Oct 23, 2024

kevingosse added a commit that referenced this pull request Oct 30, 2024

Revert "[Crashtracking] Disable crashtracking on Windows by default (#…

c61e12a

…6152)" This reverts commit e94a4c3.

kevingosse mentioned this pull request Oct 30, 2024

Revert "[Crashtracking] Disable crashtracking on Windows by default" #6220

Merged

kevingosse added a commit that referenced this pull request Oct 31, 2024

Revert "[Crashtracking] Disable crashtracking on Windows by default" (#…

42e161a

…6220) Reverts #6152 Now that PDB support is implemented, we can reactivate crashtracking by default on Windows.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Crashtracking] Disable crashtracking on Windows by default #6152

[Crashtracking] Disable crashtracking on Windows by default #6152

kevingosse commented Oct 14, 2024

andrewlock commented Oct 14, 2024

datadog-ddstaging bot commented Oct 14, 2024 •

edited

Loading

andrewlock commented Oct 14, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6152

Raw results

Faster 🎉 in #6152

Raw results

andrewlock commented Oct 14, 2024

[Crashtracking] Disable crashtracking on Windows by default #6152

[Crashtracking] Disable crashtracking on Windows by default #6152

Conversation

kevingosse commented Oct 14, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

andrewlock commented Oct 14, 2024

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Oct 14, 2024 • edited Loading

Datadog Report

New Flaky Tests (1)

andrewlock commented Oct 14, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6152

Raw results

Faster 🎉 in #6152

Raw results

andrewlock commented Oct 14, 2024

Throughput/Crank Report ⚡

datadog-ddstaging bot commented Oct 14, 2024 •

edited

Loading