[Test Package Versions Bump] Updating package versions #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 364926 Passed, 2085 Skipped, 14h 57m 45.64s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6150) - mean (70ms) : 68, 72
. : milestone, 70,
master - mean (71ms) : 67, 74
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6150) - mean (1,112ms) : 1092, 1132
. : milestone, 1112,
master - mean (1,112ms) : 1092, 1131
. : milestone, 1112,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6150) - mean (109ms) : 107, 112
. : milestone, 109,
master - mean (110ms) : 107, 112
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6150) - mean (773ms) : 758, 787
. : milestone, 773,
master - mean (772ms) : 758, 786
. : milestone, 772,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6150) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6150) - mean (727ms) : 714, 740
. : milestone, 727,
master - mean (730ms) : 715, 744
. : milestone, 730,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6150) - mean (191ms) : 187, 194
. : milestone, 191,
master - mean (190ms) : 187, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6150) - mean (1,198ms) : 1175, 1222
. : milestone, 1198,
master - mean (1,197ms) : 1175, 1218
. : milestone, 1197,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6150) - mean (274ms) : 270, 279
. : milestone, 274,
master - mean (275ms) : 270, 281
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (6150) - mean (942ms) : 921, 963
. : milestone, 942,
master - mean (942ms) : 921, 963
. : milestone, 942,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6150) - mean (264ms) : 259, 269
. : milestone, 264,
master - mean (264ms) : 260, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (6150) - mean (926ms) : 907, 944
. : milestone, 926,
master - mean (924ms) : 908, 941
. : milestone, 924,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6150) (10.917M) : 0, 10917487
master (10.882M) : 0, 10881568
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6150) (7.321M) : 0, 7320863
master (7.317M) : 0, 7316635
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.623M) : 0, 7623045
section Manual
master (10.951M) : 0, 10950703
section Manual + Automatic
This PR (6150) (6.731M) : 0, 6731391
master (6.819M) : 0, 6819307
section DD_TRACE_ENABLED=0
master (10.286M) : 0, 10285992
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6150) (9.617M) : 0, 9616728
master (9.597M) : 0, 9597086
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6150) (6.547M) : 0, 6547355
master (6.507M) : 0, 6506976
section Trace stats
master (6.974M) : 0, 6973790
section Manual
master (9.681M) : 0, 9681399
section Manual + Automatic
This PR (6150) (6.035M) : 0, 6035264
master (6.087M) : 0, 6087303
section DD_TRACE_ENABLED=0
master (8.998M) : 0, 8998225
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6150) (9.749M) : 0, 9749226
master (9.819M) : 0, 9819450
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6150) (6.464M) : 0, 6463696
master (6.586M) : 0, 6585785
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.084M) : 0, 7083786
section Manual
master (9.783M) : 0, 9782813
section Manual + Automatic
This PR (6150) (6.000M) : 0, 6000469
master (6.174M) : 0, 6173885
section DD_TRACE_ENABLED=0
master (9.427M) : 0, 9426895
|
Benchmarks Report for tracer 🐌Benchmarks for #6150 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.174 | 402.09 | 471.87 |
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.132 | 976.13 | 862.39 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 402ns | 0.441ns | 1.65ns | 0.00805 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 632ns | 0.427ns | 1.65ns | 0.00788 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 696ns | 1.48ns | 5.74ns | 0.0917 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 478ns | 0.205ns | 0.766ns | 0.00988 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 784ns | 0.406ns | 1.57ns | 0.00944 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 980ns | 2.07ns | 8.01ns | 0.105 | 0 | 0 | 658 B |
| #6150 | StartFinishSpan |
net6.0 | 471ns | 0.381ns | 1.47ns | 0.00807 | 0 | 0 | 576 B |
| #6150 | StartFinishSpan |
netcoreapp3.1 | 634ns | 0.568ns | 2.2ns | 0.0078 | 0 | 0 | 576 B |
| #6150 | StartFinishSpan |
net472 | 705ns | 2.43ns | 9.41ns | 0.0916 | 0 | 0 | 578 B |
| #6150 | StartFinishScope |
net6.0 | 495ns | 1.4ns | 5.03ns | 0.00977 | 0 | 0 | 696 B |
| #6150 | StartFinishScope |
netcoreapp3.1 | 733ns | 0.613ns | 2.37ns | 0.00939 | 0 | 0 | 696 B |
| #6150 | StartFinishScope |
net472 | 862ns | 0.723ns | 2.8ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6150
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1
1.128
920.83
1,038.33
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.128 | 920.83 | 1,038.33 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 707ns | 0.466ns | 1.8ns | 0.00966 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 921ns | 0.484ns | 1.81ns | 0.00926 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.09μs | 0.542ns | 2.1ns | 0.104 | 0 | 0 | 658 B |
| #6150 | RunOnMethodBegin |
net6.0 | 647ns | 0.478ns | 1.85ns | 0.00979 | 0 | 0 | 696 B |
| #6150 | RunOnMethodBegin |
netcoreapp3.1 | 1.04μs | 0.895ns | 3.46ns | 0.00924 | 0 | 0 | 696 B |
| #6150 | RunOnMethodBegin |
net472 | 1.15μs | 0.46ns | 1.78ns | 0.104 | 0 | 0 | 658 B |
andrewlock
approved these changes
Oct 14, 2024
Comment on lines
+46
to
52
| <!-- Latest package https://www.nuget.org/packages/Azure.Messaging.ServiceBus/7.18.2 --> | ||
| <PackageReference Include="Azure.Messaging.ServiceBus" Version="7.17.5" /> |
There was a problem hiding this comment.
🤔 Hmmm, we should probably test and bump this soon seeing as we're at a different minor version
There was a problem hiding this comment.
I have it on my backlog of things to do 😭 but no time to do it
Comment on lines
158
to
159
| <!-- Latest package https://www.nuget.org/packages/Microsoft.Azure.Cosmos/3.44.0 --> | ||
| <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.44.0" /> |
There was a problem hiding this comment.
I'll toss it on the backlog to test
I'll also remove this one from being bumped automatically until it is actually tested on CI automatically
github-actions
bot
force-pushed
the
bot/test-package-versions-bump
branch
from
23c8d32
to
b2ddb28
Compare
bouwkast
reviewed
Oct 22, 2024
| <!-- Latest package https://www.nuget.org/packages/Microsoft.Azure.Cosmos/3.43.1 --> | ||
| <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.43.1" /> | ||
| <!-- Latest package https://www.nuget.org/packages/Microsoft.Azure.Cosmos/3.44.1 --> | ||
| <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.44.1" /> |
andrewlock
added
area:test-apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package versions for integration tests.