Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] Update fingerprint rules #6133

Merged
merged 3 commits into from
Oct 9, 2024
Merged

[ASM] Update fingerprint rules #6133

merged 3 commits into from
Oct 9, 2024
+400 −257

Conversation

NachoEchevarria
Copy link
Contributor

@NachoEchevarria NachoEchevarria commented Oct 9, 2024 •
edited
Loading

Summary of changes

This PR updates the format of the fingerprint rules as described in the RFC

We don't send anymore the { "fingerprint", true } request to the WAF. Instead, the WAF returns the fingerprints when a match occurs. This way, we save one WAF call.

Reason for change

Implementation details

Test coverage

Other details

@NachoEchevarria NachoEchevarria changed the title Update tests and code [ASM] Update fingerprint rules Oct 9, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 9, 2024 •
edited
Loading

Datadog Report

Branch report: nacho/UpdateFPRules
Commit report: a84c82e
Test service: dd-trace-dotnet

✅ 0 Failed, 367474 Passed, 2106 Skipped, 15h 31m 0.24s Total Time

@andrewlock
Copy link
Member

andrewlock commented Oct 9, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6133) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6133) - mean (1,115ms)  : 1096, 1134
     .   : milestone, 1115,
    master - mean (1,112ms)  : 1092, 1132
     .   : milestone, 1112,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6133) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6133) - mean (773ms)  : 758, 788
     .   : milestone, 773,
    master - mean (773ms)  : 757, 790
     .   : milestone, 773,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6133) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (93ms)  : 90, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6133) - mean (726ms)  : 711, 742
     .   : milestone, 726,
    master - mean (728ms)  : 711, 745
     .   : milestone, 728,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6133) - mean (189ms)  : 184, 193
     .   : milestone, 189,
    master - mean (188ms)  : 185, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (6133) - mean (1,196ms)  : 1176, 1217
     .   : milestone, 1196,
    master - mean (1,197ms)  : 1170, 1224
     .   : milestone, 1197,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6133) - mean (274ms)  : 269, 278
     .   : milestone, 274,
    master - mean (274ms)  : 270, 277
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (6133) - mean (937ms)  : 920, 954
     .   : milestone, 937,
    master - mean (940ms)  : 923, 958
     .   : milestone, 940,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6133) - mean (263ms)  : 258, 268
     .   : milestone, 263,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6133) - mean (919ms)  : 906, 933
     .   : milestone, 919,
    master - mean (925ms)  : 904, 947
     .   : milestone, 925,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for appsec 🐌

Benchmarks for #6133 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.183
  • 2 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6133

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472 1.192 165.16 196.84
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.175 209.83 246.47

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 72.5μs 77.3ns 289ns 0.0725 0 0 6.01 KB
master AllCycleSimpleBody netcoreapp3.1 61.7μs 86.7ns 336ns 0.0931 0 0 6.95 KB
master AllCycleSimpleBody net472 49.6μs 96.1ns 372ns 1.3 0 0 8.34 KB
master AllCycleMoreComplexBody net6.0 76.7μs 116ns 451ns 0.115 0 0 9.51 KB
master AllCycleMoreComplexBody netcoreapp3.1 69.3μs 54.5ns 211ns 0.139 0 0 10.36 KB
master AllCycleMoreComplexBody net472 57.1μs 155ns 557ns 1.86 0.0282 0 11.85 KB
master ObjectExtractorSimpleBody net6.0 144ns 0.164ns 0.636ns 0.00392 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 210ns 0.301ns 1.13ns 0.0037 0 0 272 B
master ObjectExtractorSimpleBody net472 165ns 0.16ns 0.599ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.15μs 1.05ns 4.05ns 0.0534 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.91μs 1.89ns 7.33ns 0.0507 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.88μs 7.65ns 29.6ns 0.603 0.0058 0 3.8 KB
#6133 AllCycleSimpleBody net6.0 71.6μs 110ns 398ns 0.0712 0 0 6.01 KB
#6133 AllCycleSimpleBody netcoreapp3.1 62.8μs 67.9ns 245ns 0.0939 0 0 6.95 KB
#6133 AllCycleSimpleBody net472 48.3μs 40.4ns 156ns 1.32 0 0 8.34 KB
#6133 AllCycleMoreComplexBody net6.0 78.4μs 86.6ns 324ns 0.118 0 0 9.51 KB
#6133 AllCycleMoreComplexBody netcoreapp3.1 69.3μs 94.9ns 355ns 0.138 0 0 10.36 KB
#6133 AllCycleMoreComplexBody net472 56.7μs 79ns 306ns 1.87 0.0279 0 11.85 KB
#6133 ObjectExtractorSimpleBody net6.0 146ns 0.194ns 0.753ns 0.00392 0 0 280 B
#6133 ObjectExtractorSimpleBody netcoreapp3.1 247ns 0.359ns 1.29ns 0.00371 0 0 272 B
#6133 ObjectExtractorSimpleBody net472 197ns 0.265ns 1.03ns 0.0446 0 0 281 B
#6133 ObjectExtractorMoreComplexBody net6.0 3.09μs 1.64ns 6.12ns 0.0523 0 0 3.78 KB
#6133 ObjectExtractorMoreComplexBody netcoreapp3.1 3.96μs 16.9ns 127ns 0.0504 0 0 3.69 KB
#6133 ObjectExtractorMoreComplexBody net472 3.81μs 3.15ns 12.2ns 0.603 0.00571 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 37.5μs 20.2ns 78.2ns 0.448 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 55.5μs 25.4ns 98.3ns 0.441 0 0 32.4 KB
master EncodeArgs net472 67μs 35.1ns 136ns 5.14 0.0672 0 32.5 KB
master EncodeLegacyArgs net6.0 73.3μs 21.9ns 84.9ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 106μs 111ns 416ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 151μs 148ns 574ns 0.304 0 0 2.15 KB
#6133 EncodeArgs net6.0 36.9μs 11.8ns 45.5ns 0.46 0 0 32.4 KB
#6133 EncodeArgs netcoreapp3.1 54μs 18ns 69.7ns 0.431 0 0 32.4 KB
#6133 EncodeArgs net472 66.9μs 61.8ns 223ns 5.14 0.0672 0 32.5 KB
#6133 EncodeLegacyArgs net6.0 77.4μs 25.1ns 93.8ns 0 0 0 2.14 KB
#6133 EncodeLegacyArgs netcoreapp3.1 106μs 376ns 1.46μs 0 0 0 2.14 KB
#6133 EncodeLegacyArgs net472 150μs 119ns 461ns 0.302 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 186μs 59.1ns 229ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 197μs 244ns 913ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 209μs 107ns 415ns 0.315 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 123μs 51.8ns 194ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 130μs 47.6ns 178ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 140μs 101ns 392ns 0.21 0 0 1.49 KB
#6133 RunWafRealisticBenchmark net6.0 184μs 98.4ns 381ns 0 0 0 2.44 KB
#6133 RunWafRealisticBenchmark netcoreapp3.1 200μs 729ns 2.83μs 0 0 0 2.39 KB
#6133 RunWafRealisticBenchmark net472 209μs 81.1ns 314ns 0.314 0 0 2.46 KB
#6133 RunWafRealisticBenchmarkWithAttack net6.0 122μs 66.4ns 249ns 0 0 0 1.47 KB
#6133 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 64.5ns 250ns 0 0 0 1.46 KB
#6133 RunWafRealisticBenchmarkWithAttack net472 140μs 65.7ns 254ns 0.21 0 0 1.49 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6133

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 252.94 KB 254.41 KB 1.46 KB 0.58%

Fewer allocations 🎉 in #6133

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 59.07 KB 57.16 KB -1.91 KB -3.24%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 263.63 KB 254.65 KB -8.98 KB -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 63.9μs 887ns 8.78μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.5μs 163ns 588ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.7μs 84.3ns 315ns 0 0 0 59.07 KB
master StringConcatAspectBenchmark net6.0 315μs 1.78μs 11.4μs 0 0 0 263.63 KB
master StringConcatAspectBenchmark netcoreapp3.1 327μs 1.6μs 8.9μs 0 0 0 252.94 KB
master StringConcatAspectBenchmark net472 279μs 6.18μs 59.9μs 0 0 0 278.53 KB
#6133 StringConcatBenchmark net6.0 57μs 682ns 6.68μs 0 0 0 43.44 KB
#6133 StringConcatBenchmark netcoreapp3.1 63.2μs 921ns 9.16μs 0 0 0 42.64 KB
#6133 StringConcatBenchmark net472 37.5μs 157ns 737ns 0 0 0 57.16 KB
#6133 StringConcatAspectBenchmark net6.0 315μs 1.6μs 7.7μs 0 0 0 254.65 KB
#6133 StringConcatAspectBenchmark netcoreapp3.1 320μs 5.78μs 55.4μs 0 0 0 254.41 KB
#6133 StringConcatAspectBenchmark net472 284μs 6.95μs 67.4μs 0 0 0 278.53 KB

@NachoEchevarria NachoEchevarria marked this pull request as ready for review October 9, 2024 09:59
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner October 9, 2024 09:59
@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6133 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.269
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.71μs 43.8ns 322ns 0.0117 0.00389 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.89μs 57.3ns 462ns 0.0203 0.0101 0 5.62 KB
master StartStopWithChild net472 17μs 71.6ns 277ns 1.03 0.318 0.103 6.05 KB
#6133 StartStopWithChild net6.0 7.74μs 44ns 308ns 0.0144 0.00721 0 5.42 KB
#6133 StartStopWithChild netcoreapp3.1 10.5μs 68.1ns 646ns 0.0206 0.0103 0 5.61 KB
#6133 StartStopWithChild net472 16.8μs 49.8ns 193ns 1 0.28 0.0763 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 486μs 451ns 1.69μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 447ns 1.73μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 836μs 520ns 1.88μs 0.419 0 0 3.3 KB
#6133 WriteAndFlushEnrichedTraces net6.0 476μs 460ns 1.78μs 0 0 0 2.7 KB
#6133 WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 361ns 1.3μs 0 0 0 2.7 KB
#6133 WriteAndFlushEnrichedTraces net472 838μs 1.27μs 4.75μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 207μs 1.15μs 9.76μs 0.212 0 0 18.45 KB
master SendRequest netcoreapp3.1 233μs 1.32μs 9.13μs 0.225 0 0 20.61 KB
master SendRequest net472 0.00426ns 0.00218ns 0.00843ns 0 0 0 0 b
#6133 SendRequest net6.0 223μs 1.79μs 17.7μs 0.225 0 0 18.45 KB
#6133 SendRequest netcoreapp3.1 240μs 1.39μs 12.1μs 0.134 0 0 20.61 KB
#6133 SendRequest net472 0.000164ns 0.000164ns 0.000636ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 562μs 2.53μs 10.4μs 0.635 0 0 41.58 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 719μs 3.99μs 26.5μs 0.336 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 875μs 3.53μs 13.2μs 8.42 2.66 0.443 53.34 KB
#6133 WriteAndFlushEnrichedTraces net6.0 596μs 2.53μs 9.46μs 0.595 0 0 41.54 KB
#6133 WriteAndFlushEnrichedTraces netcoreapp3.1 712μs 4.03μs 27.6μs 0.347 0 0 41.66 KB
#6133 WriteAndFlushEnrichedTraces net472 866μs 4.3μs 18.3μs 8.08 2.55 0.425 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.31μs 0.706ns 2.64ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 1.68ns 6.5ns 0.0134 0 0 1.02 KB
master ExecuteNonQuery net472 2.01μs 2.22ns 8.3ns 0.157 0.00101 0 987 B
#6133 ExecuteNonQuery net6.0 1.26μs 1.42ns 5.51ns 0.0141 0 0 1.02 KB
#6133 ExecuteNonQuery netcoreapp3.1 1.77μs 2.75ns 10.7ns 0.0133 0 0 1.02 KB
#6133 ExecuteNonQuery net472 2.19μs 2ns 7.74ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6133

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.370 1,804.43 1,317.26 several?
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.319 1,959.99 1,486.37 several?
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.217 1,623.69 1,333.95

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.64μs 13.6ns 136ns 0.0132 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.99μs 16ns 159ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.44μs 1.61ns 6.22ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.79μs 15ns 149ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 2.85ns 15.1ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 0.639ns 2.39ns 0.166 0 0 1.05 KB
#6133 CallElasticsearch net6.0 1.33μs 0.747ns 2.89ns 0.0134 0 0 976 B
#6133 CallElasticsearch netcoreapp3.1 1.49μs 0.672ns 2.51ns 0.0133 0 0 976 B
#6133 CallElasticsearch net472 2.66μs 1.02ns 3.95ns 0.158 0 0 995 B
#6133 CallElasticsearchAsync net6.0 1.32μs 0.801ns 3.1ns 0.0132 0 0 952 B
#6133 CallElasticsearchAsync netcoreapp3.1 1.61μs 1.13ns 4.22ns 0.0138 0 0 1.02 KB
#6133 CallElasticsearchAsync net472 2.56μs 1.81ns 7ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 3.84ns 14.4ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 0.536ns 1.86ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.81μs 1.1ns 4.25ns 0.145 0 0 915 B
#6133 ExecuteAsync net6.0 1.31μs 2.21ns 8.27ns 0.0129 0 0 952 B
#6133 ExecuteAsync netcoreapp3.1 1.64μs 1.11ns 4.14ns 0.0131 0 0 952 B
#6133 ExecuteAsync net472 1.78μs 0.771ns 2.99ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.12μs 1.39ns 5.02ns 0.0309 0 0 2.22 KB
master SendAsync netcoreapp3.1 4.99μs 2.63ns 10.2ns 0.0375 0 0 2.76 KB
master SendAsync net472 7.96μs 1.15ns 3.97ns 0.499 0 0 3.15 KB
#6133 SendAsync net6.0 4.06μs 0.948ns 3.55ns 0.0304 0 0 2.22 KB
#6133 SendAsync netcoreapp3.1 5.14μs 1.66ns 6.45ns 0.0361 0 0 2.76 KB
#6133 SendAsync net472 7.75μs 2.56ns 9.93ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.595ns 2.23ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.27μs 3.9ns 14.6ns 0.0225 0 0 1.64 KB
master EnrichedLog net472 2.44μs 0.854ns 3.31ns 0.249 0 0 1.57 KB
#6133 EnrichedLog net6.0 1.55μs 0.751ns 2.81ns 0.0231 0 0 1.64 KB
#6133 EnrichedLog netcoreapp3.1 2.29μs 1.53ns 5.94ns 0.0218 0 0 1.64 KB
#6133 EnrichedLog net472 2.49μs 0.804ns 3.11ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 107ns 416ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 118μs 134ns 502ns 0.0593 0 0 4.28 KB
master EnrichedLog net472 149μs 162ns 629ns 0.662 0.221 0 4.46 KB
#6133 EnrichedLog net6.0 116μs 149ns 577ns 0.0579 0 0 4.28 KB
#6133 EnrichedLog netcoreapp3.1 118μs 182ns 705ns 0.0587 0 0 4.28 KB
#6133 EnrichedLog net472 147μs 142ns 552ns 0.662 0.221 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.94μs 2.04ns 7.63ns 0.0307 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.36μs 3.11ns 12ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.67μs 1.37ns 5.31ns 0.319 0 0 2.02 KB
#6133 EnrichedLog net6.0 2.91μs 0.656ns 2.45ns 0.0305 0 0 2.2 KB
#6133 EnrichedLog netcoreapp3.1 4.09μs 1.62ns 6.29ns 0.0286 0 0 2.2 KB
#6133 EnrichedLog net472 4.89μs 0.943ns 3.65ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 0.754ns 2.92ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 1.03ns 3.87ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.03μs 0.533ns 2ns 0.183 0.00103 0 1.16 KB
#6133 SendReceive net6.0 1.3μs 0.571ns 2.14ns 0.0161 0 0 1.14 KB
#6133 SendReceive netcoreapp3.1 1.81μs 1.57ns 6.07ns 0.0153 0 0 1.14 KB
#6133 SendReceive net472 1.99μs 0.833ns 3.12ns 0.183 0.000998 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.83μs 1.45ns 5.62ns 0.0227 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.96μs 1.55ns 6.02ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.33μs 1.97ns 7.65ns 0.322 0 0 2.04 KB
#6133 EnrichedLog net6.0 2.84μs 0.805ns 3.12ns 0.0228 0 0 1.6 KB
#6133 EnrichedLog netcoreapp3.1 3.89μs 0.952ns 3.69ns 0.0214 0 0 1.65 KB
#6133 EnrichedLog net472 4.46μs 3.69ns 14.3ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 408ns 0.105ns 0.408ns 0.00814 0 0 576 B
master StartFinishSpan netcoreapp3.1 570ns 0.337ns 1.22ns 0.00774 0 0 576 B
master StartFinishSpan net472 639ns 0.784ns 2.93ns 0.0916 0 0 578 B
master StartFinishScope net6.0 484ns 0.295ns 1.1ns 0.00965 0 0 696 B
master StartFinishScope netcoreapp3.1 721ns 0.498ns 1.93ns 0.00938 0 0 696 B
master StartFinishScope net472 958ns 1.72ns 6.66ns 0.104 0 0 658 B
#6133 StartFinishSpan net6.0 403ns 0.198ns 0.767ns 0.00812 0 0 576 B
#6133 StartFinishSpan netcoreapp3.1 543ns 0.29ns 1.09ns 0.0079 0 0 576 B
#6133 StartFinishSpan net472 577ns 0.39ns 1.51ns 0.0916 0 0 578 B
#6133 StartFinishScope net6.0 484ns 0.475ns 1.78ns 0.00971 0 0 696 B
#6133 StartFinishScope netcoreapp3.1 773ns 2.66ns 10.3ns 0.00941 0 0 696 B
#6133 StartFinishScope net472 873ns 0.33ns 1.28ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6133

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.179 747.54 633.78

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 747ns 0.478ns 1.85ns 0.00978 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 973ns 0.635ns 2.46ns 0.00943 0 0 696 B
master RunOnMethodBegin net472 1.11μs 1.53ns 5.91ns 0.104 0 0 658 B
#6133 RunOnMethodBegin net6.0 634ns 0.289ns 1.12ns 0.00963 0 0 696 B
#6133 RunOnMethodBegin netcoreapp3.1 911ns 0.345ns 1.33ns 0.00938 0 0 696 B
#6133 RunOnMethodBegin net472 1.14μs 0.617ns 2.39ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6133) (11.204M)   : 0, 11204487
    master (11.079M)   : 0, 11078559
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6133) (7.421M)   : 0, 7420949
    master (7.386M)   : 0, 7386443
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.713M)   : 0, 7712834

    section Manual
    master (11.018M)   : 0, 11017937

    section Manual + Automatic
    This PR (6133) (6.758M)   : 0, 6757812
    master (6.613M)   : 0, 6612639

    section DD_TRACE_ENABLED=0
    master (10.053M)   : 0, 10053422
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6133) (9.457M)   : 0, 9456842
    master (9.526M)   : 0, 9525850
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6133) (6.614M)   : 0, 6613947
    master (6.681M)   : 0, 6681283

    section Trace stats
    master (6.777M)   : 0, 6776516

    section Manual
    master (9.415M)   : 0, 9414731

    section Manual + Automatic
    This PR (6133) (6.163M)   : 0, 6162944
    master (6.041M)   : 0, 6040733

    section DD_TRACE_ENABLED=0
    master (8.889M)   : 0, 8889196
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6133) (10.012M)   : 0, 10012430
    master (10.051M)   : 0, 10051465
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6133) (6.621M)   : 0, 6621392
    master (6.864M)   : 0, 6863948
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.474M)   : 0, 7474103

    section Manual
    master (10.111M)   : 0, 10111107

    section Manual + Automatic
    This PR (6133) (6.033M)   : crit ,0, 6033229
    master (6.488M)   : 0, 6487624

    section DD_TRACE_ENABLED=0
    master (9.588M)   : 0, 9587571
Loading

e-n-0
e-n-0 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@e-n-0 e-n-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@NachoEchevarria
Copy link
Contributor Author

Thanks for the reviews!

@NachoEchevarria NachoEchevarria merged commit c1415cd into master Oct 9, 2024
73 of 74 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/UpdateFPRules branch October 9, 2024 14:01
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-romano-DD daniel-romano-DD daniel-romano-DD approved these changes

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees
No one assigned
Labels
area:asm
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NachoEchevarria @andrewlock @e-n-0 @daniel-romano-DD