Disable debugger exploration tests #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6085) - mean (71ms) : 67, 74
. : milestone, 71,
master - mean (71ms) : 67, 74
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6085) - mean (1,109ms) : 1086, 1132
. : milestone, 1109,
master - mean (1,105ms) : 1089, 1122
. : milestone, 1105,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6085) - mean (110ms) : 105, 114
. : milestone, 110,
master - mean (110ms) : 107, 114
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6085) - mean (781ms) : 760, 801
. : milestone, 781,
master - mean (777ms) : 762, 793
. : milestone, 777,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6085) - mean (94ms) : 90, 99
. : milestone, 94,
master - mean (93ms) : 90, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6085) - mean (739ms) : 722, 757
. : milestone, 739,
master - mean (735ms) : 711, 758
. : milestone, 735,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6085) - mean (191ms) : 185, 198
. : milestone, 191,
master - mean (191ms) : 186, 196
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6085) - mean (1,201ms) : 1178, 1224
. : milestone, 1201,
master - mean (1,195ms) : 1170, 1221
. : milestone, 1195,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6085) - mean (275ms) : 271, 280
. : milestone, 275,
master - mean (277ms) : 273, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6085) - mean (942ms) : 924, 961
. : milestone, 942,
master - mean (946ms) : 927, 965
. : milestone, 946,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6085) - mean (265ms) : 261, 268
. : milestone, 265,
master - mean (267ms) : 262, 273
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6085) - mean (931ms) : 913, 948
. : milestone, 931,
master - mean (930ms) : 911, 949
. : milestone, 930,
|
kevingosse
approved these changes
Sep 26, 2024
Datadog ReportBranch report: ✅ 0 Failed, 370708 Passed, 2092 Skipped, 15h 29m 23.42s Total Time |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6085) (11.111M) : 0, 11110742
master (11.031M) : 0, 11030770
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6085) (7.370M) : 0, 7369919
master (7.287M) : 0, 7286559
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.697M) : 0, 7696608
section Manual
master (11.084M) : 0, 11083839
section Manual + Automatic
This PR (6085) (6.809M) : 0, 6808716
master (6.821M) : 0, 6821015
section DD_TRACE_ENABLED=0
master (10.243M) : 0, 10243116
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6085) (9.569M) : 0, 9569490
master (9.514M) : 0, 9514330
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6085) (6.591M) : 0, 6591069
master (6.630M) : 0, 6629847
section Trace stats
master (6.750M) : 0, 6749832
section Manual
master (9.657M) : 0, 9657097
section Manual + Automatic
This PR (6085) (6.114M) : 0, 6114497
master (5.882M) : 0, 5881704
section DD_TRACE_ENABLED=0
master (8.860M) : 0, 8860464
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6085) (10.060M) : 0, 10059557
master (10.111M) : 0, 10110593
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6085) (6.841M) : 0, 6841416
master (6.720M) : 0, 6720265
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.385M) : 0, 7384835
section Manual
master (10.056M) : 0, 10056146
section Manual + Automatic
This PR (6085) (6.328M) : 0, 6328054
master (6.271M) : 0, 6270956
section DD_TRACE_ENABLED=0
master (9.426M) : 0, 9425661
|
Benchmarks Report for tracer 🐌Benchmarks for #6085 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.259 | 739.36 | 587.24 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 739ns | 0.67ns | 2.59ns | 0.00963 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 868ns | 0.742ns | 2.87ns | 0.0094 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.11μs | 1.07ns | 3.86ns | 0.104 | 0 | 0 | 658 B |
| #6085 | RunOnMethodBegin |
net6.0 | 587ns | 0.292ns | 1.13ns | 0.00977 | 0 | 0 | 696 B |
| #6085 | RunOnMethodBegin |
netcoreapp3.1 | 949ns | 0.485ns | 1.75ns | 0.00942 | 0 | 0 | 696 B |
| #6085 | RunOnMethodBegin |
net472 | 1.12μs | 1.21ns | 4.68ns | 0.104 | 0 | 0 | 658 B |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Disables the debugger exploration tests
Reason for change
They're all completely broken
Implementation details
Disable the tests until debugger team can look into them
Test coverage
This is the test